• L
    Consolidate SliceTransform object ownership · 8d007b4a
    Lei Jin 提交于
    Summary:
    (1) Fix SanitizeOptions() to also check HashLinkList. The current
    dynamic case just happens to work because the 2 classes have the same
    layout.
    (2) Do not delete SliceTransform object in HashSkipListFactory and
    HashLinkListFactory destructor. Reason: SanitizeOptions() enforces
    prefix_extractor and SliceTransform to be the same object when
    Hash**Factory is used. This makes the behavior strange: when
    Hash**Factory is used, prefix_extractor will be released by RocksDB. If
    other memtable factory is used, prefix_extractor should be released by
    user.
    
    Test Plan: db_bench && make asan_check
    
    Reviewers: haobo, igor, sdong
    
    Reviewed By: igor
    
    CC: leveldb, dhruba
    
    Differential Revision: https://reviews.facebook.net/D16587
    8d007b4a
可在Tags中查看这些版本中当前仓库的状态.
HISTORY.md 3.2 KB