• I
    Better error handling in BackupEngine · 8a9fca26
    Igor Canadi 提交于
    Summary:
    Couple of changes here:
    * NewBackupEngine() and NewReadOnlyBackupEngine() are now removed. They were deprecated since RocksDB 3.8. Changing these to new functions should be pretty straight-forward. As a followup, I'll fix all fbcode callsights
    * Instead of initializing backup engine in the constructor, we initialize it in a separate function now. That way, we can catch all errors and return appropriate status code.
    * We catch all errors during initializations and return them to the client properly.
    * Added new tests to backupable_db_test, to make sure that we can't open BackupEngine when there are Env errors.
    * Transitioned backupable_db_test to use BackupEngine rather than BackupableDB. From the two available APIs, judging by the current use-cases, it looks like BackupEngine API won. It's much more flexible since it doesn't require StackableDB.
    
    Test Plan: Added a new unit test to backupable_db_test
    
    Reviewers: yhchiang, sdong, AaronFeldman
    
    Reviewed By: AaronFeldman
    
    Subscribers: dhruba, leveldb
    
    Differential Revision: https://reviews.facebook.net/D41925
    8a9fca26
可在Tags中查看这些版本中当前仓库的状态.
HISTORY.md 23.3 KB