• M
    Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262) · 8948dc85
    mrambacher 提交于
    Summary:
    The ImmutableCFOptions contained a bunch of fields that belonged to the ImmutableDBOptions.  This change cleans that up by introducing an ImmutableOptions struct.  Following the pattern of Options struct, this class inherits from the DB and CFOption structs (of the Immutable form).
    
    Only one structural change (the ImmutableCFOptions::fs was changed to a shared_ptr from a raw one) is in this PR.  All of the other changes involve moving the member variables from the ImmutableCFOptions into the ImmutableOptions and changing member variables or function parameters as required for compilation purposes.
    
    Follow-on PRs may do a further clean-up of the code, such as renaming variables (such as "ImmutableOptions cf_options") and potentially eliminating un-needed function parameters (there is no longer a need to pass both an ImmutableDBOptions and an ImmutableOptions to a function).
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/8262
    
    Reviewed By: pdillinger
    
    Differential Revision: D28226540
    
    Pulled By: mrambacher
    
    fbshipit-source-id: 18ae71eadc879dedbe38b1eb8e6f9ff5c7147dbf
    8948dc85
db_options.cc 40.0 KB