• I
    rocksdb: Add missing override · 62247ffa
    Igor Sugak 提交于
    Summary:
    When using latest clang (3.6 or 3.7/trunck) rocksdb is failing with many errors. Almost all of them are missing override errors. This diff adds missing override keyword. No manual changes.
    
    Prerequisites: bear and clang 3.5 build with extra tools
    
    ```lang=bash
    % USE_CLANG=1 bear make all # generate a compilation database http://clang.llvm.org/docs/JSONCompilationDatabase.html
    % clang-modernize -p . -include . -add-override
    % make format
    ```
    
    Test Plan:
    Make sure all tests are passing.
    ```lang=bash
    % #Use default fb code clang.
    % make check
    ```
    Verify less error and no missing override errors.
    ```lang=bash
    % # Have trunk clang present in path.
    % ROCKSDB_NO_FBCODE=1 CC=clang CXX=clang++ make
    ```
    
    Reviewers: igor, kradhakrishnan, rven, meyering, sdong
    
    Reviewed By: sdong
    
    Subscribers: dhruba, leveldb
    
    Differential Revision: https://reviews.facebook.net/D34077
    62247ffa
db_impl.cc 139.4 KB