• I
    Turn on -Wshadow · 5c930905
    Igor Canadi 提交于
    Summary:
    Only one more try, I promise.
    
    I talked to Jim and he mentioned that if we include our system includes with -isystem rather than with -I, that signals to the compile that those are system includes and thus no warnings are issued. So I turned our glibc includes into system includes and now we no longer get the warning from there, making us shadow-warning-free!
    
    Test Plan: compiles with both clang and gcc
    
    Reviewers: sdong, yhchiang, rven, ljin
    
    Reviewed By: ljin
    
    Subscribers: dhruba, leveldb
    
    Differential Revision: https://reviews.facebook.net/D28479
    5c930905
Makefile 29.8 KB