• D
    Do not enable checksums for zlib compression. · 507f5aac
    Dhruba Borthakur 提交于
    Summary:
    Leveldb code already calculates checksums for each block. There
    is no need to generate checksums inside zlib. This patch switches-off checksum generation/checking in zlib library.
    
    (The Inno support for zlib uses windowsBits=14 as well.)
    
    pfabricator marks this file as binary. But here is the diff
    
    diff --git a/port/port_posix.h b/port/port_posix.h
    index 86a0927..db4e0b8 100644
    --- a/port/port_posix.h
    +++ b/port/port_posix.h
    @@ -163,7 +163,7 @@ inline bool Snappy_Uncompress(const char* input, size_t length,
     }
    
     inline bool Zlib_Compress(const char* input, size_t length,
    -    ::std::string* output, int windowBits = 15, int level = -1,
    +    ::std::string* output, int windowBits = -14, int level = -1,
          int strategy = 0) {
     #ifdef ZLIB
       // The memLevel parameter specifies how much memory should be allocated for
    @@ -223,7 +223,7 @@ inline bool Zlib_Compress(const char* input, size_t length,
     }
    
     inline char* Zlib_Uncompress(const char* input_data, size_t input_length,
    -    int* decompress_size, int windowBits = 15) {
    +    int* decompress_size, int windowBits = -14) {
     #ifdef ZLIB
       z_stream _stream;
       memset(&_stream, 0, sizeof(z_stream));
    
    Test Plan: run db_bench with zlib compression.
    
    Reviewers: heyongqiang, MarkCallaghan
    
    Reviewed By: heyongqiang
    
    Differential Revision: https://reviews.facebook.net/D6105
    507f5aac
port_posix.h 10.5 KB