• A
    Improvements to Env::GetChildren (#7819) · 4926b337
    Adam Retter 提交于
    Summary:
    The main improvement here is to not include `.` or `..` in the results of `Env::GetChildren`. The occurrence of `.` or `..`; it is non-portable, dependent on the Operating System and the File System. See: https://www.gnu.org/software/libc/manual/html_node/Reading_002fClosing-Directory.html
    
    There were lots of duplicate checks spread through the RocksDB codebase previously to skip `.` and `..`. This new removes the need for those at the source.
    
    Also some minor fixes to `Env::GetChildren`:
    * Improve error handling in POSIX implementation
    * Remove unnecessary array allocation on Windows
    * Fix struct name for Windows Non-UTF-8 API
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/7819
    
    Reviewed By: ajkr
    
    Differential Revision: D25837394
    
    Pulled By: jay-zhuang
    
    fbshipit-source-id: 1e137e7218d38b450af9c083f73d5357abcbba2e
    4926b337
backupable_db.cc 87.2 KB