• Z
    Pass IOStatus to write path and set retryable IO Error as hard error in BG jobs (#6487) · 42468881
    Zhichao Cao 提交于
    Summary:
    In the current code base, we use Status to get and store the returned status from the call. Specifically, for IO related functions, the current Status cannot reflect the IO Error details such as error scope, error retryable attribute, and others. With the implementation of https://github.com/facebook/rocksdb/issues/5761, we have the new Wrapper for IO, which returns IOStatus instead of Status. However, the IOStatus is purged at the lower level of write path and transferred to Status.
    
    The first job of this PR is to pass the IOStatus to the write path (flush, WAL write, and Compaction). The second job is to identify the Retryable IO Error as HardError, and set the bg_error_ as HardError. In this case, the DB Instance becomes read only. User is informed of the Status and need to take actions to deal with it (e.g., call db->Resume()).
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/6487
    
    Test Plan: Added the testing case to error_handler_fs_test. Pass make asan_check
    
    Reviewed By: anand1976
    
    Differential Revision: D20685017
    
    Pulled By: zhichao-cao
    
    fbshipit-source-id: ff85f042896243abcd6ef37877834e26f36b6eb0
    42468881
builder.h 3.8 KB