• A
    Seek parallelization (#9994) · 2db6a4a1
    Akanksha Mahajan 提交于
    Summary:
    The RocksDB iterator is a hierarchy of iterators. MergingIterator maintains a heap of LevelIterators, one for each L0 file and for each non-zero level. The Seek() operation naturally lends itself to parallelization, as it involves positioning every LevelIterator on the correct data block in the correct SST file. It lookups a level for a target key, to find the first key that's >= the target key. This typically involves reading one data block that is likely to contain the target key, and scan forward to find the first valid key. The forward scan may read more data blocks. In order to find the right data block, the iterator may read some metadata blocks (required for opening a file and searching the index).
    This flow can be parallelized.
    
    Design: Seek will be called two times under async_io option. First seek will send asynchronous request to prefetch the data blocks at each level and second seek will follow the normal flow and in FilePrefetchBuffer::TryReadFromCacheAsync it will wait for the Poll() to get the results and add the iterator to min_heap.
    - Status::TryAgain is passed down from FilePrefetchBuffer::PrefetchAsync to block_iter_.Status indicating asynchronous request has been submitted.
    - If for some reason asynchronous request returns error in submitting the request, it will fallback to sequential reading of blocks in one pass.
    - If the data already exists in prefetch_buffer, it will return the data without prefetching further and it will be treated as single pass of seek.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/9994
    
    Test Plan:
    - **Run Regressions.**
    ```
    ./db_bench -db=/tmp/prefix_scan_prefetch_main -benchmarks="fillseq" -key_size=32 -value_size=512 -num=5000000 -use_direct_io_for_flush_and_compaction=true -target_file_size_base=16777216
    ```
    i) Previous release 7.0 run for normal prefetching with async_io disabled:
    ```
    ./db_bench -use_existing_db=true -db=/tmp/prefix_scan_prefetch_main -benchmarks="seekrandom" -key_size=32 -value_size=512 -num=5000000 -use_direct_reads=true -seek_nexts=327680 -duration=120 -ops_between_duration_checks=1
    Initializing RocksDB Options from the specified file
    Initializing RocksDB Options from command-line flags
    RocksDB:    version 7.0
    Date:       Thu Mar 17 13:11:34 2022
    CPU:        24 * Intel Core Processor (Broadwell)
    CPUCache:   16384 KB
    Keys:       32 bytes each (+ 0 bytes user-defined timestamp)
    Values:     512 bytes each (256 bytes after compression)
    Entries:    5000000
    Prefix:    0 bytes
    Keys per prefix:    0
    RawSize:    2594.0 MB (estimated)
    FileSize:   1373.3 MB (estimated)
    Write rate: 0 bytes/second
    Read rate: 0 ops/second
    Compression: Snappy
    Compression sampling rate: 0
    Memtablerep: SkipListFactory
    Perf Level: 1
    ------------------------------------------------
    DB path: [/tmp/prefix_scan_prefetch_main]
    seekrandom   :  483618.390 micros/op 2 ops/sec;  338.9 MB/s (249 of 249 found)
    ```
    
    ii) normal prefetching after changes with async_io disable:
    ```
    ./db_bench -use_existing_db=true -db=/tmp/prefix_scan_prefetch_main -benchmarks="seekrandom" -key_size=32 -value_size=512 -num=5000000 -use_direct_reads=true -seek_nexts=327680 -duration=120 -ops_between_duration_checks=1
    Set seed to 1652922591315307 because --seed was 0
    Initializing RocksDB Options from the specified file
    Initializing RocksDB Options from command-line flags
    RocksDB:    version 7.3
    Date:       Wed May 18 18:09:51 2022
    CPU:        32 * Intel Xeon Processor (Skylake)
    CPUCache:   16384 KB
    Keys:       32 bytes each (+ 0 bytes user-defined timestamp)
    Values:     512 bytes each (256 bytes after compression)
    Entries:    5000000
    Prefix:    0 bytes
    Keys per prefix:    0
    RawSize:    2594.0 MB (estimated)
    FileSize:   1373.3 MB (estimated)
    Write rate: 0 bytes/second
    Read rate: 0 ops/second
    Compression: Snappy
    Compression sampling rate: 0
    Memtablerep: SkipListFactory
    Perf Level: 1
    ------------------------------------------------
    DB path: [/tmp/prefix_scan_prefetch_main]
    seekrandom   :  483080.466 micros/op 2 ops/sec 120.287 seconds 249 operations;  340.8 MB/s (249 of 249 found)
    ```
    iii) db_bench with async_io enabled completed succesfully
    
    ```
    ./db_bench -use_existing_db=true -db=/tmp/prefix_scan_prefetch_main -benchmarks="seekrandom" -key_size=32 -value_size=512 -num=5000000 -use_direct_reads=true -seek_nexts=327680 -duration=120 -ops_between_duration_checks=1 -async_io=1 -adaptive_readahead=1
    Set seed to 1652924062021732 because --seed was 0
    Initializing RocksDB Options from the specified file
    Initializing RocksDB Options from command-line flags
    RocksDB:    version 7.3
    Date:       Wed May 18 18:34:22 2022
    CPU:        32 * Intel Xeon Processor (Skylake)
    CPUCache:   16384 KB
    Keys:       32 bytes each (+ 0 bytes user-defined timestamp)
    Values:     512 bytes each (256 bytes after compression)
    Entries:    5000000
    Prefix:    0 bytes
    Keys per prefix:    0
    RawSize:    2594.0 MB (estimated)
    FileSize:   1373.3 MB (estimated)
    Write rate: 0 bytes/second
    Read rate: 0 ops/second
    Compression: Snappy
    Compression sampling rate: 0
    Memtablerep: SkipListFactory
    Perf Level: 1
    ------------------------------------------------
    DB path: [/tmp/prefix_scan_prefetch_main]
    seekrandom   :  553913.576 micros/op 1 ops/sec 120.199 seconds 217 operations;  293.6 MB/s (217 of 217 found)
    ```
    
    - db_stress with async_io disabled completed succesfully
    ```
     export CRASH_TEST_EXT_ARGS=" --async_io=0"
     make crash_test -j
    ```
    
    I**n Progress**: db_stress with async_io is failing and working on debugging/fixing it.
    
    Reviewed By: anand1976
    
    Differential Revision: D36459323
    
    Pulled By: akankshamahajan15
    
    fbshipit-source-id: abb1cd944abe712bae3986ae5b16704b3338917c
    2db6a4a1
perf_context.cc 24.3 KB