• H
    Remove deprecated API AdvancedColumnFamilyOptions::soft_rate_limit/hard_rate_limit (#9452) · 1e0e883c
    Hui Xiao 提交于
    Summary:
    **Context/Summary:**
    AdvancedColumnFamilyOptions::soft_rate_limit/hard_rate_limit have been marked as deprecated and it's time to actually remove the code.
    - Keep `soft_rate_limit`/`hard_rate_limit` in `cf_mutable_options_type_info` to prevent throwing `InvalidArgument` in `GetColumnFamilyOptionsFromMap` when reading an option file still with these options (e.g, old option file generated from RocksDB before the deprecation)
    - Keep `soft_rate_limit`/`hard_rate_limit` in under `OptionsOldApiTest.GetOptionsFromMapTest` to test the case mentioned above.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/9452
    
    Test Plan: Rely on my eyeball and CI
    
    Reviewed By: ajkr
    
    Differential Revision: D33804938
    
    Pulled By: hx235
    
    fbshipit-source-id: 133d49f7ec5238d7efceeb0a3122a5792a2b9945
    1e0e883c
c.cc 180.0 KB