• Z
    Rename DecodeCFAndKey to resolve naming conflict in unity test (#4323) · 1cf17ba5
    Zhongyi Xie 提交于
    Summary:
    Currently unity-test is failing because both trace_replay.cc and trace_analyzer_tool.cc defined `DecodeCFAndKey` under anonymous namespace. It is supposed to be fine except unity test will dump all source files together and now we have a conflict.
    Another issue with trace_analyzer_tool.cc is that it is using some utility functions from ldb_cmd which is not included in Makefile for unity_test, I chose to update TESTHARNESS to include LIBOBJECTS. Feel free to comment if there is a less intrusive way to solve this.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/4323
    
    Differential Revision: D9599170
    
    Pulled By: miasantreble
    
    fbshipit-source-id: 38765b11f8e7de92b43c63bdcf43ea914abdc029
    1cf17ba5
Makefile 65.6 KB