db_iter.cc 54.0 KB
Newer Older
1
//  Copyright (c) 2011-present, Facebook, Inc.  All rights reserved.
S
Siying Dong 已提交
2 3 4
//  This source code is licensed under both the GPLv2 (found in the
//  COPYING file in the root directory) and Apache 2.0 License
//  (found in the LICENSE.Apache file in the root directory).
5
//
J
jorlow@chromium.org 已提交
6 7 8 9 10
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. See the AUTHORS file for names of contributors.

#include "db/db_iter.h"
S
Stanislau Hlebik 已提交
11
#include <string>
12
#include <iostream>
S
Stanislau Hlebik 已提交
13
#include <limits>
J
jorlow@chromium.org 已提交
14 15

#include "db/dbformat.h"
16
#include "db/merge_context.h"
17
#include "db/merge_helper.h"
18
#include "db/pinned_iterators_manager.h"
19
#include "monitoring/perf_context_imp.h"
20 21 22
#include "rocksdb/env.h"
#include "rocksdb/iterator.h"
#include "rocksdb/merge_operator.h"
23
#include "rocksdb/options.h"
S
sdong 已提交
24
#include "table/internal_iterator.h"
25
#include "util/arena.h"
26
#include "util/filename.h"
J
jorlow@chromium.org 已提交
27 28
#include "util/logging.h"
#include "util/mutexlock.h"
29
#include "util/string_util.h"
30
#include "util/trace_replay.h"
J
jorlow@chromium.org 已提交
31

32
namespace rocksdb {
J
jorlow@chromium.org 已提交
33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51

#if 0
static void DumpInternalIter(Iterator* iter) {
  for (iter->SeekToFirst(); iter->Valid(); iter->Next()) {
    ParsedInternalKey k;
    if (!ParseInternalKey(iter->key(), &k)) {
      fprintf(stderr, "Corrupt '%s'\n", EscapeString(iter->key()).c_str());
    } else {
      fprintf(stderr, "@ '%s'\n", k.DebugString().c_str());
    }
  }
}
#endif

// Memtables and sstables that make the DB representation contain
// (userkey,seq,type) => uservalue entries.  DBIter
// combines multiple entries for the same userkey found in the DB
// representation into a single entry while accounting for sequence
// numbers, deletion markers, overwrites, etc.
S
Siying Dong 已提交
52
class DBIter final: public Iterator {
J
jorlow@chromium.org 已提交
53
 public:
54
  // The following is grossly complicated. TODO: clean it up
J
jorlow@chromium.org 已提交
55
  // Which direction is the iterator currently moving?
56 57 58 59 60 61 62
  // (1) When moving forward:
  //   (1a) if current_entry_is_merged_ = false, the internal iterator is
  //        positioned at the exact entry that yields this->key(), this->value()
  //   (1b) if current_entry_is_merged_ = true, the internal iterator is
  //        positioned immediately after the last entry that contributed to the
  //        current this->value(). That entry may or may not have key equal to
  //        this->key().
J
jorlow@chromium.org 已提交
63 64 65 66 67 68 69
  // (2) When moving backwards, the internal iterator is positioned
  //     just before all entries whose user key == this->key().
  enum Direction {
    kForward,
    kReverse
  };

70 71 72 73 74 75 76 77 78 79 80 81 82 83 84
  // LocalStatistics contain Statistics counters that will be aggregated per
  // each iterator instance and then will be sent to the global statistics when
  // the iterator is destroyed.
  //
  // The purpose of this approach is to avoid perf regression happening
  // when multiple threads bump the atomic counters from a DBIter::Next().
  struct LocalStatistics {
    explicit LocalStatistics() { ResetCounters(); }

    void ResetCounters() {
      next_count_ = 0;
      next_found_count_ = 0;
      prev_count_ = 0;
      prev_found_count_ = 0;
      bytes_read_ = 0;
85
      skip_count_ = 0;
86 87 88 89 90 91 92 93
    }

    void BumpGlobalStatistics(Statistics* global_statistics) {
      RecordTick(global_statistics, NUMBER_DB_NEXT, next_count_);
      RecordTick(global_statistics, NUMBER_DB_NEXT_FOUND, next_found_count_);
      RecordTick(global_statistics, NUMBER_DB_PREV, prev_count_);
      RecordTick(global_statistics, NUMBER_DB_PREV_FOUND, prev_found_count_);
      RecordTick(global_statistics, ITER_BYTES_READ, bytes_read_);
94
      RecordTick(global_statistics, NUMBER_ITER_SKIP, skip_count_);
95
      PERF_COUNTER_ADD(iter_read_bytes, bytes_read_);
96 97 98 99 100 101 102 103 104 105 106 107 108
      ResetCounters();
    }

    // Map to Tickers::NUMBER_DB_NEXT
    uint64_t next_count_;
    // Map to Tickers::NUMBER_DB_NEXT_FOUND
    uint64_t next_found_count_;
    // Map to Tickers::NUMBER_DB_PREV
    uint64_t prev_count_;
    // Map to Tickers::NUMBER_DB_PREV_FOUND
    uint64_t prev_found_count_;
    // Map to Tickers::ITER_BYTES_READ
    uint64_t bytes_read_;
109 110
    // Map to Tickers::NUMBER_ITER_SKIP
    uint64_t skip_count_;
111 112
  };

S
Siying Dong 已提交
113
  DBIter(Env* _env, const ReadOptions& read_options,
114 115
         const ImmutableCFOptions& cf_options,
         const MutableCFOptions& mutable_cf_options, const Comparator* cmp,
S
sdong 已提交
116
         InternalIterator* iter, SequenceNumber s, bool arena_mode,
Y
Yi Wu 已提交
117
         uint64_t max_sequential_skip_in_iterations,
118 119
         ReadCallback* read_callback, DBImpl* db_impl, ColumnFamilyData* cfd,
         bool allow_blob)
120
      : arena_mode_(arena_mode),
S
Siying Dong 已提交
121
        env_(_env),
122
        logger_(cf_options.info_log),
J
jorlow@chromium.org 已提交
123
        user_comparator_(cmp),
124
        merge_operator_(cf_options.merge_operator),
J
jorlow@chromium.org 已提交
125 126
        iter_(iter),
        sequence_(s),
J
jorlow@chromium.org 已提交
127
        direction_(kForward),
128
        valid_(false),
129
        current_entry_is_merged_(false),
130
        statistics_(cf_options.statistics),
131
        num_internal_keys_skipped_(0),
132
        iterate_lower_bound_(read_options.iterate_lower_bound),
133 134 135 136
        iterate_upper_bound_(read_options.iterate_upper_bound),
        prefix_same_as_start_(read_options.prefix_same_as_start),
        pin_thru_lifetime_(read_options.pin_data),
        total_order_seek_(read_options.total_order_seek),
137
        range_del_agg_(&cf_options.internal_comparator, s),
Y
Yi Wu 已提交
138
        read_callback_(read_callback),
139 140
        db_impl_(db_impl),
        cfd_(cfd),
141
        allow_blob_(allow_blob),
142 143
        is_blob_(false),
        start_seqnum_(read_options.iter_start_seqnum) {
144
    RecordTick(statistics_, NO_ITERATOR_CREATED);
145
    prefix_extractor_ = mutable_cf_options.prefix_extractor.get();
146
    max_skip_ = max_sequential_skip_in_iterations;
147
    max_skippable_internal_keys_ = read_options.max_skippable_internal_keys;
148 149 150 151 152 153
    if (pin_thru_lifetime_) {
      pinned_iters_mgr_.StartPinning();
    }
    if (iter_) {
      iter_->SetPinnedItersMgr(&pinned_iters_mgr_);
    }
J
jorlow@chromium.org 已提交
154
  }
155
  ~DBIter() override {
156
    // Release pinned data if any
157 158 159
    if (pinned_iters_mgr_.PinningEnabled()) {
      pinned_iters_mgr_.ReleasePinnedData();
    }
160
    RecordTick(statistics_, NO_ITERATOR_DELETED);
161
    ResetInternalKeysSkippedCounter();
162
    local_stats_.BumpGlobalStatistics(statistics_);
163 164 165
    if (!arena_mode_) {
      delete iter_;
    } else {
S
sdong 已提交
166
      iter_->~InternalIterator();
167 168
    }
  }
S
sdong 已提交
169
  virtual void SetIter(InternalIterator* iter) {
170 171
    assert(iter_ == nullptr);
    iter_ = iter;
172
    iter_->SetPinnedItersMgr(&pinned_iters_mgr_);
J
jorlow@chromium.org 已提交
173
  }
174
  virtual ReadRangeDelAggregator* GetRangeDelAggregator() {
A
Andrew Kryczka 已提交
175 176 177
    return &range_del_agg_;
  }

178 179
  bool Valid() const override { return valid_; }
  Slice key() const override {
J
jorlow@chromium.org 已提交
180
    assert(valid_);
181 182 183 184 185
    if(start_seqnum_ > 0) {
      return saved_key_.GetInternalKey();
    } else {
      return saved_key_.GetUserKey();
    }
J
jorlow@chromium.org 已提交
186
  }
187
  Slice value() const override {
J
jorlow@chromium.org 已提交
188
    assert(valid_);
189
    if (current_entry_is_merged_) {
190 191 192
      // If pinned_value_ is set then the result of merge operator is one of
      // the merge operands and we should return it.
      return pinned_value_.data() ? pinned_value_ : saved_value_;
193 194 195 196 197
    } else if (direction_ == kReverse) {
      return pinned_value_;
    } else {
      return iter_->value();
    }
J
jorlow@chromium.org 已提交
198
  }
199
  Status status() const override {
J
jorlow@chromium.org 已提交
200 201 202
    if (status_.ok()) {
      return iter_->status();
    } else {
203
      assert(!valid_);
J
jorlow@chromium.org 已提交
204 205 206
      return status_;
    }
  }
Y
Yi Wu 已提交
207 208 209 210
  bool IsBlob() const {
    assert(valid_ && (allow_blob_ || !is_blob_));
    return is_blob_;
  }
211

212
  Status GetProperty(std::string prop_name, std::string* prop) override {
213 214 215
    if (prop == nullptr) {
      return Status::InvalidArgument("prop is nullptr");
    }
216
    if (prop_name == "rocksdb.iterator.super-version-number") {
217
      // First try to pass the value returned from inner iterator.
S
Siying Dong 已提交
218
      return iter_->GetProperty(prop_name, prop);
219
    } else if (prop_name == "rocksdb.iterator.is-key-pinned") {
220
      if (valid_) {
221
        *prop = (pin_thru_lifetime_ && saved_key_.IsKeyPinned()) ? "1" : "0";
222 223 224 225
      } else {
        *prop = "Iterator is not valid.";
      }
      return Status::OK();
226 227 228
    } else if (prop_name == "rocksdb.iterator.internal-key") {
      *prop = saved_key_.GetUserKey().ToString();
      return Status::OK();
229
    }
230
    return Status::InvalidArgument("Unidentified property.");
231
  }
J
jorlow@chromium.org 已提交
232

233 234 235 236 237 238
  void Next() override;
  void Prev() override;
  void Seek(const Slice& target) override;
  void SeekForPrev(const Slice& target) override;
  void SeekToFirst() override;
  void SeekToLast() override;
S
Siying Dong 已提交
239 240 241
  Env* env() { return env_; }
  void set_sequence(uint64_t s) { sequence_ = s; }
  void set_valid(bool v) { valid_ = v; }
J
jorlow@chromium.org 已提交
242

J
jorlow@chromium.org 已提交
243
 private:
244 245 246 247 248 249
  // For all methods in this block:
  // PRE: iter_->Valid() && status_.ok()
  // Return false if there was an error, and status() is non-ok, valid_ = false;
  // in this case callers would usually stop what they were doing and return.
  bool ReverseToForward();
  bool ReverseToBackward();
S
Stanislau Hlebik 已提交
250 251
  bool FindValueForCurrentKey();
  bool FindValueForCurrentKeyUsingSeek();
252 253 254
  bool FindUserKeyBeforeSavedKey();
  inline bool FindNextUserEntry(bool skipping, bool prefix_check);
  bool FindNextUserEntryInternal(bool skipping, bool prefix_check);
J
jorlow@chromium.org 已提交
255
  bool ParseKey(ParsedInternalKey* key);
256 257 258
  bool MergeValuesNewToOld();

  void PrevInternal();
259
  bool TooManyInternalKeysSkipped(bool increment = true);
Y
Yi Wu 已提交
260
  bool IsVisible(SequenceNumber sequence);
J
jorlow@chromium.org 已提交
261

262 263 264 265 266 267 268 269 270 271 272 273
  // CanReseekToSkip() returns whether the iterator can use the optimization
  // where it reseek by sequence number to get the next key when there are too
  // many versions. This is disabled for write unprepared because seeking to
  // sequence number does not guarantee that it is visible.
  inline bool CanReseekToSkip();

  // MaxVisibleSequenceNumber() returns the maximum visible sequence number
  // for this snapshot. This sequence number may be greater than snapshot
  // seqno because uncommitted data written to DB for write unprepared will
  // have a higher sequence number.
  inline SequenceNumber MaxVisibleSequenceNumber();

274 275 276 277 278 279 280 281 282 283
  // Temporarily pin the blocks that we encounter until ReleaseTempPinnedData()
  // is called
  void TempPinData() {
    if (!pin_thru_lifetime_) {
      pinned_iters_mgr_.StartPinning();
    }
  }

  // Release blocks pinned by TempPinData()
  void ReleaseTempPinnedData() {
284 285
    if (!pin_thru_lifetime_ && pinned_iters_mgr_.PinningEnabled()) {
      pinned_iters_mgr_.ReleasePinnedData();
286 287 288
    }
  }

J
jorlow@chromium.org 已提交
289 290 291 292 293 294 295 296 297
  inline void ClearSavedValue() {
    if (saved_value_.capacity() > 1048576) {
      std::string empty;
      swap(empty, saved_value_);
    } else {
      saved_value_.clear();
    }
  }

298
  inline void ResetInternalKeysSkippedCounter() {
299 300 301 302
    local_stats_.skip_count_ += num_internal_keys_skipped_;
    if (valid_) {
      local_stats_.skip_count_--;
    }
303 304 305
    num_internal_keys_skipped_ = 0;
  }

306
  const SliceTransform* prefix_extractor_;
307
  bool arena_mode_;
J
jorlow@chromium.org 已提交
308
  Env* const env_;
I
Igor Canadi 已提交
309
  Logger* logger_;
J
jorlow@chromium.org 已提交
310
  const Comparator* const user_comparator_;
311
  const MergeOperator* const merge_operator_;
S
sdong 已提交
312
  InternalIterator* iter_;
S
Siying Dong 已提交
313
  SequenceNumber sequence_;
J
jorlow@chromium.org 已提交
314

J
jorlow@chromium.org 已提交
315
  Status status_;
S
Stanislau Hlebik 已提交
316
  IterKey saved_key_;
317 318 319 320
  // Reusable internal key data structure. This is only used inside one function
  // and should not be used across functions. Reusing this object can reduce
  // overhead of calling construction of the function if creating it each time.
  ParsedInternalKey ikey_;
S
Stanislau Hlebik 已提交
321
  std::string saved_value_;
322
  Slice pinned_value_;
J
jorlow@chromium.org 已提交
323
  Direction direction_;
J
jorlow@chromium.org 已提交
324
  bool valid_;
325
  bool current_entry_is_merged_;
326
  // for prefix seek mode to support prev()
327
  Statistics* statistics_;
328
  uint64_t max_skip_;
329 330
  uint64_t max_skippable_internal_keys_;
  uint64_t num_internal_keys_skipped_;
331
  const Slice* iterate_lower_bound_;
332
  const Slice* iterate_upper_bound_;
333 334 335
  IterKey prefix_start_buf_;
  Slice prefix_start_key_;
  const bool prefix_same_as_start_;
336 337 338
  // Means that we will pin all data blocks we read as long the Iterator
  // is not deleted, will be true if ReadOptions::pin_data is true
  const bool pin_thru_lifetime_;
339
  const bool total_order_seek_;
340
  // List of operands for merge operator.
341
  MergeContext merge_context_;
342
  ReadRangeDelAggregator range_del_agg_;
343
  LocalStatistics local_stats_;
344
  PinnedIteratorsManager pinned_iters_mgr_;
Y
Yi Wu 已提交
345
  ReadCallback* read_callback_;
346 347
  DBImpl* db_impl_;
  ColumnFamilyData* cfd_;
Y
Yi Wu 已提交
348 349
  bool allow_blob_;
  bool is_blob_;
350 351 352
  // for diff snapshots we want the lower bound on the seqnum;
  // if this value > 0 iterator will return internal keys
  SequenceNumber start_seqnum_;
J
jorlow@chromium.org 已提交
353 354 355 356 357 358 359 360 361

  // No copying allowed
  DBIter(const DBIter&);
  void operator=(const DBIter&);
};

inline bool DBIter::ParseKey(ParsedInternalKey* ikey) {
  if (!ParseInternalKey(iter_->key(), ikey)) {
    status_ = Status::Corruption("corrupted internal key in DBIter");
362
    valid_ = false;
363 364
    ROCKS_LOG_ERROR(logger_, "corrupted internal key in DBIter: %s",
                    iter_->key().ToString(true).c_str());
J
jorlow@chromium.org 已提交
365 366 367 368 369 370
    return false;
  } else {
    return true;
  }
}

J
jorlow@chromium.org 已提交
371 372
void DBIter::Next() {
  assert(valid_);
373
  assert(status_.ok());
J
jorlow@chromium.org 已提交
374

375 376
  // Release temporarily pinned blocks from last operation
  ReleaseTempPinnedData();
377
  ResetInternalKeysSkippedCounter();
378
  bool ok = true;
S
Stanislau Hlebik 已提交
379
  if (direction_ == kReverse) {
380 381 382
    if (!ReverseToForward()) {
      ok = false;
    }
383 384 385 386 387 388 389
  } else if (iter_->Valid() && !current_entry_is_merged_) {
    // If the current value is not a merge, the iter position is the
    // current key, which is already returned. We can safely issue a
    // Next() without checking the current key.
    // If the current key is a merge, very likely iter already points
    // to the next internal position.
    iter_->Next();
390
    PERF_COUNTER_ADD(internal_key_skipped_count, 1);
J
jorlow@chromium.org 已提交
391
  }
J
jorlow@chromium.org 已提交
392

393 394 395
  if (statistics_ != nullptr) {
    local_stats_.next_count_++;
  }
396 397 398 399
  if (ok && iter_->Valid()) {
    FindNextUserEntry(true /* skipping the current user key */,
                      prefix_same_as_start_);
  } else {
400 401
    valid_ = false;
  }
402 403 404 405
  if (statistics_ != nullptr && valid_) {
    local_stats_.next_found_count_++;
    local_stats_.bytes_read_ += (key().size() + value().size());
  }
J
jorlow@chromium.org 已提交
406 407
}

408 409 410 411 412 413 414
// PRE: saved_key_ has the current user key if skipping
// POST: saved_key_ should have the next user key if valid_,
//       if the current entry is a result of merge
//           current_entry_is_merged_ => true
//           saved_value_             => the merged value
//
// NOTE: In between, saved_key_ can point to a user key that has
415
//       a delete marker or a sequence number higher than sequence_
416
//       saved_key_ MUST have a proper user_key before calling this function
417 418 419 420 421
//
// The prefix_check parameter controls whether we check the iterated
// keys against the prefix of the seeked key. Set to false when
// performing a seek without a key (e.g. SeekToFirst). Set to
// prefix_same_as_start_ for other iterations.
422
inline bool DBIter::FindNextUserEntry(bool skipping, bool prefix_check) {
423
  PERF_TIMER_GUARD(find_next_user_entry_time);
424
  return FindNextUserEntryInternal(skipping, prefix_check);
425 426 427
}

// Actual implementation of DBIter::FindNextUserEntry()
428
bool DBIter::FindNextUserEntryInternal(bool skipping, bool prefix_check) {
J
jorlow@chromium.org 已提交
429 430
  // Loop until we hit an acceptable entry to yield
  assert(iter_->Valid());
431
  assert(status_.ok());
J
jorlow@chromium.org 已提交
432
  assert(direction_ == kForward);
433
  current_entry_is_merged_ = false;
434 435 436 437 438 439 440 441 442 443 444

  // How many times in a row we have skipped an entry with user key less than
  // or equal to saved_key_. We could skip these entries either because
  // sequence numbers were too high or because skipping = true.
  // What saved_key_ contains throughout this method:
  //  - if skipping        : saved_key_ contains the key that we need to skip,
  //                         and we haven't seen any keys greater than that,
  //  - if num_skipped > 0 : saved_key_ contains the key that we have skipped
  //                         num_skipped times, and we haven't seen any keys
  //                         greater than that,
  //  - none of the above  : saved_key_ can contain anything, it doesn't matter.
445
  uint64_t num_skipped = 0;
446

Y
Yi Wu 已提交
447 448
  is_blob_ = false;

J
jorlow@chromium.org 已提交
449
  do {
450
    if (!ParseKey(&ikey_)) {
451
      return false;
452
    }
453

454
    if (iterate_upper_bound_ != nullptr &&
455
        user_comparator_->Compare(ikey_.user_key, *iterate_upper_bound_) >= 0) {
456 457
      break;
    }
458

459
    if (prefix_extractor_ && prefix_check &&
460 461
        prefix_extractor_->Transform(ikey_.user_key)
                .compare(prefix_start_key_) != 0) {
462 463 464
      break;
    }

465
    if (TooManyInternalKeysSkipped()) {
466
      return false;
467 468
    }

Y
Yi Wu 已提交
469
    if (IsVisible(ikey_.sequence)) {
470 471
      if (skipping && user_comparator_->Compare(ikey_.user_key,
                                                saved_key_.GetUserKey()) <= 0) {
472 473 474 475
        num_skipped++;  // skip this entry
        PERF_COUNTER_ADD(internal_key_skipped_count, 1);
      } else {
        num_skipped = 0;
476
        switch (ikey_.type) {
477 478 479 480
          case kTypeDeletion:
          case kTypeSingleDeletion:
            // Arrange to skip all upcoming entries for this key since
            // they are hidden by this deletion.
481 482 483
            // if iterartor specified start_seqnum we
            // 1) return internal key, including the type
            // 2) return ikey only if ikey.seqnum >= start_seqnum_
484
            // note that if deletion seqnum is < start_seqnum_ we
485 486 487
            // just skip it like in normal iterator.
            if (start_seqnum_ > 0 && ikey_.sequence >= start_seqnum_)  {
              saved_key_.SetInternalKey(ikey_);
488 489
              valid_ = true;
              return true;
490 491
            } else {
              saved_key_.SetUserKey(
492 493
                ikey_.user_key,
                !pin_thru_lifetime_ || !iter_->IsKeyPinned() /* copy */);
494 495
              skipping = true;
              PERF_COUNTER_ADD(internal_delete_skipped_count, 1);
496
            }
497 498
            break;
          case kTypeValue:
Y
Yi Wu 已提交
499
          case kTypeBlobIndex:
500 501 502 503 504 505 506 507
            if (start_seqnum_ > 0) {
              // we are taking incremental snapshot here
              // incremental snapshots aren't supported on DB with range deletes
              assert(!(
                (ikey_.type == kTypeBlobIndex) && (start_seqnum_ > 0)
              ));
              if (ikey_.sequence >= start_seqnum_) {
                saved_key_.SetInternalKey(ikey_);
Y
Yi Wu 已提交
508
                valid_ = true;
509
                return true;
510 511 512 513 514 515
              } else {
                // this key and all previous versions shouldn't be included,
                // skipping
                saved_key_.SetUserKey(ikey_.user_key,
                  !pin_thru_lifetime_ || !iter_->IsKeyPinned() /* copy */);
                skipping = true;
Y
Yi Wu 已提交
516
              }
517
            } else {
518 519 520 521
              saved_key_.SetUserKey(
                  ikey_.user_key,
                  !pin_thru_lifetime_ || !iter_->IsKeyPinned() /* copy */);
              if (range_del_agg_.ShouldDelete(
522
                      ikey_, RangeDelPositioningMode::kForwardTraversal)) {
523 524 525 526 527 528 529 530 531 532 533 534
                // Arrange to skip all upcoming entries for this key since
                // they are hidden by this deletion.
                skipping = true;
                num_skipped = 0;
                PERF_COUNTER_ADD(internal_delete_skipped_count, 1);
              } else if (ikey_.type == kTypeBlobIndex) {
                if (!allow_blob_) {
                  ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index.");
                  status_ = Status::NotSupported(
                      "Encounter unexpected blob index. Please open DB with "
                      "rocksdb::blob_db::BlobDB instead.");
                  valid_ = false;
535
                  return false;
536
                }
537 538 539 540

                is_blob_ = true;
                valid_ = true;
                return true;
541 542
              } else {
                valid_ = true;
543
                return true;
544
              }
545 546 547
            }
            break;
          case kTypeMerge:
548
            saved_key_.SetUserKey(
549 550
                ikey_.user_key,
                !pin_thru_lifetime_ || !iter_->IsKeyPinned() /* copy */);
551
            if (range_del_agg_.ShouldDelete(
552
                    ikey_, RangeDelPositioningMode::kForwardTraversal)) {
553 554 555 556 557 558 559 560 561 562
              // Arrange to skip all upcoming entries for this key since
              // they are hidden by this deletion.
              skipping = true;
              num_skipped = 0;
              PERF_COUNTER_ADD(internal_delete_skipped_count, 1);
            } else {
              // By now, we are sure the current ikey is going to yield a
              // value
              current_entry_is_merged_ = true;
              valid_ = true;
563
              return MergeValuesNewToOld();  // Go to a different state machine
564 565 566 567 568
            }
            break;
          default:
            assert(false);
            break;
569
        }
J
jorlow@chromium.org 已提交
570
      }
571 572 573
    } else {
      PERF_COUNTER_ADD(internal_recent_skipped_count, 1);

574 575 576 577 578 579
      // This key was inserted after our snapshot was taken.
      // If this happens too many times in a row for the same user key, we want
      // to seek to the target sequence number.
      int cmp =
          user_comparator_->Compare(ikey_.user_key, saved_key_.GetUserKey());
      if (cmp == 0 || (skipping && cmp <= 0)) {
580 581
        num_skipped++;
      } else {
582
        saved_key_.SetUserKey(
583
            ikey_.user_key,
584
            !iter_->IsKeyPinned() || !pin_thru_lifetime_ /* copy */);
585 586 587
        skipping = false;
        num_skipped = 0;
      }
J
jorlow@chromium.org 已提交
588
    }
589 590 591

    // If we have sequentially iterated via numerous equal keys, then it's
    // better to seek so that we can avoid too many key comparisons.
592
    if (num_skipped > max_skip_ && CanReseekToSkip()) {
593 594
      num_skipped = 0;
      std::string last_key;
595 596 597 598
      if (skipping) {
        // We're looking for the next user-key but all we see are the same
        // user-key with decreasing sequence numbers. Fast forward to
        // sequence number 0 and type deletion (the smallest type).
599 600
        AppendInternalKey(&last_key, ParsedInternalKey(saved_key_.GetUserKey(),
                                                       0, kTypeDeletion));
601 602 603 604 605 606 607 608 609
        // Don't set skipping = false because we may still see more user-keys
        // equal to saved_key_.
      } else {
        // We saw multiple entries with this user key and sequence numbers
        // higher than sequence_. Fast forward to sequence_.
        // Note that this only covers a case when a higher key was overwritten
        // many times since our snapshot was taken, not the case when a lot of
        // different keys were inserted after our snapshot was taken.
        AppendInternalKey(&last_key,
610
                          ParsedInternalKey(saved_key_.GetUserKey(), sequence_,
611 612
                                            kValueTypeForSeek));
      }
613 614 615 616 617
      iter_->Seek(last_key);
      RecordTick(statistics_, NUMBER_OF_RESEEKS_IN_ITERATION);
    } else {
      iter_->Next();
    }
J
jorlow@chromium.org 已提交
618
  } while (iter_->Valid());
619

J
jorlow@chromium.org 已提交
620
  valid_ = false;
621
  return iter_->status().ok();
J
jorlow@chromium.org 已提交
622 623
}

624 625 626 627 628 629
// Merge values of the same user key starting from the current iter_ position
// Scan from the newer entries to older entries.
// PRE: iter_->key() points to the first merge type entry
//      saved_key_ stores the user key
// POST: saved_value_ has the merged value for the user key
//       iter_ points to the next entry (or invalid)
630
bool DBIter::MergeValuesNewToOld() {
631
  if (!merge_operator_) {
632
    ROCKS_LOG_ERROR(logger_, "Options::merge_operator is null.");
633
    status_ = Status::InvalidArgument("merge_operator_ must be set.");
634
    valid_ = false;
635
    return false;
D
Deon Nicholas 已提交
636
  }
637

638 639
  // Temporarily pin the blocks that hold merge operands
  TempPinData();
640
  merge_context_.Clear();
641
  // Start the merge process by pushing the first operand
642 643
  merge_context_.PushOperand(iter_->value(),
                             iter_->IsValuePinned() /* operand_pinned */);
644
  TEST_SYNC_POINT("DBIter::MergeValuesNewToOld:PushedFirstOperand");
645 646

  ParsedInternalKey ikey;
647
  Status s;
648
  for (iter_->Next(); iter_->Valid(); iter_->Next()) {
649
    TEST_SYNC_POINT("DBIter::MergeValuesNewToOld:SteppedToNextOperand");
650
    if (!ParseKey(&ikey)) {
651
      return false;
652 653
    }

654
    if (!user_comparator_->Equal(ikey.user_key, saved_key_.GetUserKey())) {
655 656
      // hit the next user key, stop right here
      break;
A
Andrew Kryczka 已提交
657
    } else if (kTypeDeletion == ikey.type || kTypeSingleDeletion == ikey.type ||
658
               range_del_agg_.ShouldDelete(
659
                   ikey, RangeDelPositioningMode::kForwardTraversal)) {
660 661 662 663
      // hit a delete with the same user key, stop right here
      // iter_ is positioned after delete
      iter_->Next();
      break;
A
Andres Noetzli 已提交
664
    } else if (kTypeValue == ikey.type) {
665 666
      // hit a put, merge the put value with operands and store the
      // final result in saved_value_. We are done!
I
Igor Canadi 已提交
667
      const Slice val = iter_->value();
668 669
      s = MergeHelper::TimedFullMerge(
          merge_operator_, ikey.user_key, &val, merge_context_.GetOperands(),
670
          &saved_value_, logger_, statistics_, env_, &pinned_value_, true);
671
      if (!s.ok()) {
Y
Yi Wu 已提交
672
        valid_ = false;
673
        status_ = s;
674
        return false;
675
      }
676 677
      // iter_ is positioned after put
      iter_->Next();
678 679 680 681 682
      if (!iter_->status().ok()) {
        valid_ = false;
        return false;
      }
      return true;
A
Andres Noetzli 已提交
683
    } else if (kTypeMerge == ikey.type) {
684 685
      // hit a merge, add the value as an operand and run associative merge.
      // when complete, add result to operands and continue.
686 687
      merge_context_.PushOperand(iter_->value(),
                                 iter_->IsValuePinned() /* operand_pinned */);
688
      PERF_COUNTER_ADD(internal_merge_count, 1);
Y
Yi Wu 已提交
689 690 691 692 693 694 695 696 697 698 699
    } else if (kTypeBlobIndex == ikey.type) {
      if (!allow_blob_) {
        ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index.");
        status_ = Status::NotSupported(
            "Encounter unexpected blob index. Please open DB with "
            "rocksdb::blob_db::BlobDB instead.");
      } else {
        status_ =
            Status::NotSupported("Blob DB does not support merge operator.");
      }
      valid_ = false;
700
      return false;
A
Andres Noetzli 已提交
701 702
    } else {
      assert(false);
703 704 705
    }
  }

706 707 708 709 710
  if (!iter_->status().ok()) {
    valid_ = false;
    return false;
  }

711 712 713 714
  // we either exhausted all internal keys under this user key, or hit
  // a deletion marker.
  // feed null as the existing value to the merge operator, such that
  // client can differentiate this scenario and do things accordingly.
715 716 717
  s = MergeHelper::TimedFullMerge(merge_operator_, saved_key_.GetUserKey(),
                                  nullptr, merge_context_.GetOperands(),
                                  &saved_value_, logger_, statistics_, env_,
718
                                  &pinned_value_, true);
719
  if (!s.ok()) {
Y
Yi Wu 已提交
720
    valid_ = false;
721
    status_ = s;
722
    return false;
723
  }
724 725 726

  assert(status_.ok());
  return true;
727 728
}

J
jorlow@chromium.org 已提交
729 730
void DBIter::Prev() {
  assert(valid_);
731
  assert(status_.ok());
732
  ReleaseTempPinnedData();
733
  ResetInternalKeysSkippedCounter();
734
  bool ok = true;
S
Stanislau Hlebik 已提交
735
  if (direction_ == kForward) {
736 737 738 739 740 741
    if (!ReverseToBackward()) {
      ok = false;
    }
  }
  if (ok) {
    PrevInternal();
S
Stanislau Hlebik 已提交
742
  }
M
Manuel Ung 已提交
743
  if (statistics_ != nullptr) {
744
    local_stats_.prev_count_++;
M
Manuel Ung 已提交
745
    if (valid_) {
746 747
      local_stats_.prev_found_count_++;
      local_stats_.bytes_read_ += (key().size() + value().size());
M
Manuel Ung 已提交
748 749
    }
  }
S
Stanislau Hlebik 已提交
750
}
J
jorlow@chromium.org 已提交
751

752 753 754 755 756 757 758
bool DBIter::ReverseToForward() {
  assert(iter_->status().ok());

  // When moving backwards, iter_ is positioned on _previous_ key, which may
  // not exist or may have different prefix than the current key().
  // If that's the case, seek iter_ to current key.
  if ((prefix_extractor_ != nullptr && !total_order_seek_) || !iter_->Valid()) {
759 760
    IterKey last_key;
    last_key.SetInternalKey(ParsedInternalKey(
761 762
        saved_key_.GetUserKey(), kMaxSequenceNumber, kValueTypeForSeek));
    iter_->Seek(last_key.GetInternalKey());
763
  }
764

765
  direction_ = kForward;
766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781
  // Skip keys less than the current key() (a.k.a. saved_key_).
  while (iter_->Valid()) {
    ParsedInternalKey ikey;
    if (!ParseKey(&ikey)) {
      return false;
    }
    if (user_comparator_->Compare(ikey.user_key, saved_key_.GetUserKey()) >=
        0) {
      return true;
    }
    iter_->Next();
  }

  if (!iter_->status().ok()) {
    valid_ = false;
    return false;
782
  }
783 784

  return true;
785 786
}

787 788 789 790 791 792 793 794 795 796
// Move iter_ to the key before saved_key_.
bool DBIter::ReverseToBackward() {
  assert(iter_->status().ok());

  // When current_entry_is_merged_ is true, iter_ may be positioned on the next
  // key, which may not exist or may have prefix different from current.
  // If that's the case, seek to saved_key_.
  if (current_entry_is_merged_ &&
      ((prefix_extractor_ != nullptr && !total_order_seek_) ||
       !iter_->Valid())) {
797
    IterKey last_key;
798 799 800 801 802 803 804 805 806 807 808 809 810 811 812
    // Using kMaxSequenceNumber and kValueTypeForSeek
    // (not kValueTypeForSeekForPrev) to seek to a key strictly smaller
    // than saved_key_.
    last_key.SetInternalKey(ParsedInternalKey(
        saved_key_.GetUserKey(), kMaxSequenceNumber, kValueTypeForSeek));
    if (prefix_extractor_ != nullptr && !total_order_seek_) {
      iter_->SeekForPrev(last_key.GetInternalKey());
    } else {
      // Some iterators may not support SeekForPrev(), so we avoid using it
      // when prefix seek mode is disabled. This is somewhat expensive
      // (an extra Prev(), as well as an extra change of direction of iter_),
      // so we may need to reconsider it later.
      iter_->Seek(last_key.GetInternalKey());
      if (!iter_->Valid() && iter_->status().ok()) {
        iter_->SeekToLast();
813
      }
814 815 816 817
    }
  }

  direction_ = kReverse;
818
  return FindUserKeyBeforeSavedKey();
819 820
}

S
Stanislau Hlebik 已提交
821 822
void DBIter::PrevInternal() {
  while (iter_->Valid()) {
823 824 825
    saved_key_.SetUserKey(
        ExtractUserKey(iter_->key()),
        !iter_->IsKeyPinned() || !pin_thru_lifetime_ /* copy */);
826

827 828 829 830 831 832 833 834
    if (prefix_extractor_ && prefix_same_as_start_ &&
        prefix_extractor_->Transform(saved_key_.GetUserKey())
                .compare(prefix_start_key_) != 0) {
      // Current key does not have the same prefix as start
      valid_ = false;
      return;
    }

835 836 837 838 839 840 841 842
    if (iterate_lower_bound_ != nullptr &&
        user_comparator_->Compare(saved_key_.GetUserKey(),
                                  *iterate_lower_bound_) < 0) {
      // We've iterated earlier than the user-specified lower bound.
      valid_ = false;
      return;
    }

843
    if (!FindValueForCurrentKey()) {  // assigns valid_
S
Stanislau Hlebik 已提交
844
      return;
J
jorlow@chromium.org 已提交
845
    }
846

847 848 849
    // Whether or not we found a value for current key, we need iter_ to end up
    // on a smaller key.
    if (!FindUserKeyBeforeSavedKey()) {
850 851 852
      return;
    }

853 854 855
    if (valid_) {
      // Found the value.
      return;
S
Stanislau Hlebik 已提交
856
    }
857 858 859

    if (TooManyInternalKeysSkipped(false)) {
      return;
S
Stanislau Hlebik 已提交
860 861
    }
  }
862

S
Stanislau Hlebik 已提交
863 864
  // We haven't found any key - iterator is not valid
  valid_ = false;
J
jorlow@chromium.org 已提交
865 866
}

867 868 869 870 871 872 873 874 875 876 877
// Used for backwards iteration.
// Looks at the entries with user key saved_key_ and finds the most up-to-date
// value for it, or executes a merge, or determines that the value was deleted.
// Sets valid_ to true if the value is found and is ready to be presented to
// the user through value().
// Sets valid_ to false if the value was deleted, and we should try another key.
// Returns false if an error occurred, and !status().ok() and !valid_.
//
// PRE: iter_ is positioned on the last entry with user key equal to saved_key_.
// POST: iter_ is positioned on one of the entries equal to saved_key_, or on
//       the entry just before them, or on the entry just after them.
S
Stanislau Hlebik 已提交
878 879
bool DBIter::FindValueForCurrentKey() {
  assert(iter_->Valid());
880
  merge_context_.Clear();
881
  current_entry_is_merged_ = false;
A
Andres Noetzli 已提交
882 883
  // last entry before merge (could be kTypeDeletion, kTypeSingleDeletion or
  // kTypeValue)
S
Stanislau Hlebik 已提交
884 885
  ValueType last_not_merge_type = kTypeDeletion;
  ValueType last_key_entry_type = kTypeDeletion;
J
jorlow@chromium.org 已提交
886

887 888 889
  // Temporarily pin blocks that hold (merge operands / the value)
  ReleaseTempPinnedData();
  TempPinData();
S
Stanislau Hlebik 已提交
890
  size_t num_skipped = 0;
891 892 893 894 895 896 897 898 899 900
  while (iter_->Valid()) {
    ParsedInternalKey ikey;
    if (!ParseKey(&ikey)) {
      return false;
    }

    if (!IsVisible(ikey.sequence) ||
        !user_comparator_->Equal(ikey.user_key, saved_key_.GetUserKey())) {
      break;
    }
901 902 903 904
    if (TooManyInternalKeysSkipped()) {
      return false;
    }

905 906 907
    // This user key has lots of entries.
    // We're going from old to new, and it's taking too long. Let's do a Seek()
    // and go from new to old. This helps when a key was overwritten many times.
908
    if (num_skipped >= max_skip_ && CanReseekToSkip()) {
S
Stanislau Hlebik 已提交
909 910 911 912 913 914
      return FindValueForCurrentKeyUsingSeek();
    }

    last_key_entry_type = ikey.type;
    switch (last_key_entry_type) {
      case kTypeValue:
Y
Yi Wu 已提交
915
      case kTypeBlobIndex:
916
        if (range_del_agg_.ShouldDelete(
917
                ikey, RangeDelPositioningMode::kBackwardTraversal)) {
A
Andrew Kryczka 已提交
918 919 920 921 922 923
          last_key_entry_type = kTypeRangeDeletion;
          PERF_COUNTER_ADD(internal_delete_skipped_count, 1);
        } else {
          assert(iter_->IsValuePinned());
          pinned_value_ = iter_->value();
        }
924
        merge_context_.Clear();
A
Andrew Kryczka 已提交
925
        last_not_merge_type = last_key_entry_type;
S
Stanislau Hlebik 已提交
926 927
        break;
      case kTypeDeletion:
A
Andres Noetzli 已提交
928
      case kTypeSingleDeletion:
929
        merge_context_.Clear();
A
Andres Noetzli 已提交
930
        last_not_merge_type = last_key_entry_type;
931
        PERF_COUNTER_ADD(internal_delete_skipped_count, 1);
S
Stanislau Hlebik 已提交
932 933
        break;
      case kTypeMerge:
934
        if (range_del_agg_.ShouldDelete(
935
                ikey, RangeDelPositioningMode::kBackwardTraversal)) {
A
Andrew Kryczka 已提交
936 937 938 939 940 941 942 943
          merge_context_.Clear();
          last_key_entry_type = kTypeRangeDeletion;
          last_not_merge_type = last_key_entry_type;
          PERF_COUNTER_ADD(internal_delete_skipped_count, 1);
        } else {
          assert(merge_operator_ != nullptr);
          merge_context_.PushOperandBack(
              iter_->value(), iter_->IsValuePinned() /* operand_pinned */);
944
          PERF_COUNTER_ADD(internal_merge_count, 1);
A
Andrew Kryczka 已提交
945
        }
S
Stanislau Hlebik 已提交
946 947 948 949 950
        break;
      default:
        assert(false);
    }

951
    PERF_COUNTER_ADD(internal_key_skipped_count, 1);
S
Stanislau Hlebik 已提交
952 953
    iter_->Prev();
    ++num_skipped;
954 955 956 957 958
  }

  if (!iter_->status().ok()) {
    valid_ = false;
    return false;
S
Stanislau Hlebik 已提交
959 960
  }

961
  Status s;
Y
Yi Wu 已提交
962
  is_blob_ = false;
S
Stanislau Hlebik 已提交
963 964
  switch (last_key_entry_type) {
    case kTypeDeletion:
A
Andres Noetzli 已提交
965
    case kTypeSingleDeletion:
A
Andrew Kryczka 已提交
966
    case kTypeRangeDeletion:
S
Stanislau Hlebik 已提交
967
      valid_ = false;
968
      return true;
S
Stanislau Hlebik 已提交
969
    case kTypeMerge:
970
      current_entry_is_merged_ = true;
A
Aaron Gao 已提交
971
      if (last_not_merge_type == kTypeDeletion ||
A
Andrew Kryczka 已提交
972 973
          last_not_merge_type == kTypeSingleDeletion ||
          last_not_merge_type == kTypeRangeDeletion) {
974 975 976
        s = MergeHelper::TimedFullMerge(
            merge_operator_, saved_key_.GetUserKey(), nullptr,
            merge_context_.GetOperands(), &saved_value_, logger_, statistics_,
977
            env_, &pinned_value_, true);
Y
Yi Wu 已提交
978 979 980 981 982 983 984 985 986 987 988
      } else if (last_not_merge_type == kTypeBlobIndex) {
        if (!allow_blob_) {
          ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index.");
          status_ = Status::NotSupported(
              "Encounter unexpected blob index. Please open DB with "
              "rocksdb::blob_db::BlobDB instead.");
        } else {
          status_ =
              Status::NotSupported("Blob DB does not support merge operator.");
        }
        valid_ = false;
989
        return false;
990
      } else {
S
Stanislau Hlebik 已提交
991
        assert(last_not_merge_type == kTypeValue);
992
        s = MergeHelper::TimedFullMerge(
993
            merge_operator_, saved_key_.GetUserKey(), &pinned_value_,
994
            merge_context_.GetOperands(), &saved_value_, logger_, statistics_,
995
            env_, &pinned_value_, true);
996
      }
S
Stanislau Hlebik 已提交
997 998
      break;
    case kTypeValue:
999
      // do nothing - we've already has value in pinned_value_
S
Stanislau Hlebik 已提交
1000
      break;
Y
Yi Wu 已提交
1001 1002 1003 1004 1005 1006 1007
    case kTypeBlobIndex:
      if (!allow_blob_) {
        ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index.");
        status_ = Status::NotSupported(
            "Encounter unexpected blob index. Please open DB with "
            "rocksdb::blob_db::BlobDB instead.");
        valid_ = false;
1008
        return false;
Y
Yi Wu 已提交
1009 1010 1011
      }
      is_blob_ = true;
      break;
S
Stanislau Hlebik 已提交
1012 1013 1014
    default:
      assert(false);
      break;
J
jorlow@chromium.org 已提交
1015
  }
1016
  if (!s.ok()) {
Y
Yi Wu 已提交
1017
    valid_ = false;
1018
    status_ = s;
1019
    return false;
1020
  }
1021
  valid_ = true;
S
Stanislau Hlebik 已提交
1022 1023
  return true;
}
J
jorlow@chromium.org 已提交
1024

S
Stanislau Hlebik 已提交
1025 1026
// This function is used in FindValueForCurrentKey.
// We use Seek() function instead of Prev() to find necessary value
1027 1028
// TODO: This is very similar to FindNextUserEntry() and MergeValuesNewToOld().
//       Would be nice to reuse some code.
S
Stanislau Hlebik 已提交
1029
bool DBIter::FindValueForCurrentKeyUsingSeek() {
1030 1031 1032
  // FindValueForCurrentKey will enable pinning before calling
  // FindValueForCurrentKeyUsingSeek()
  assert(pinned_iters_mgr_.PinningEnabled());
S
Stanislau Hlebik 已提交
1033
  std::string last_key;
1034 1035
  AppendInternalKey(&last_key, ParsedInternalKey(saved_key_.GetUserKey(),
                                                 sequence_, kValueTypeForSeek));
S
Stanislau Hlebik 已提交
1036 1037 1038
  iter_->Seek(last_key);
  RecordTick(statistics_, NUMBER_OF_RESEEKS_IN_ITERATION);

1039 1040
  // In case read_callback presents, the value we seek to may not be visible.
  // Find the next value that's visible.
S
Stanislau Hlebik 已提交
1041
  ParsedInternalKey ikey;
1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061
  while (true) {
    if (!iter_->Valid()) {
      valid_ = false;
      return iter_->status().ok();
    }

    if (!ParseKey(&ikey)) {
      return false;
    }
    if (!user_comparator_->Equal(ikey.user_key, saved_key_.GetUserKey())) {
      // No visible values for this key, even though FindValueForCurrentKey()
      // has seen some. This is possible if we're using a tailing iterator, and
      // the entries were discarded in a compaction.
      valid_ = false;
      return true;
    }

    if (IsVisible(ikey.sequence)) {
      break;
    }
1062 1063 1064

    iter_->Next();
  }
S
Stanislau Hlebik 已提交
1065

A
Andrew Kryczka 已提交
1066
  if (ikey.type == kTypeDeletion || ikey.type == kTypeSingleDeletion ||
1067
      range_del_agg_.ShouldDelete(
1068
          ikey, RangeDelPositioningMode::kBackwardTraversal)) {
J
jorlow@chromium.org 已提交
1069
    valid_ = false;
1070
    return true;
S
Stanislau Hlebik 已提交
1071
  }
Y
Yi Wu 已提交
1072 1073 1074 1075 1076 1077
  if (ikey.type == kTypeBlobIndex && !allow_blob_) {
    ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index.");
    status_ = Status::NotSupported(
        "Encounter unexpected blob index. Please open DB with "
        "rocksdb::blob_db::BlobDB instead.");
    valid_ = false;
1078
    return false;
Y
Yi Wu 已提交
1079 1080
  }
  if (ikey.type == kTypeValue || ikey.type == kTypeBlobIndex) {
A
Andrew Kryczka 已提交
1081 1082 1083 1084 1085
    assert(iter_->IsValuePinned());
    pinned_value_ = iter_->value();
    valid_ = true;
    return true;
  }
S
Stanislau Hlebik 已提交
1086 1087 1088

  // kTypeMerge. We need to collect all kTypeMerge values and save them
  // in operands
1089
  assert(ikey.type == kTypeMerge);
1090
  current_entry_is_merged_ = true;
1091
  merge_context_.Clear();
1092 1093 1094
  merge_context_.PushOperand(iter_->value(),
                             iter_->IsValuePinned() /* operand_pinned */);
  while (true) {
S
Stanislau Hlebik 已提交
1095 1096
    iter_->Next();

1097 1098 1099 1100 1101 1102
    if (!iter_->Valid()) {
      if (!iter_->status().ok()) {
        valid_ = false;
        return false;
      }
      break;
S
Stanislau Hlebik 已提交
1103
    }
1104 1105 1106 1107 1108 1109 1110 1111 1112
    if (!ParseKey(&ikey)) {
      return false;
    }
    if (!user_comparator_->Equal(ikey.user_key, saved_key_.GetUserKey())) {
      break;
    }

    if (ikey.type == kTypeDeletion || ikey.type == kTypeSingleDeletion ||
        range_del_agg_.ShouldDelete(
1113
            ikey, RangeDelPositioningMode::kForwardTraversal)) {
1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125
      break;
    } else if (ikey.type == kTypeValue) {
      const Slice val = iter_->value();
      Status s = MergeHelper::TimedFullMerge(
          merge_operator_, saved_key_.GetUserKey(), &val,
          merge_context_.GetOperands(), &saved_value_, logger_, statistics_,
          env_, &pinned_value_, true);
      if (!s.ok()) {
        valid_ = false;
        status_ = s;
        return false;
      }
Y
Yi Wu 已提交
1126
      valid_ = true;
1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
      return true;
    } else if (ikey.type == kTypeMerge) {
      merge_context_.PushOperand(iter_->value(),
                                 iter_->IsValuePinned() /* operand_pinned */);
      PERF_COUNTER_ADD(internal_merge_count, 1);
    } else if (ikey.type == kTypeBlobIndex) {
      if (!allow_blob_) {
        ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index.");
        status_ = Status::NotSupported(
            "Encounter unexpected blob index. Please open DB with "
            "rocksdb::blob_db::BlobDB instead.");
      } else {
        status_ =
            Status::NotSupported("Blob DB does not support merge operator.");
      }
Y
Yi Wu 已提交
1142
      valid_ = false;
1143 1144 1145
      return false;
    } else {
      assert(false);
1146
    }
S
Stanislau Hlebik 已提交
1147 1148
  }

1149 1150 1151 1152 1153
  Status s = MergeHelper::TimedFullMerge(
      merge_operator_, saved_key_.GetUserKey(), nullptr,
      merge_context_.GetOperands(), &saved_value_, logger_, statistics_, env_,
      &pinned_value_, true);
  if (!s.ok()) {
Y
Yi Wu 已提交
1154
    valid_ = false;
1155
    status_ = s;
1156
    return false;
1157
  }
S
Stanislau Hlebik 已提交
1158

1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171
  // Make sure we leave iter_ in a good state. If it's valid and we don't care
  // about prefixes, that's already good enough. Otherwise it needs to be
  // seeked to the current key.
  if ((prefix_extractor_ != nullptr && !total_order_seek_) || !iter_->Valid()) {
    if (prefix_extractor_ != nullptr && !total_order_seek_) {
      iter_->SeekForPrev(last_key);
    } else {
      iter_->Seek(last_key);
      if (!iter_->Valid() && iter_->status().ok()) {
        iter_->SeekToLast();
      }
    }
    RecordTick(statistics_, NUMBER_OF_RESEEKS_IN_ITERATION);
S
Stanislau Hlebik 已提交
1172
  }
1173 1174 1175

  valid_ = true;
  return true;
S
Stanislau Hlebik 已提交
1176 1177
}

1178 1179 1180 1181
// Move backwards until the key smaller than saved_key_.
// Changes valid_ only if return value is false.
bool DBIter::FindUserKeyBeforeSavedKey() {
  assert(status_.ok());
S
Stanislau Hlebik 已提交
1182
  size_t num_skipped = 0;
1183 1184 1185 1186
  while (iter_->Valid()) {
    ParsedInternalKey ikey;
    if (!ParseKey(&ikey)) {
      return false;
1187 1188
    }

1189 1190 1191 1192 1193 1194
    if (user_comparator_->Compare(ikey.user_key, saved_key_.GetUserKey()) < 0) {
      return true;
    }

    if (TooManyInternalKeysSkipped()) {
      return false;
S
Stanislau Hlebik 已提交
1195
    }
1196

S
Siying Dong 已提交
1197
    assert(ikey.sequence != kMaxSequenceNumber);
Y
Yi Wu 已提交
1198
    if (!IsVisible(ikey.sequence)) {
1199 1200 1201 1202
      PERF_COUNTER_ADD(internal_recent_skipped_count, 1);
    } else {
      PERF_COUNTER_ADD(internal_key_skipped_count, 1);
    }
1203

1204
    if (num_skipped >= max_skip_ && CanReseekToSkip()) {
1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219
      num_skipped = 0;
      IterKey last_key;
      last_key.SetInternalKey(ParsedInternalKey(
          saved_key_.GetUserKey(), kMaxSequenceNumber, kValueTypeForSeek));
      // It would be more efficient to use SeekForPrev() here, but some
      // iterators may not support it.
      iter_->Seek(last_key.GetInternalKey());
      RecordTick(statistics_, NUMBER_OF_RESEEKS_IN_ITERATION);
      if (!iter_->Valid()) {
        break;
      }
    } else {
      ++num_skipped;
    }

S
Stanislau Hlebik 已提交
1220 1221
    iter_->Prev();
  }
1222 1223 1224 1225 1226 1227 1228

  if (!iter_->status().ok()) {
    valid_ = false;
    return false;
  }

  return true;
S
Stanislau Hlebik 已提交
1229 1230
}

1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242
bool DBIter::TooManyInternalKeysSkipped(bool increment) {
  if ((max_skippable_internal_keys_ > 0) &&
      (num_internal_keys_skipped_ > max_skippable_internal_keys_)) {
    valid_ = false;
    status_ = Status::Incomplete("Too many internal keys skipped.");
    return true;
  } else if (increment) {
    num_internal_keys_skipped_++;
  }
  return false;
}

Y
Yi Wu 已提交
1243
bool DBIter::IsVisible(SequenceNumber sequence) {
1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258
  return sequence <= MaxVisibleSequenceNumber() &&
         (read_callback_ == nullptr || read_callback_->IsVisible(sequence));
}

bool DBIter::CanReseekToSkip() {
  return read_callback_ == nullptr ||
         read_callback_->MaxUnpreparedSequenceNumber() == 0;
}

SequenceNumber DBIter::MaxVisibleSequenceNumber() {
  if (read_callback_ == nullptr) {
    return sequence_;
  }

  return std::max(sequence_, read_callback_->MaxUnpreparedSequenceNumber());
Y
Yi Wu 已提交
1259 1260
}

J
jorlow@chromium.org 已提交
1261
void DBIter::Seek(const Slice& target) {
L
Lei Jin 已提交
1262
  StopWatch sw(env_, statistics_, DB_SEEK);
1263
  status_ = Status::OK();
1264
  ReleaseTempPinnedData();
1265
  ResetInternalKeysSkippedCounter();
1266 1267

  SequenceNumber seq = MaxVisibleSequenceNumber();
1268
  saved_key_.Clear();
1269
  saved_key_.SetInternalKey(target, seq);
1270

1271 1272 1273 1274 1275 1276
#ifndef ROCKSDB_LITE
  if (db_impl_ != nullptr && cfd_ != nullptr) {
    db_impl_->TraceIteratorSeek(cfd_->GetID(), target);
  }
#endif  // ROCKSDB_LITE

Z
zhangjinpeng1987 已提交
1277 1278 1279 1280
  if (iterate_lower_bound_ != nullptr &&
      user_comparator_->Compare(saved_key_.GetUserKey(),
                                *iterate_lower_bound_) < 0) {
    saved_key_.Clear();
1281
    saved_key_.SetInternalKey(*iterate_lower_bound_, seq);
Z
zhangjinpeng1987 已提交
1282 1283
  }

1284 1285
  {
    PERF_TIMER_GUARD(seek_internal_seek_time);
1286
    iter_->Seek(saved_key_.GetInternalKey());
1287
    range_del_agg_.InvalidateRangeDelMapPositions();
1288
  }
M
Manuel Ung 已提交
1289
  RecordTick(statistics_, NUMBER_DB_SEEK);
J
jorlow@chromium.org 已提交
1290
  if (iter_->Valid()) {
1291 1292 1293
    if (prefix_extractor_ && prefix_same_as_start_) {
      prefix_start_key_ = prefix_extractor_->Transform(target);
    }
1294 1295
    direction_ = kForward;
    ClearSavedValue();
1296 1297 1298 1299
    FindNextUserEntry(false /* not skipping */, prefix_same_as_start_);
    if (!valid_) {
      prefix_start_key_.clear();
    }
M
Manuel Ung 已提交
1300 1301
    if (statistics_ != nullptr) {
      if (valid_) {
1302
        // Decrement since we don't want to count this key as skipped
M
Manuel Ung 已提交
1303 1304
        RecordTick(statistics_, NUMBER_DB_SEEK_FOUND);
        RecordTick(statistics_, ITER_BYTES_READ, key().size() + value().size());
1305
        PERF_COUNTER_ADD(iter_read_bytes, key().size() + value().size());
M
Manuel Ung 已提交
1306 1307
      }
    }
J
jorlow@chromium.org 已提交
1308 1309 1310
  } else {
    valid_ = false;
  }
1311

1312
  if (valid_ && prefix_extractor_ && prefix_same_as_start_) {
1313 1314
    prefix_start_buf_.SetUserKey(prefix_start_key_);
    prefix_start_key_ = prefix_start_buf_.GetUserKey();
1315
  }
J
jorlow@chromium.org 已提交
1316
}
J
jorlow@chromium.org 已提交
1317

A
Aaron Gao 已提交
1318 1319
void DBIter::SeekForPrev(const Slice& target) {
  StopWatch sw(env_, statistics_, DB_SEEK);
1320
  status_ = Status::OK();
A
Aaron Gao 已提交
1321
  ReleaseTempPinnedData();
1322
  ResetInternalKeysSkippedCounter();
A
Aaron Gao 已提交
1323 1324 1325 1326 1327
  saved_key_.Clear();
  // now saved_key is used to store internal key.
  saved_key_.SetInternalKey(target, 0 /* sequence_number */,
                            kValueTypeForSeekForPrev);

Z
zhangjinpeng1987 已提交
1328 1329 1330 1331 1332 1333 1334
  if (iterate_upper_bound_ != nullptr &&
      user_comparator_->Compare(saved_key_.GetUserKey(),
                                *iterate_upper_bound_) >= 0) {
    saved_key_.Clear();
    saved_key_.SetInternalKey(*iterate_upper_bound_, kMaxSequenceNumber);
  }

A
Aaron Gao 已提交
1335 1336
  {
    PERF_TIMER_GUARD(seek_internal_seek_time);
1337
    iter_->SeekForPrev(saved_key_.GetInternalKey());
1338
    range_del_agg_.InvalidateRangeDelMapPositions();
A
Aaron Gao 已提交
1339 1340
  }

1341 1342 1343 1344 1345 1346
#ifndef ROCKSDB_LITE
  if (db_impl_ != nullptr && cfd_ != nullptr) {
    db_impl_->TraceIteratorSeekForPrev(cfd_->GetID(), target);
  }
#endif  // ROCKSDB_LITE

A
Aaron Gao 已提交
1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361
  RecordTick(statistics_, NUMBER_DB_SEEK);
  if (iter_->Valid()) {
    if (prefix_extractor_ && prefix_same_as_start_) {
      prefix_start_key_ = prefix_extractor_->Transform(target);
    }
    direction_ = kReverse;
    ClearSavedValue();
    PrevInternal();
    if (!valid_) {
      prefix_start_key_.clear();
    }
    if (statistics_ != nullptr) {
      if (valid_) {
        RecordTick(statistics_, NUMBER_DB_SEEK_FOUND);
        RecordTick(statistics_, ITER_BYTES_READ, key().size() + value().size());
1362
        PERF_COUNTER_ADD(iter_read_bytes, key().size() + value().size());
A
Aaron Gao 已提交
1363 1364 1365 1366 1367 1368
      }
    }
  } else {
    valid_ = false;
  }
  if (valid_ && prefix_extractor_ && prefix_same_as_start_) {
1369 1370
    prefix_start_buf_.SetUserKey(prefix_start_key_);
    prefix_start_key_ = prefix_start_buf_.GetUserKey();
A
Aaron Gao 已提交
1371 1372 1373
  }
}

J
jorlow@chromium.org 已提交
1374
void DBIter::SeekToFirst() {
1375 1376 1377 1378
  if (iterate_lower_bound_ != nullptr) {
    Seek(*iterate_lower_bound_);
    return;
  }
1379 1380 1381 1382 1383 1384
  // Don't use iter_::Seek() if we set a prefix extractor
  // because prefix seek will be used.
  if (prefix_extractor_ != nullptr && !total_order_seek_) {
    max_skip_ = std::numeric_limits<uint64_t>::max();
  }
  status_ = Status::OK();
J
jorlow@chromium.org 已提交
1385
  direction_ = kForward;
1386
  ReleaseTempPinnedData();
1387
  ResetInternalKeysSkippedCounter();
J
jorlow@chromium.org 已提交
1388
  ClearSavedValue();
1389 1390 1391 1392

  {
    PERF_TIMER_GUARD(seek_internal_seek_time);
    iter_->SeekToFirst();
1393
    range_del_agg_.InvalidateRangeDelMapPositions();
1394 1395
  }

M
Manuel Ung 已提交
1396
  RecordTick(statistics_, NUMBER_DB_SEEK);
J
jorlow@chromium.org 已提交
1397
  if (iter_->Valid()) {
1398 1399 1400
    saved_key_.SetUserKey(
        ExtractUserKey(iter_->key()),
        !iter_->IsKeyPinned() || !pin_thru_lifetime_ /* copy */);
1401
    FindNextUserEntry(false /* not skipping */, false /* no prefix check */);
M
Manuel Ung 已提交
1402 1403 1404 1405
    if (statistics_ != nullptr) {
      if (valid_) {
        RecordTick(statistics_, NUMBER_DB_SEEK_FOUND);
        RecordTick(statistics_, ITER_BYTES_READ, key().size() + value().size());
1406
        PERF_COUNTER_ADD(iter_read_bytes, key().size() + value().size());
M
Manuel Ung 已提交
1407 1408
      }
    }
J
jorlow@chromium.org 已提交
1409 1410
  } else {
    valid_ = false;
J
jorlow@chromium.org 已提交
1411
  }
1412
  if (valid_ && prefix_extractor_ && prefix_same_as_start_) {
1413 1414 1415
    prefix_start_buf_.SetUserKey(
        prefix_extractor_->Transform(saved_key_.GetUserKey()));
    prefix_start_key_ = prefix_start_buf_.GetUserKey();
1416
  }
J
jorlow@chromium.org 已提交
1417 1418
}

J
jorlow@chromium.org 已提交
1419
void DBIter::SeekToLast() {
1420 1421 1422 1423 1424 1425 1426 1427 1428 1429
  if (iterate_upper_bound_ != nullptr) {
    // Seek to last key strictly less than ReadOptions.iterate_upper_bound.
    SeekForPrev(*iterate_upper_bound_);
    if (Valid() && user_comparator_->Equal(*iterate_upper_bound_, key())) {
      ReleaseTempPinnedData();
      PrevInternal();
    }
    return;
  }

S
Stanislau Hlebik 已提交
1430
  // Don't use iter_::Seek() if we set a prefix extractor
1431
  // because prefix seek will be used.
1432
  if (prefix_extractor_ != nullptr && !total_order_seek_) {
S
Stanislau Hlebik 已提交
1433 1434
    max_skip_ = std::numeric_limits<uint64_t>::max();
  }
1435
  status_ = Status::OK();
J
jorlow@chromium.org 已提交
1436
  direction_ = kReverse;
1437
  ReleaseTempPinnedData();
1438
  ResetInternalKeysSkippedCounter();
J
jorlow@chromium.org 已提交
1439
  ClearSavedValue();
1440 1441 1442 1443

  {
    PERF_TIMER_GUARD(seek_internal_seek_time);
    iter_->SeekToLast();
1444
    range_del_agg_.InvalidateRangeDelMapPositions();
1445
  }
1446
  PrevInternal();
M
Manuel Ung 已提交
1447 1448 1449 1450 1451
  if (statistics_ != nullptr) {
    RecordTick(statistics_, NUMBER_DB_SEEK);
    if (valid_) {
      RecordTick(statistics_, NUMBER_DB_SEEK_FOUND);
      RecordTick(statistics_, ITER_BYTES_READ, key().size() + value().size());
1452
      PERF_COUNTER_ADD(iter_read_bytes, key().size() + value().size());
M
Manuel Ung 已提交
1453 1454
    }
  }
1455
  if (valid_ && prefix_extractor_ && prefix_same_as_start_) {
1456 1457 1458
    prefix_start_buf_.SetUserKey(
        prefix_extractor_->Transform(saved_key_.GetUserKey()));
    prefix_start_key_ = prefix_start_buf_.GetUserKey();
1459
  }
J
jorlow@chromium.org 已提交
1460 1461
}

1462 1463
Iterator* NewDBIterator(Env* env, const ReadOptions& read_options,
                        const ImmutableCFOptions& cf_options,
1464
                        const MutableCFOptions& mutable_cf_options,
1465 1466 1467
                        const Comparator* user_key_comparator,
                        InternalIterator* internal_iter,
                        const SequenceNumber& sequence,
Y
Yi Wu 已提交
1468
                        uint64_t max_sequential_skip_in_iterations,
1469 1470 1471 1472 1473 1474
                        ReadCallback* read_callback, DBImpl* db_impl,
                        ColumnFamilyData* cfd, bool allow_blob) {
  DBIter* db_iter = new DBIter(
      env, read_options, cf_options, mutable_cf_options, user_key_comparator,
      internal_iter, sequence, false, max_sequential_skip_in_iterations,
      read_callback, db_impl, cfd, allow_blob);
1475
  return db_iter;
1476 1477
}

I
Igor Canadi 已提交
1478
ArenaWrappedDBIter::~ArenaWrappedDBIter() { db_iter_->~DBIter(); }
1479

1480
ReadRangeDelAggregator* ArenaWrappedDBIter::GetRangeDelAggregator() {
A
Andrew Kryczka 已提交
1481 1482 1483
  return db_iter_->GetRangeDelAggregator();
}

S
sdong 已提交
1484
void ArenaWrappedDBIter::SetIterUnderDBIter(InternalIterator* iter) {
1485 1486 1487 1488 1489 1490 1491 1492 1493
  static_cast<DBIter*>(db_iter_)->SetIter(iter);
}

inline bool ArenaWrappedDBIter::Valid() const { return db_iter_->Valid(); }
inline void ArenaWrappedDBIter::SeekToFirst() { db_iter_->SeekToFirst(); }
inline void ArenaWrappedDBIter::SeekToLast() { db_iter_->SeekToLast(); }
inline void ArenaWrappedDBIter::Seek(const Slice& target) {
  db_iter_->Seek(target);
}
A
Aaron Gao 已提交
1494 1495 1496
inline void ArenaWrappedDBIter::SeekForPrev(const Slice& target) {
  db_iter_->SeekForPrev(target);
}
1497 1498 1499 1500 1501
inline void ArenaWrappedDBIter::Next() { db_iter_->Next(); }
inline void ArenaWrappedDBIter::Prev() { db_iter_->Prev(); }
inline Slice ArenaWrappedDBIter::key() const { return db_iter_->key(); }
inline Slice ArenaWrappedDBIter::value() const { return db_iter_->value(); }
inline Status ArenaWrappedDBIter::status() const { return db_iter_->status(); }
Y
Yi Wu 已提交
1502
bool ArenaWrappedDBIter::IsBlob() const { return db_iter_->IsBlob(); }
1503 1504
inline Status ArenaWrappedDBIter::GetProperty(std::string prop_name,
                                              std::string* prop) {
S
Siying Dong 已提交
1505 1506 1507 1508 1509 1510 1511
  if (prop_name == "rocksdb.iterator.super-version-number") {
    // First try to pass the value returned from inner iterator.
    if (!db_iter_->GetProperty(prop_name, prop).ok()) {
      *prop = ToString(sv_number_);
    }
    return Status::OK();
  }
1512 1513
  return db_iter_->GetProperty(prop_name, prop);
}
S
Siying Dong 已提交
1514 1515 1516

void ArenaWrappedDBIter::Init(Env* env, const ReadOptions& read_options,
                              const ImmutableCFOptions& cf_options,
1517
                              const MutableCFOptions& mutable_cf_options,
S
Siying Dong 已提交
1518 1519
                              const SequenceNumber& sequence,
                              uint64_t max_sequential_skip_in_iteration,
Y
Yi Wu 已提交
1520
                              uint64_t version_number,
1521 1522
                              ReadCallback* read_callback, DBImpl* db_impl,
                              ColumnFamilyData* cfd, bool allow_blob,
1523
                              bool allow_refresh) {
S
Siying Dong 已提交
1524
  auto mem = arena_.AllocateAligned(sizeof(DBIter));
1525 1526 1527 1528
  db_iter_ = new (mem) DBIter(env, read_options, cf_options, mutable_cf_options,
                              cf_options.user_comparator, nullptr, sequence,
                              true, max_sequential_skip_in_iteration,
                              read_callback, db_impl, cfd, allow_blob);
S
Siying Dong 已提交
1529
  sv_number_ = version_number;
1530
  allow_refresh_ = allow_refresh;
S
Siying Dong 已提交
1531 1532 1533
}

Status ArenaWrappedDBIter::Refresh() {
1534
  if (cfd_ == nullptr || db_impl_ == nullptr || !allow_refresh_) {
S
Siying Dong 已提交
1535 1536 1537
    return Status::NotSupported("Creating renew iterator is not allowed.");
  }
  assert(db_iter_ != nullptr);
1538 1539 1540
  // TODO(yiwu): For last_seq_same_as_publish_seq_==false, this is not the
  // correct behavior. Will be corrected automatically when we take a snapshot
  // here for the case of WritePreparedTxnDB.
S
Siying Dong 已提交
1541 1542 1543 1544 1545 1546 1547 1548 1549
  SequenceNumber latest_seq = db_impl_->GetLatestSequenceNumber();
  uint64_t cur_sv_number = cfd_->GetSuperVersionNumber();
  if (sv_number_ != cur_sv_number) {
    Env* env = db_iter_->env();
    db_iter_->~DBIter();
    arena_.~Arena();
    new (&arena_) Arena();

    SuperVersion* sv = cfd_->GetReferencedSuperVersion(db_impl_->mutex());
1550 1551
    Init(env, read_options_, *(cfd_->ioptions()), sv->mutable_cf_options,
         latest_seq, sv->mutable_cf_options.max_sequential_skip_in_iterations,
1552 1553
         cur_sv_number, read_callback_, db_impl_, cfd_, allow_blob_,
         allow_refresh_);
S
Siying Dong 已提交
1554 1555

    InternalIterator* internal_iter = db_impl_->NewInternalIterator(
1556 1557
        read_options_, cfd_, sv, &arena_, db_iter_->GetRangeDelAggregator(),
        latest_seq);
S
Siying Dong 已提交
1558 1559 1560 1561 1562 1563
    SetIterUnderDBIter(internal_iter);
  } else {
    db_iter_->set_sequence(latest_seq);
    db_iter_->set_valid(false);
  }
  return Status::OK();
1564
}
J
jorlow@chromium.org 已提交
1565

1566
ArenaWrappedDBIter* NewArenaWrappedDbIterator(
1567
    Env* env, const ReadOptions& read_options,
1568 1569
    const ImmutableCFOptions& cf_options,
    const MutableCFOptions& mutable_cf_options, const SequenceNumber& sequence,
S
Siying Dong 已提交
1570
    uint64_t max_sequential_skip_in_iterations, uint64_t version_number,
Y
Yi Wu 已提交
1571
    ReadCallback* read_callback, DBImpl* db_impl, ColumnFamilyData* cfd,
1572
    bool allow_blob, bool allow_refresh) {
1573
  ArenaWrappedDBIter* iter = new ArenaWrappedDBIter();
1574
  iter->Init(env, read_options, cf_options, mutable_cf_options, sequence,
Y
Yi Wu 已提交
1575
             max_sequential_skip_in_iterations, version_number, read_callback,
1576
             db_impl, cfd, allow_blob, allow_refresh);
1577
  if (db_impl != nullptr && cfd != nullptr && allow_refresh) {
Y
Yi Wu 已提交
1578 1579
    iter->StoreRefreshInfo(read_options, db_impl, cfd, read_callback,
                           allow_blob);
S
Siying Dong 已提交
1580
  }
1581

1582
  return iter;
J
jorlow@chromium.org 已提交
1583 1584
}

1585
}  // namespace rocksdb