1. 25 1月, 2020 1 次提交
  2. 24 1月, 2020 4 次提交
  3. 23 1月, 2020 24 次提交
    • T
      Fix intrinsics treatment in Crossgen2 · 78411a26
      Tomas 提交于
      This change fixes unintentional differences in the treatment of
      intrinsics in Crossgen2 compared to Crossgen1 I found while
      investigating failures in the regression test b426654. While the
      change by itself doesn't fully fix the test, I believe it to be
      generally useful towards removing the remaining codegen
      differences between the compilers.
      
      Thanks
      
      Tomas
      78411a26
    • M
      Contributing: fixed some typos (#2061) · 672dd763
      Maher Jendoubi 提交于
      672dd763
    • A
      Remove gc_lh_block_event (#2059) · 579b1d93
      Andrew Au 提交于
      579b1d93
    • D
      Refactor compilation module group (#1889) · fd7a5e8c
      David Wrighton 提交于
      - Our CompilationModule groups used for single method compilation and general compilation had diverged substantially, reducing the effectiveness of single method compilation substantially
      - The profiler guided optimization logic also needs to use the VersionWithCode logic to identify which methods are interesting to consider, this will happen in a future change
      - The VersionsWith logic in CompilationModuleGroup did not correctly model versionable logic.
        - Methods with generic parameters were not handled correctly. Method generic parameters did not contribute to the VersionsWith logic.
        - The newer ideas in our recent work on upcoming enhancements to crossgen2 driven compilation enhancements are aligned with this effort
        - Add support for the concept of considering instantiations over primitive types to be legal even if the primitive types aren't part of the version bubble. (Only if there are no constraints in the generic)
      
      - Also a bonus determinism fix. In cases where MemberRef's were being used in combination with ENCODE_FIELD_SIG_OwnerType, we could possibly emit multiple different choices for the token emitting in a signature.
      fd7a5e8c
    • J
      Change HostPolicyMock to use CharSet.Auto now that it correctly switches to... · ea8ece4a
      Jeremy Koritzinsky 提交于
      Change HostPolicyMock to use CharSet.Auto now that it correctly switches to Ansi (aka Utf8) on non-Windows. (#2031)
      
      ea8ece4a
    • J
      Don't block non-blittable pointer types in P/Invokes. (#1866) · 53e8fea8
      Jeremy Koritzinsky 提交于
      * Don't block non-blittable pointer types in P/Invokes.
      
      Don't block non-blittable pointer types in P/Invokes. If you're using pointers in interop you're already using unsafe code so we're going to assume you know what you're doing. C# won't let you form a pointer to a reference, so there's no risk of passing an object reference directly to native unless you're writing IL directly.
      
      Fixes dotnet/coreclr#27800
      
      * Delete unused resources.
      
      * Apply fix to managed type system as well.
      
      * Add positive test for nonblittable pointers. Remove negative tests that were in GenericTest.
      53e8fea8
    • S
      Rename PAL_CMAKE_* CLR_CMAKE_* (#1984) · a680821f
      Steve MacLean 提交于
      * Rename PAL_CMAKE_* CLR_CMAKE_*
      
      Remove separatation between CLR_CMAKE and PAL_CMAKE defines
      
      Revise PAL_CMAKE_PLATFORM* defines to use CLR_CMAKE_HOST* defines
      
      Revise other PAL_CMAKE_* defines to use CLR_CMAKE_* equivalents.
      
      Remove redundant compiler configuration
      a680821f
    • L
      host: Allow comments in JSON files (#1070) · e25017b0
      Leandro A. F. Pereira 提交于
      host: Allow comments in JSON files
      e25017b0
    • J
      Fix System.Net.Quick.csproj configurations (#1675) · 5971ba45
      Jan Vorlicek 提交于
      The Configurations.props file was modified to have $(NetCoreAppCurrent)-Linux and
      $(NetCoreAppCurrent)-OSX instead of $(NetCoreAppCurrent)-Unix in a recent PR #427,
      but the Configurations in the System.Net.Quic.csproj were not updated accordingly.
      5971ba45
    • M
      Add asynchronous overload of WindowsIdentity.RunImpersonated (#1152) · beff8ab2
      Marco Rossignoli 提交于
      * add RunImpersonateAsync overloads
      
      * skip on full framework
      
      * run test netcoreapp only
      
      * skip tests on nanoserver
      
      * address PR feedback
      
      * address PR feedback
      
      * address PR feedback
      
      * address PR feedback
      
      * Update WindowsIdentity.cs
      
      update comment
      
      * Update WindowsIdentity.cs
      
      update comment
      
      * Update WindowsIdentity.cs
      
      Fix comment
      
      * Update WindowsIdentity.cs
      
      fix comment
      
      * Fix comment
      beff8ab2
    • M
      configure.ac: remove AC_SEARCH_LIBS for libintl (#2027) · 62c00342
      Marek Safar 提交于
      configure.ac: remove AC_SEARCH_LIBS for libintl
      62c00342
    • A
      Enable NetworkAddressChange on FreeBSD (#1602) · a4129114
      Adeel Mujahid 提交于
      a4129114
    • J
      Protect multi-threaded access to Module.m_GenericParamToDescMap. (#1907) · 7a02a535
      Jan Kotas 提交于
      Same type can be loaded by multiple threads in parallel in rare situations
      
      Fixes #1847
      7a02a535
    • D
      [master] Update dependencies from dotnet/arcade mono/linker Microsoft/vstest (#1804) · 6cfbbef6
      dotnet-maestro[bot] 提交于
      * Update dependencies from https://github.com/dotnet/arcade build 20200115.5
      
      - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20065.5
      - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20065.5
      - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20065.5
      - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20065.5
      - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20065.5
      - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20065.5
      - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20065.5
      - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20065.5
      - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20065.5
      - Microsoft.DotNet.GenAPI - 5.0.0-beta.20065.5
      - Microsoft.DotNet.GenFacades - 5.0.0-beta.20065.5
      - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20065.5
      - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20065.5
      - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20065.5
      
      * Update dependencies from https://github.com/dotnet/arcade build 20200116.1
      
      - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20066.1
      - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20066.1
      - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20066.1
      - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20066.1
      - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20066.1
      - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20066.1
      - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20066.1
      - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20066.1
      - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20066.1
      - Microsoft.DotNet.GenAPI - 5.0.0-beta.20066.1
      - Microsoft.DotNet.GenFacades - 5.0.0-beta.20066.1
      - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20066.1
      - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20066.1
      - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20066.1
      
      * Update dependencies from https://github.com/microsoft/vstest build 20200116-01
      
      - Microsoft.NET.Test.Sdk - 16.5.0-preview-20200116-01
      
      * Update dependencies from https://github.com/dotnet/arcade build 20200117.2
      
      - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20067.2
      - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20067.2
      - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20067.2
      - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20067.2
      - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20067.2
      - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20067.2
      - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20067.2
      - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20067.2
      - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20067.2
      - Microsoft.DotNet.GenAPI - 5.0.0-beta.20067.2
      - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20067.2
      - Microsoft.DotNet.GenFacades - 5.0.0-beta.20067.2
      - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20067.2
      - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20067.2
      
      * Update dependencies from https://github.com/dotnet/arcade build 20200118.1
      
      - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20068.1
      - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20068.1
      - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20068.1
      - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20068.1
      - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20068.1
      - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20068.1
      - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20068.1
      - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20068.1
      - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20068.1
      - Microsoft.DotNet.GenAPI - 5.0.0-beta.20068.1
      - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20068.1
      - Microsoft.DotNet.GenFacades - 5.0.0-beta.20068.1
      - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20068.1
      - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20068.1
      
      * Update dependencies from https://github.com/microsoft/vstest build 20200120-01
      
      - Microsoft.NET.Test.Sdk - 16.5.0-preview-20200120-01
      
      * Update dependencies from https://github.com/dotnet/arcade build 20200121.3
      
      - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20071.3
      - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20071.3
      - Microsoft.DotNet.ApiCompat - 5.0.0-beta.20071.3
      - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20071.3
      - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.20071.3
      - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20071.3
      - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20071.3
      - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20071.3
      - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20071.3
      - Microsoft.DotNet.GenAPI - 5.0.0-beta.20071.3
      - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20071.3
      - Microsoft.DotNet.GenFacades - 5.0.0-beta.20071.3
      - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20071.3
      - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20071.3
      6cfbbef6
    • S
      Add a Sockets test to validate undesired blocking of continuations (#1973) · 28646107
      Stephen Toub 提交于
      We go out of our way (e.g. on Unix queueing work off of the epoll threads) to ensure that arbitrary user code running as part of socket continuations doesn't block those threads and potentially deadlock.  Add a test to help validate this.
      28646107
    • B
      Don't do STRESS_PROFILER_CALLBACKS when pre-JITing (#2016) · 8861275a
      Bruce Forstall 提交于
      This leads us to generate an illegal relocation fixup.
      
      Fixes #1789
      8861275a
    • L
      host: Allow comments in JSON files · f6675997
      Leandro Pereira 提交于
      Although JSON doesn't support comments, a common extension is to enable
      JavaScript-style comments.  By default, RapidJSON will error out if
      comments are found in the input data, but it can be configured to
      ignore them.
      
      This is useful especially when testing out changes in
      runtimeconfig.json files.
      
      Fixes http://github.com/dotnet/core-setup/5661
      f6675997
    • S
      Tweak codegen for Regex's FindFirstChar (#1996) · 5a948f14
      Stephen Toub 提交于
      * Avoid extra field loads / comparisons in FindFirstChar
      
      If we've already compared the current pos to the end pos as part of a minimum length check, we don't need to repeat it again later.  We can also read from locals rather than fields more than we are to save redundant field reads.
      
      * Reduce branches in Boyer-Moore negative switch table
      
      It's often the case that lots of negative branches have the same value.  We can coalesce them.
      
      * Address PR feedback
      5a948f14
    • K
      Prohibit null key on HMAC. (#2018) · 0f51290d
      Kevin Jones 提交于
      * Validate key on HMAC classes.
      
      A refactoring in HMACCommon caused null keys to be implicitly converted
      in to empty spans. This lead to a null key being used as an empty key.
      
      * Use assertion helper to test parameter name.
      0f51290d
    • M
      configure.ac: remove AC_SEARCH_LIBS for libintl · 80d161f7
      monojenkins 提交于
      This causes an additional dependency of mono on libintl which we didn't have before.
      Reported by a user on gitter, it's problematic on macOS since it makes the mono binary depend on the libintl we ship in the Mono .pkg.
      
      It was introduced in Mono 6.6 by https://github.com/mono/mono/commit/18e0ebfe89be0a175d2f904b9bb1ec6816daa318
      80d161f7
    • A
      Enable Mono build in CI (#1934) · 6eb3edf8
      Alexander Köplinger 提交于
      * Enable Mono in default build
      
      * Integrate Mono into the build system
      
      * Fix System.Private.CoreLib build in Mono
      
      Broken by https://github.com/dotnet/runtime/commit/9c82a36c23235c4d50954cb33a4d5d89b787a1aa
      
      * Disable Windows test runs
      
      Fails due to https://github.com/dotnet/runtime/issues/1933Co-authored-by: NViktor Hofer <viktor.hofer@microsoft.com>
      6eb3edf8
    • V
      Moving fast parts of cast FCALLs to managed code. (#1068) · c3dc1fdf
      Vladimir Sadov 提交于
      * Exposed casting cache to managed code
      * Implemented a managed version of cache lookup
      * Moved `JIT_IsInstanceOfAny` and `JIT_ChkCastAny`  to managed code as the first ones to move.
      * Skip managed JIT helpers in exception stack traces and debugger
      * Managed `JIT_IsInstanceOfInterface`
      * All other cast helpers are managed.
      
      Fixes:https://github.com/dotnet/coreclr/issues/27931
      c3dc1fdf
    • S
      Improve error messages for invalid WebSocket headers (#1962) · 375a15ba
      Stephen Toub 提交于
      And add tests.
      375a15ba
    • J
      Split AsnReader into a class and a ref struct (AsnValueReader) · 47ab0dc0
      Jeremy Barton 提交于
      Largely, the intent of this change was to reduce the number of temporary readers required for deeply structured payloads (`ReadSequence` returns a new reader), while still maintaining the better usability of the class; and, frankly, to understand what the impact of splitting functionality into "bare metal" and "more usable" pieces was.
      
      ```
      foreach (file in AsnReader.*)
      {
          Copy/paste the entirety of the `partial class AsnReader`;
          Change the top version to say ref partial struct AsnValueReader;
          Replace all AsnReader calls in the top version to say AsnValueReader.
          Replace all ReadOnlyMemory in the top portion with ReadOnlySpan;
          Remove ArraySegment overloads from the top portion (when present);
          Rewrite the bottom portion to open a ref reader at the state the memory is tracking and defer work into the ref reader;
          Run all the existing tests to ensure that nothing broke in that piece;
      }
      ```
      
      Once that was done, I changed the asn.xslt to generate all of the decoding in terms of AsnValueReader.  This didn't change field generation from ReadOnlyMemory to ReadOnlySpan (and the types from struct to ref struct)--a change that could be done later--but instead added a new ReadOnlyMemory input parameter so it can use Overlaps to slice the memory as appropriate (with a fallback of ToArray()).
      
      While I was editing asn.xslt I fixed probably all of the whitespace errors it generated.  I still left the "stylecop, have no opinion about whitespace" pragma since the generator isn't run as part of most people's (or the official) builds.  This also turns on the nullability checks in all of the generated structs.
      47ab0dc0
  4. 22 1月, 2020 11 次提交