Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Meiracle
spring-framework
提交
5328184f
S
spring-framework
项目概览
Meiracle
/
spring-framework
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
spring-framework
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
5328184f
编写于
12月 01, 2020
作者:
R
Rossen Stoyanchev
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
ContentCachingResponseWrapper skips contentLength for chunked responses
Closes gh-26182
上级
1e19e51c
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
73 addition
and
1 deletion
+73
-1
spring-web/src/main/java/org/springframework/web/util/ContentCachingResponseWrapper.java
...ringframework/web/util/ContentCachingResponseWrapper.java
+4
-1
spring-web/src/test/java/org/springframework/web/filter/ContentCachingResponseWrapperTests.java
...mework/web/filter/ContentCachingResponseWrapperTests.java
+69
-0
未找到文件。
spring-web/src/main/java/org/springframework/web/util/ContentCachingResponseWrapper.java
浏览文件 @
5328184f
...
...
@@ -27,6 +27,7 @@ import javax.servlet.WriteListener;
import
javax.servlet.http.HttpServletResponse
;
import
javax.servlet.http.HttpServletResponseWrapper
;
import
org.springframework.http.HttpHeaders
;
import
org.springframework.lang.Nullable
;
import
org.springframework.util.FastByteArrayOutputStream
;
...
...
@@ -209,7 +210,9 @@ public class ContentCachingResponseWrapper extends HttpServletResponseWrapper {
if
(
this
.
content
.
size
()
>
0
)
{
HttpServletResponse
rawResponse
=
(
HttpServletResponse
)
getResponse
();
if
((
complete
||
this
.
contentLength
!=
null
)
&&
!
rawResponse
.
isCommitted
())
{
rawResponse
.
setContentLength
(
complete
?
this
.
content
.
size
()
:
this
.
contentLength
);
if
(
rawResponse
.
getHeader
(
HttpHeaders
.
TRANSFER_ENCODING
)
==
null
)
{
rawResponse
.
setContentLength
(
complete
?
this
.
content
.
size
()
:
this
.
contentLength
);
}
this
.
contentLength
=
null
;
}
this
.
content
.
writeTo
(
rawResponse
.
getOutputStream
());
...
...
spring-web/src/test/java/org/springframework/web/filter/ContentCachingResponseWrapperTests.java
0 → 100644
浏览文件 @
5328184f
/*
* Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package
org.springframework.web.filter
;
import
java.nio.charset.StandardCharsets
;
import
javax.servlet.http.HttpServletResponse
;
import
org.junit.jupiter.api.Test
;
import
org.springframework.http.HttpHeaders
;
import
org.springframework.util.FileCopyUtils
;
import
org.springframework.web.testfixture.servlet.MockHttpServletResponse
;
import
org.springframework.web.util.ContentCachingResponseWrapper
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
/**
* Unit tests for {@link ContentCachingResponseWrapper}.
* @author Rossen Stoyanchev
*/
public
class
ContentCachingResponseWrapperTests
{
@Test
void
copyBodyToResponse
()
throws
Exception
{
byte
[]
responseBody
=
"Hello World"
.
getBytes
(
StandardCharsets
.
UTF_8
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
ContentCachingResponseWrapper
responseWrapper
=
new
ContentCachingResponseWrapper
(
response
);
responseWrapper
.
setStatus
(
HttpServletResponse
.
SC_OK
);
FileCopyUtils
.
copy
(
responseBody
,
responseWrapper
.
getOutputStream
());
responseWrapper
.
copyBodyToResponse
();
assertThat
(
response
.
getStatus
()).
isEqualTo
(
200
);
assertThat
(
response
.
getContentLength
()
>
0
).
isTrue
();
assertThat
(
response
.
getContentAsByteArray
()).
isEqualTo
(
responseBody
);
}
@Test
void
copyBodyToResponseWithTransferEncoding
()
throws
Exception
{
byte
[]
responseBody
=
"6\r\nHello 5\r\nWorld0\r\n\r\n"
.
getBytes
(
StandardCharsets
.
UTF_8
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
ContentCachingResponseWrapper
responseWrapper
=
new
ContentCachingResponseWrapper
(
response
);
responseWrapper
.
setStatus
(
HttpServletResponse
.
SC_OK
);
responseWrapper
.
setHeader
(
HttpHeaders
.
TRANSFER_ENCODING
,
"chunked"
);
FileCopyUtils
.
copy
(
responseBody
,
responseWrapper
.
getOutputStream
());
responseWrapper
.
copyBodyToResponse
();
assertThat
(
response
.
getStatus
()).
isEqualTo
(
200
);
assertThat
(
response
.
getHeader
(
HttpHeaders
.
TRANSFER_ENCODING
)).
isEqualTo
(
"chunked"
);
assertThat
(
response
.
getHeader
(
HttpHeaders
.
CONTENT_LENGTH
)).
isNull
();
assertThat
(
response
.
getContentAsByteArray
()).
isEqualTo
(
responseBody
);
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录