1. 04 12月, 2017 1 次提交
    • B
      Auto merge of #46393 - kennytm:45861-step-2-3-make-tools-job-not-fail-fast, r=alexcrichton · f2b11f30
      bors 提交于
      [auto-toolstate][2+3/8] Move external tools tests into its own job with --no-fail-fast
      
      This PR performs these  things:
      
      1. The `aux` job now performs "cargotest" and "pretty" tests. The clippy/rustfmt/rls/miri tests are moved into its own job.
      2. These tests are run with `--no-fail-fast`, so that we can get the maximum number of failures of all tools from a single CI run.
      3. The test results are stored into a JSON file, ready to be uploaded in the future.
      
      This is step 2 and 3/8 of automatic management of broken tools #45861.
      f2b11f30
  2. 03 12月, 2017 24 次提交
  3. 02 12月, 2017 15 次提交
    • B
      Auto merge of #46349 - estebank:highlight-ref, r=arielb1 · 9053fdd4
      bors 提交于
      On type mismatch error highlight `&` when type matches
      
      When the only difference between the two types in a type error is that
      one is a reference to the other type (`T` vs `&T`) or both are
      references differing only in their mutability (`&T` vs `&mut T`), don't
      highlight the type (`T`).
      9053fdd4
    • B
      Auto merge of #46347 - raventid:did-you-mean-increase-accuracy, r=estebank · 7a649872
      bors 提交于
      Add case insensitive comparison, besides Levenstein for DYM
      
      Closes #46332
      
      Draft version. The idea is that Levenstein does not work for some cases when we have multiple equal weights for strings. I didn't understand the case with `if found != name => Some(found)` so it means that new code does not work correctly yet.
      
      At least now I think that we might return all maximal weights from levenstein and think about next cases in priority order:
      
      1) There is exact match -> None
      2) There is exact match, but case insensitive -> Some(match)
      3) There is some match from levenstein -> Some(matches.take_any)
      4) There is no match -> None
      
      @estebank WDYT?
      7a649872
    • B
      Auto merge of #46343 - jseyfried:fix_hygiene_bug, r=nrc · e0d11f39
      bors 提交于
      Fix hygiene bug.
      
      Fixes #42708.
      r? @nrc
      e0d11f39
    • B
      Auto merge of #46326 - GuillaumeGomez:sidebar-text, r=QuietMisdreavus · 8bcbf91a
      bors 提交于
      Fix invalid HTML escape
      
      Fixes #46289.
      
      r? @QuietMisdreavus
      8bcbf91a
    • B
      Auto merge of #46288 - alexcrichton:bump-bootstrap, r=Mark-Simulacrum · c3942e75
      bors 提交于
      Bump to 1.24.0
      
      * Update the in-tree version number
      * Update the bootstrap compiler
      * Remove `cfg(stage0)` annotations
      * Update crate dependencies
      * Update Cargo itself
      c3942e75
    • B
      Auto merge of #46256 - estebank:suggest-deref, r=arielb1 · b15a8eaf
      bors 提交于
      Use suggestions instead of notes ref mismatches
      
      On type mismatch errors, use a suggestion when encountering minimal
      differences in type differences due to refs, instead of a note.
      b15a8eaf
    • B
      Auto merge of #45904 - sunjay:gat-parser, r=nikomatsakis · ddaebe93
      bors 提交于
      Generic Associated Types Parsing & Name Resolution
      
      Hi!
      This PR adds parsing for generic associated types! 🎉 🎉 🎉
      
      Tracking Issue: #44265
      
      ## Notes For Reviewers
      * [x] I still need to add the stdout and stderr files to my ui tests. It takes me a *long* time to compile the compiler locally, so I'm going to add this as soon as possible in the next day or so.
      * [ ] My current ui tests aren't very good or very thorough. I'm reusing the `parse_generics` and `parse_where_clause` methods from elsewhere in the parser, so my changes work without being particularly complex. I'm not sure if I should duplicate all of the generics test cases for generic associated types. It might actually be appropriate to duplicate everything here, since we don't want to rely on an implementation detail in case it changes in the future. If you think so too, I'll adapt all of the generics test cases into the generic associated types test cases.
      * [ ] There is still more work required to make the run-pass tests pass here. In particular, we need to make the following errors disappear:
      ```
      error[E0110]: lifetime parameters are not allowed on this type
        --> ./src/test/run-pass/rfc1598-generic-associated-types/streaming_iterator.rs:23:41
         |
      23 |     bar: <T as StreamingIterator>::Item<'static>,
         |                                         ^^^^^^^ lifetime parameter not allowed on this type
      ```
      ```
      error[E0261]: use of undeclared lifetime name `'a`
        --> ./src/test/run-pass/rfc1598-generic-associated-types/iterable.rs:15:47
         |
      15 |     type Iter<'a>: Iterator<Item = Self::Item<'a>>;
         |                                               ^^ undeclared lifetime
      ```
      There is a FIXME comment in streaming_iterator. If you uncomment that line, you get the following:
      ```
      error: expected one of `!`, `+`, `,`, `::`, or `>`, found `=`
        --> ./src/test/run-pass/rfc1598-generic-associated-types/streaming_iterator.rs:29:45
         |
      29 | fn foo<T: for<'a> StreamingIterator<Item<'a>=&'a [i32]>>(iter: T) { /* ... */ }
         |                                             ^ expected one of `!`, `+`, `,`, `::`, or `>` here
      ```
      
      r? @nikomatsakis
      ddaebe93
    • E
    • B
      Auto merge of #46430 - kennytm:rollup, r=kennytm · 70517540
      bors 提交于
      Rollup of 13 pull requests
      
      - Successful merges: #45880, #46280, #46373, #46376, #46385, #46386, #46387, #46392, #46400, #46401, #46405, #46412, #46421
      - Failed merges:
      70517540
    • G
      Fix deduplication of items · 30734c4e
      Guillaume Gomez 提交于
      30734c4e
    • B
      Auto merge of #46425 - eddyb:mir-place, r=nikomatsakis · bb42071f
      bors 提交于
      MIR: change "lvalue" terminology to "place".
      
      As pointed out elsewhere, "lvalue" vs "rvalue" is a misleading/obscure distinction and several other choices have been proposed, the one I prefer being "place" vs "value".
      
      This PR only touches the "lvalue" side, and only in MIR-related code, as it's already a lot and could rot.
      bb42071f
    • E
      Use suggestions instead of notes ref mismatches · 36faafee
      Esteban Küber 提交于
      On type mismatch errors, use a suggestion when encountering minimal
      differences in type differences due to refs, instead of a note.
      36faafee
    • K
      Rollup merge of #46421 - mnd:fix-build-for-guix, r=alexcrichton · 56174775
      kennytm 提交于
      build_helper: destination file can't be up to date when not exists
      
      Function "up_to_date" return incorrect result if mtime for all fetched sources is set to epoch time. Add existence check to function.
      
      This fix required for a [Guix](https://www.gnu.org/software/guix/) package because a Nix builder set mtime of all sources to epoch time.
      56174775
    • K
      Rollup merge of #46412 - chrisduerr:issue-46380, r=QuietMisdreavus · 662f9027
      kennytm 提交于
      Hide private trait type params and show hidden items with document-private
      
      As discussed in #46380, this PR removes the `strip-hidden` pass from `--document-private-items` which allows showing `#[doc(hidden)]` with rustdoc.
      
      The second commit removes the trait implementation from the docs if the trait's parameter is private.
      662f9027
    • K
      Rollup merge of #46405 - alexcrichton:fix-rustdoc, r=estebank · 3f99b7c9
      kennytm 提交于
      rustc: Filter out bogus extern crate warnings
      
      Rustdoc has for some time now used the "everybody loops" pass in the compiler to
      avoid typechecking and otherwise avoid looking at implementation details.
      In #46115 the placement of this pass was pushed back in the compiler to after
      macro expansion to ensure that it works with macro-expanded code as well. This
      in turn caused the regression in #46271.
      
      The bug here was that the resolver was producing `def_id` instances for
      "possibly unused extern crates" which would then later get processed during
      typeck to actually issue lint warnings. The problem was that *after* resolution
      these `def_id` nodes were actually removed from the AST by the "everybody loops"
      pass. This later, when we tried to take a look at `def_id`, caused the compiler
      to panic.
      
      The fix applied here is a bit of a heavy hammer which is to just, in this one
      case, ignore the `extern crate` lints if the `def_id` looks "bogus" in any way
      (basically if it looks like the node was removed after resolution). The real
      underlying bug here is probably that the "everybody loops" AST pass is being
      stressed to much beyond what it was originally intended to do, but this should
      at least fix the ICE for now...
      
      Closes #46271
      3f99b7c9