1. 24 6月, 2019 5 次提交
    • L
      HIR: rename get_parent_node_by_hir_id to get_parent_node · d08bd72e
      ljedrz 提交于
      d08bd72e
    • L
      c7e1f4dc
    • B
      Auto merge of #62070 - ia0:rustfmt, r=petrochenkov · 85ed21e8
      bors 提交于
      Run rustfmt on some libsyntax files
      
      As part of #62008, run rustfmt on:
      - src/libsyntax/ext/tt/macro_rules.rs
      - src/libsyntax/ext/tt/quoted.rs
      
      There is no semantic change. To fix potential merge conflicts, simply choose the other side then run rustfmt and fix any tidy check (like line length).
      85ed21e8
    • B
      Auto merge of #62037 - Mark-Simulacrum:tidy-fast, r=eddyb · de7c4e42
      bors 提交于
      Speed up tidy
      
      master:
        Time (mean ± σ):      3.478 s ±  0.033 s    [User: 3.298 s, System: 0.178 s]
        Range (min … max):    3.425 s …  3.525 s    10 runs
      
      This PR:
        Time (mean ± σ):      1.098 s ±  0.006 s    [User: 783.7 ms, System: 310.2 ms]
        Range (min … max):    1.092 s …  1.113 s    10 runs
      
      Alleviates https://github.com/rust-lang/rust/issues/59884. For the most part each commit stands on its own. Timings are on warm filesystem cache.
      
      r? @EddyB
      de7c4e42
    • B
      Auto merge of #61778 - petrochenkov:pass, r=Mark-Simulacrum · 2cd5ed49
      bors 提交于
      compiletest: Introduce `// {check,build,run}-pass` pass modes
      
      Pass UI tests now have three modes
      ```
      // check-pass
      // build-pass
      // run-pass
      ```
      mirroring equivalent well-known `cargo` commands.
      
      `// check-pass` will compile the test skipping codegen (which is expensive and isn't supposed to fail in most cases).
      `// build-pass` will compile and link the test without running it.
      `// run-pass` will compile, link and run the test.
      Tests without a "pass" annotation are still considered "fail" tests.
      
      Most UI tests would probably want to switch to `check-pass`.
      Tests validating codegen would probably want to run the generated code as well and use `run-pass`.
      `build-pass` should probably be rare (linking tests?).
      
      https://github.com/rust-lang/rust/pull/61755 will provide a way to run the tests with any mode, e.g. bump `check-pass` tests to `run-pass` to satisfy especially suspicious people, and be able to make sure that codegen doesn't breaks in some entirely unexpected way.
      Tests marked with any mode are expected to pass with any other mode, if that's not the case for some legitimate reason, then the test should be made a "fail" test rather than a "pass" test.
      Perhaps some secondary CI can verify this invariant, but that's not super urgent.
      
      `// compile-pass` still works and is equivalent to `build-pass`.
      Why is `// compile-pass` bad - 1) it gives an impression that the test is only compiled, but not linked, 2) it doesn't mirror a cargo command.
      It can be removed some time in the future in a separate PR.
      
      cc https://github.com/rust-lang/rust/issues/61712
      2cd5ed49
  2. 23 6月, 2019 35 次提交