- 04 1月, 2020 24 次提交
-
-
由 Guillaume Gomez 提交于
Remove unused `#[link_name = "m"]` attributes These were perhaps supposed to be `#[link(name = "m")]` but linking libm should be handled by the libc crate anyway. They should have triggered a compile error: #47725
-
由 Guillaume Gomez 提交于
Clean up err codes r? @Dylan-DPC
-
由 Guillaume Gomez 提交于
improve some `Drop`-related error messages
-
由 Guillaume Gomez 提交于
Revert `const_err` lint checking of casts Reverts part of #67676 r? @oli-obk cc @SimonSapin
-
由 bors 提交于
Move early and late lint mechanisms to librustc_lint. As requested, split from #67737 r? @Zoxc
-
由 bors 提交于
Rollup of 8 pull requests Successful merges: - #66913 (Suggest calling method when first argument is `self`) - #67531 (no longer promote non-pattern const functions) - #67773 (Add a test for #37333) - #67786 (Nix reexports from `rustc_span` in `syntax`) - #67789 (Cleanup linkchecker whitelist) - #67810 (Implement uncommon_codepoints lint.) - #67835 (tweak wording of mismatched delimiter errors) - #67845 (Also remove const-hack for abs) Failed merges: r? @ghost
-
由 Dylan DPC 提交于
-
由 Mazdak Farrokhzad 提交于
Also remove const-hack for abs Closes #67842. r? @oli-obk
-
由 Mazdak Farrokhzad 提交于
tweak wording of mismatched delimiter errors This PR improves the wording of the "incorrect delimiter" error messages. Here's a quick rationale: - *"un-closed" -> "unclosed"*: "unclosed" is valid English, so there's no need to hyphenate the prefix. This should be pretty uncontroversial, I think. - *"close delimiter" -> "closing delimiter"*: In my anecdotal experience, I've always heard "closing delimiter" or "closing parenthesis". In addition, the codebase already uses this terminology in comments and function names more than "close delimiter", which could indicate that it's more intuitive. - "incorrect delimiter" -> "mismatched delimiter": "Incorrect delimiter" is vague; why is it incorrect? "mismatched" clearly indicates why the delimiter is causing the error. r? @estebank
-
由 Mazdak Farrokhzad 提交于
Implement uncommon_codepoints lint. Part of #55467 . The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
-
由 Mazdak Farrokhzad 提交于
Cleanup linkchecker whitelist linkchecker is no longer run on the compiler docs so they can be removed from the whitelist.
-
由 Mazdak Farrokhzad 提交于
Nix reexports from `rustc_span` in `syntax` Remove reexports `syntax::{source_map, symbol, edition}` and use `rustc_span` paths directly. r? @petrochenkov
-
由 Mazdak Farrokhzad 提交于
Add a test for #37333 The test checks that we reuse the CGU of a crate when the implementation details of an `extern crate` have changed. Signed-off-by: NMichal Terepeta <michal.terepeta@gmail.com>
-
由 Mazdak Farrokhzad 提交于
no longer promote non-pattern const functions This is trying to pack-pedal a bit on promotion feature creep, as proposed by @EddyB [here](https://github.com/rust-lang/const-eval/issues/19#issuecomment-472799062): possibly, a sane subset of `const fn` that we could promote are those that are just constructors -- the same subset that we might want to allow in pattern position at some point. So, this removes the `rustc_promotable` attribute from the three functions they identified that do not fit this pattern. The first step is to run crater to see if there is code in the wild that relies on this being promotable. r? @oli-obk
-
由 Mazdak Farrokhzad 提交于
Suggest calling method when first argument is `self` Closes: #66782 I've explored different approaches for this MR but I think the most straightforward is the best one. I've tried to find out if the methods for given type exist (to maybe have a better suggestion), but we don't collect them anywhere and collecting them is quite problematic. Moreover, collecting all the methods would require rewriting big part of the code and also could potentially include performance degradation, which I don't think is necessary for this simple case.
-
由 Oliver Middleton 提交于
These were perhaps supposed to be `#[link(name = "m")]` but linking libm should be handled by the libc crate anyway.
-
由 Guillaume Gomez 提交于
-
由 Guillaume Gomez 提交于
-
由 Andy Russell 提交于
-
由 Andy Russell 提交于
- Use the span of the predicate - Use the def's description instead of "struct/enum" (notably incorrect for unions) - Align formatting with other error messages
-
由 jumbatm 提交于
-
由 bors 提交于
Attempt to fix intermittent failures of pgo-branch-weights test. This PR tries to fix the intermittent failures of the pgo-branch-weights test (https://github.com/rust-lang/rust/issues/67746). The failing instances show no `!prof` annotations in LLVM IR. One possible cause is that the instrumented binary did not record anything. This is something I've occasionally seen happen for similarly small programs when using GNU ld as linker. The linker would not properly append the instruction counter sections, leading to most counters being dropped. This PR makes the test use the Gold linker instead. It also makes each command exit immediately on failure so we can pinpoint the failure source better, should there still be a problem. r? @Mark-Simulacrum
-
由 bors 提交于
update miri Fixes https://github.com/rust-lang/rust/issues/67793
- 03 1月, 2020 16 次提交
-
-
由 Andy Russell 提交于
-
由 Michael Woerister 提交于
-
由 bors 提交于
Rollup of 10 pull requests Successful merges: - #67450 (Allow for setting a ThinLTO import limit during bootstrap) - #67595 (Suggest adding a lifetime constraint for opaque type) - #67636 (allow rustfmt key in [build] section) - #67736 (Less-than is asymmetric, not antisymmetric) - #67762 (Add missing links for insecure_time) - #67783 (Warn for bindings named same as variants when matching against a borrow) - #67796 (Ensure that we process projections during MIR inlining) - #67807 (Use drop instead of the toilet closure `|_| ()`) - #67816 (Clean up err codes) - #67825 (Minor: change take() docs grammar to match other docs) Failed merges: r? @ghost
-
由 Yuki Okushi 提交于
Minor: change take() docs grammar to match other docs Eg. mem::replace()
-
由 Yuki Okushi 提交于
Clean up err codes r? @Dylan-DPC
-
由 Yuki Okushi 提交于
Use drop instead of the toilet closure `|_| ()`
-
由 Yuki Okushi 提交于
Ensure that we process projections during MIR inlining Fixes #67710 Previously, we were not calling `super_place`, which resulted in us failing to update any local references that occur in ProjectionElem::Index. This caused the post-inlining MIR to contain a reference to a local ID from the inlined callee, leading to an ICE due to a type mismatch.
-
由 Yuki Okushi 提交于
Warn for bindings named same as variants when matching against a borrow Fixes #67776
-
由 Yuki Okushi 提交于
Add missing links for insecure_time
-
由 Yuki Okushi 提交于
Less-than is asymmetric, not antisymmetric This has bothered me for a while. It's such a small nit, but...
-
由 Yuki Okushi 提交于
allow rustfmt key in [build] section Permit using `rustfmt` in `config.toml`. It will allow to not download `rustfmt` binary, which is not possible for at least some tiers-3 platforms. Fixes: #67624 r? @Mark-Simulacrum
-
由 Yuki Okushi 提交于
Suggest adding a lifetime constraint for opaque type Fixes #67577, where code like this: ``` struct List { data: Vec<String>, } impl List { fn started_with<'a>(&'a self, prefix: &'a str) -> impl Iterator<Item=&'a str> { self.data.iter().filter(|s| s.starts_with(prefix)).map(|s| s.as_ref()) } } ``` will show this error: ``` Compiling playground v0.0.1 (/playground) error[E0597]: `prefix` does not live long enough --> src/lib.rs:6:47 | 5 | fn started_with<'a>(&'a self, prefix: &'a str) -> impl Iterator<Item=&'a str> { | -- lifetime `'a` defined here --------------------------- opaque type requires that `prefix` is borrowed for `'a` ... ``` but without suggesting the lovely `help: you can add a constraint..`. r? @estebank
-
由 Yuki Okushi 提交于
Allow for setting a ThinLTO import limit during bootstrap The benchmarks in https://github.com/rust-lang/rust/pull/66625 have shown that a lower ThinLTO import limit can be a net win for bootstrap times. This PR: - exposes the setting to `config.toml`, - defaults to a lower limit if `incremental = true` in `config.toml`, and - sets a lower limit for `x86_64-gnu-llvm-7` CI image in order to make the jobs complete more quickly (which remains to be tested). This setting will affect how the compiler and it's tools are compiled. It will not affect the settings the compiler uses when compiling user code. r? @pietroalbini cc @rust-lang/infra
-
由 bors 提交于
Revert #65244 for performance reasons This reverts commit f35517ee. Revert #65244 so we can see if it is the cause of the performance issue in #67706 cc https://github.com/rust-lang/rust/issues/67644
-
由 Peter Todd 提交于
Eg. mem::replace()
-
由 Wesley Wiser 提交于
Reverts part of #67676
-