1. 17 11月, 2014 4 次提交
    • B
      auto merge of #18927 : areski/rust/pr-improve-option-match-readl, r=jakub- · 803aacd5
      bors 提交于
      **match** are much more easy to read when it's not in 1 single line
      803aacd5
    • B
      auto merge of #18747 : csherratt/rust/ringbuf-remove-option, r=huonw · 0b7b4f07
      bors 提交于
      Fix for task in Metabug #18009 (Rebased version of https://github.com/rust-lang/rust/pull/18170)
      
      This changes much of about how RingBuf functions. `lo`, `nelts` are replaced by a more traditional `head` and`tail`. The `Vec<Option<T>>` is replaced by a bare pointer that is managed by the `RingBuf` itself. This also expects the ring buffer to always be size that is a power of 2.
      
      This change also includes a number of new tests to cover the some areas that could be of concern with manual memory management.
      
      The benchmarks have been reworked since the old ones were benchmarking of the Ring buffers growth rather then the actual test.
      
      The unit test suite have been expanded, and exposed some bugs in `fn get()` and `fn get_mut()`
      
      ## Benchmark
      **Before:**
      ```
      test ring_buf::tests::bench_grow_1025                      ... bench:      8919 ns/iter (+/- 87)
      test ring_buf::tests::bench_iter_1000                      ... bench:       924 ns/iter (+/- 28)
      test ring_buf::tests::bench_mut_iter_1000                  ... bench:       918 ns/iter (+/- 6)
      test ring_buf::tests::bench_new                            ... bench:        15 ns/iter (+/- 0)
      test ring_buf::tests::bench_pop_100                        ... bench:       294 ns/iter (+/- 9)
      test ring_buf::tests::bench_pop_front_100                  ... bench:       948 ns/iter (+/- 32)
      test ring_buf::tests::bench_push_back_100                  ... bench:       291 ns/iter (+/- 16)
      test ring_buf::tests::bench_push_front_100                 ... bench:       311 ns/iter (+/- 27
      ```
      **After:**
      ```
      test ring_buf::tests::bench_grow_1025                      ... bench:      2209 ns/iter (+/- 169)
      test ring_buf::tests::bench_iter_1000                      ... bench:       534 ns/iter (+/- 27)
      test ring_buf::tests::bench_mut_iter_1000                  ... bench:       515 ns/iter (+/- 28)
      test ring_buf::tests::bench_new                            ... bench:        11 ns/iter (+/- 0)
      test ring_buf::tests::bench_pop_100                        ... bench:       170 ns/iter (+/- 5)
      test ring_buf::tests::bench_pop_front_100                  ... bench:       171 ns/iter (+/- 11)
      test ring_buf::tests::bench_push_back_100                  ... bench:       172 ns/iter (+/- 13)
      test ring_buf::tests::bench_push_front_100                 ... bench:       158 ns/iter (+/- 12)
      
      ```
      0b7b4f07
    • B
      auto merge of #18995 : alfie/rust/comment-docs, r=aturon · 245c7fbe
      bors 提交于
      Start comment is a string literal while end comment is made up of two character literals. This change is to make them consistent.
      245c7fbe
    • B
      auto merge of #18994 : sfackler/rust/struct-variants-pt2, r=jakub- · aad75471
      bors 提交于
      Struct variant field visibility is now inherited. Remove `pub` keywords
      from declarations.
      
      Closes #18641
      
      [breaking-change]
      
      r? @alexcrichton 
      aad75471
  2. 16 11月, 2014 36 次提交