- 24 5月, 2020 15 次提交
-
-
由 Ralf Jung 提交于
-
由 bors 提交于
Rollup of 5 pull requests Successful merges: - #71618 (Preserve substitutions when making trait obligations for suggestions) - #72092 (Unblock font loading in rustdoc.css) - #72400 (Add missing ASM arena declarations to librustc_middle) - #72489 (Fix ice-72487) - #72502 (fix discriminant type in generator transform) Failed merges: r? @ghost
-
由 Dylan DPC 提交于
fix discriminant type in generator transform The generator transform assumed that the discriminant type is always `isize`, which is not correct, leading to [ICEs in Miri](https://github.com/rust-lang/rust/pull/72419/files#r429543536) when some extra sanity checking got enabled. r? @jonas-schievink @EddyB
-
由 Dylan DPC 提交于
Fix ice-72487 Fixes #72487 r? @Amanieu
-
由 Dylan DPC 提交于
Add missing ASM arena declarations to librustc_middle Fixes #72386 These types also need to get allocated on the `librustc_middle` arena when we deserialize MIR. @Amanieu: If we end up using your approach in https://github.com/rust-lang/rust/pull/72392 instead, feel free to copy the test I added over to your PR.
-
由 Dylan DPC 提交于
Unblock font loading in rustdoc.css rustdoc's font loading defaults to "auto", so browsers may block render. But rustdoc's case prefers a faster TTI for scrolling, this means the strictest font-display in use should be "swap". rustdoc's fonts do provide notable legibility improvements but first-time users will have little trouble reading without. This means "optional" is preferred. The one exception is Source Serif Pro: it's a big difference for body text, so "fallback" is preferred over "optional" to cause a (tiny) block. This follows up on (but does not resolve) #20962, taking PageSpeed Insight's rec fairly directly. Supporting reading material: https://drafts.csswg.org/css-fonts-4/#font-display-desc
-
由 Dylan DPC 提交于
Preserve substitutions when making trait obligations for suggestions Resolves #71394. I *think* `map_bound_ref` is correct here. In any case, I think a lot of the diagnostic code is using `skip_binder` more aggressively than it should be, so I doubt that this is worse than the status quo. The assertion that `new_self_ty` has no escaping bound vars should be enough. r? @estebank cc @nikomatsakis Is the call to `skip_binder` on line 551 (and elsewhere in this file) appropriate? https://github.com/rust-lang/rust/blob/46ec74e60f238f694b46c976d6217e7cf8d4cf1a/src/librustc_trait_selection/traits/error_reporting/suggestions.rs#L537-L565
-
由 bors 提交于
Revert MSYS2 CI workaround MSYS2 has made workaround for critical packages so older installers like one used by chocolatey can work again. Fixes https://github.com/rust-lang/rust/issues/72333
-
由 Aaron Hill 提交于
Fixes #72386 This type also needs to get allocated on the `librustc_middle` arena when we deserialize MIR.
-
由 bors 提交于
Rollup of 5 pull requests Successful merges: - #72292 (Replace obligation construction with deref_steps()) - #72431 (add warning sign to UB examples) - #72446 (Impl Ord for proc_macro::LineColumn) - #72492 (Add some regression tests) - #72496 (Correct small typo: 'not' -> 'note') Failed merges: r? @ghost
-
由 Dylan DPC 提交于
Correct small typo: 'not' -> 'note'
-
由 Dylan DPC 提交于
Add some regression tests Closes #69415 Closes #72455 r? @matthewjasper
-
由 Dylan DPC 提交于
Impl Ord for proc_macro::LineColumn ```rust impl Ord for LineColumn {...} impl PartialOrd for LineColumn {...} ``` for https://doc.rust-lang.org/nightly/proc_macro/struct.LineColumn.html. The ordering is the natural one you would get by writing one line after another, where we compare line first, then compare columns within the same line.
-
由 Dylan DPC 提交于
add warning sign to UB examples Just to make it less likely that people miss the fact that these are examples for how to *not* do it.
-
由 Dylan DPC 提交于
Replace obligation construction with deref_steps() 1. Use `probe()` to avoid unwanted binding committing during `deref_steps()`. 2. Fixes #59819 again by using `deref_steps()`, make the code cleaner. And if we want to suggest multiple dereferences (like: `consider dereferencing the borrow: "****a"`) in the future, this change will make it easier to achieve.
-
- 23 5月, 2020 25 次提交
-
-
由 Ralf Jung 提交于
-
由 Ralf Jung 提交于
-
由 Ralf Jung 提交于
-
由 Jake Goulding 提交于
-
由 Yuki Okushi 提交于
-
由 Yuki Okushi 提交于
-
由 bors 提交于
Rollup of 7 pull requests Successful merges: - #71289 (Allow using `Self::` in doc) - #72375 (Improve E0599 explanation) - #72385 (Add some teams to prioritization exclude_labels) - #72395 (Allow rust-highfive to label issues it creates.) - #72453 (Add flag to open docs: x.py doc --open) - #72459 (Add core::future::IntoFuture) - #72461 (Clean up E0600 explanation) Failed merges: r? @ghost
-
由 Gary Guo 提交于
-
由 bors 提交于
Use `once_cell` crate instead of custom data structure Internally, we use the [`Once`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_data_structures/sync/struct.Once.html) type for shared data that is initialized exactly once and only read from afterwards. `Once` uses a `parking_lot::Mutex` when the parallel compiler is enabled and a `RefCell` when it is not. This PR switches to the [`once_cell`](https://crates.io/crates/once_cell) crate, which also uses a `parking_lot::Mutex` for its `sync` version (because we enable the `parking_lot` feature) but has zero overhead for its `unsync` one. This PR adds `once_cell` to the list of whitelisted dependencies. I think this is acceptable because it is already used in `rustc_driver`, is owned by a well-known community member (cc @matklad), and has a stable release. cc @rust-lang/compiler `once_cell` has a slightly more minimal API than `Once`, which allows for initialization to be either optimistic (evaluate the initializer and then synchronize) or pessimistic (synchronize and then evaluate the initializer). `once_cell`'s `get_or_init` is always pessimistic. The optimistic version is only used once in the current `master`. r? @Mark-Simulacrum
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
Otherwise inserting it to the `Binder` used by `trait_ref` would cause problems. This is just to be extra carefult: we aren't going to start recommending that the user start using HKTs anytime soon.
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
`mk_obligation_for_def_id` is only correct if the trait and self type do not have any substitutions. Use a different method, `mk_trait_obligation_with_new_self_ty` that is more clear about what is happening.
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
-
由 Dylan MacKenzie 提交于
-
由 Dylan DPC 提交于
Clean up E0600 explanation r? @Dylan-DPC
-
由 Dylan DPC 提交于
Add core::future::IntoFuture This patch reintroduces the `core::future::IntoFuture` trait. However unlike earlier PRs this patch does not integrate it into the `async/.await` lowering since that lead to performance regressions. By introducing the trait separately from the integration, the integration PR can be more narrowly scoped, and people can start trying out the `IntoFuture` trait today. Thanks heaps! cc/ @rust-lang/wg-async-foundations ## References - Original PR adding `IntoFuture` https://github.com/rust-lang/rust/pull/65244 - Open issue to re-land `IntoFuture` (assigned to me) https://github.com/rust-lang/rust/issues/67982 - Tracking issue for `IntoFuture` https://github.com/rust-lang/rust/issues/67644
-
由 Dylan DPC 提交于
Add flag to open docs: x.py doc --open This aligns with Cargo's flag `cargo doc --open`. Tested with: ```bash # opens doc/index.html x.py doc --stage 0 --open x.py doc --stage 0 --open src/doc # opens doc/book/index.html x.py doc --stage 0 --open src/doc/book # opens doc/std/index.html x.py doc --stage 0 --open src/libstd # opens doc/proc_macro/index.html x.py doc --stage 0 --open src/libproc_macro # opens both x.py doc --stage 0 --open src/libstd src/libproc_macro ```
-
由 Dylan DPC 提交于
Allow rust-highfive to label issues it creates. This is my first meaningful PR, I am unsure how to test this code so any pointers would be welcome! I am about 50% sure it works.
-
由 Dylan DPC 提交于
Add some teams to prioritization exclude_labels r? @Mark-Simulacrum @LeSeulArtichaut
-