1. 01 7月, 2018 8 次提交
    • Z
      in which hir::Visibility recalls whence it came (i.e., becomes Spanned) · 4ae89129
      Zack M. Davis 提交于
      There are at least a couple (and plausibly even three) diagnostics that
      could use the spans of visibility modifiers in order to be reliably
      correct (rather than hacking and munging surrounding spans to try to
      infer where the visibility keyword must have been).
      
      We follow the naming convention established by the other `Spanned` HIR
      nodes: the "outer" type alias gets the "prime" node-type name, the
      "inner" enum gets the name suffixed with an underscore, and the variant
      names are prefixed with the prime name and `pub use` exported from here
      (from HIR).
      
      Thanks to veteran reviewer Vadim Petrochenkov for suggesting this
      uniform approach. (A previous draft, based on the reasoning that
      `Visibility::Inherited` should not have a span, tried to hack in a named
      `span` field on `Visibility::Restricted` and a positional field on
      `Public` and `Crate`. This was ... not so uniform.)
      4ae89129
    • Z
      choose a less arbitrary span when parsing the empty visibility modifier · 9df9c9df
      Zack M. Davis 提交于
      Visibility spans were added to the AST in #47799 (d6bdf296) as a
      `Spanned<_>`—which means that we need to choose a span even in the case
      of inherited visibility (what you get when there's no `pub` &c. keyword
      at all). That initial implementation's choice is pretty
      counterintuitive, which could matter if we want to use it as a site to
      suggest inserting a visibility modifier, &c.
      
      (The phrase "Schelling span" in the comment is meant in analogy to the
      game-theoretic concept of a "Schelling point", a value that is chosen
      simply because it's what one can expect to agree upon with other agents
      in the absence of explicit coördination.)
      9df9c9df
    • B
      Auto merge of #51943 - oli-obk:miriup, r=kennytm · 33b40f56
      bors 提交于
      Update the miri submodule
      
      r? @kennytm
      33b40f56
    • B
      Auto merge of #51717 - Mark-Simulacrum:snap, r=alexcrichton · 48af7714
      bors 提交于
      Bootstrap from 1.28.0 beta
      48af7714
    • M
      Notice non-toplevel dll dependencies in rustbuild · 3d687749
      Mark Simulacrum 提交于
      Previously Cargo would hardlink all the dependencies into the "root" as
      foo.dll and the `toplevel` array would get populated with these, but
      that's no longer the case. Instead, cargo will only do this for the
      final artifacts/final libraries.
      
      Rustbuild is updated to continue looping through the artifacts mentioned
      instead of early-returning. This should fix the bug.
      
      @alexcrichton found the cause of this and suggested this fix.
      3d687749
    • M
      Bootstrap from 1.28.0-beta.3 · ad97f8b4
      Mark Simulacrum 提交于
      ad97f8b4
    • B
      Auto merge of #51849 - nikomatsakis:issue-51820-places-conflict, r=eddyb · 74c89b02
      bors 提交于
      optimize `places_conflict` to avoid complex vectors etc
      
      Fixes #51820
      74c89b02
    • B
      Auto merge of #51862 - estebank:lifetime-spans, r=nikomatsakis · 8772747c
      bors 提交于
      Point to lifetime spans on lifetime errors
      8772747c
  2. 30 6月, 2018 16 次提交
  3. 29 6月, 2018 16 次提交