1. 07 10月, 2017 6 次提交
  2. 06 10月, 2017 14 次提交
    • B
      Auto merge of #45065 - arielb1:not-correct, r=nikomatsakis · b67f4283
      bors 提交于
      fix logic error in #44269's `prune_cache_value_obligations`
      
      We want to retain obligations that *contain* inference variables, not
      obligations that *don't contain* them, in order to fix #43132. Because
      of surrounding changes to inference, the ICE doesn't occur in its
      original case, but I believe it could still be made to occur on master.
      
      Maybe I should try to write a new test case? Certainly not right now
      (I'm mainly trying to get us a beta that we can ship) but maybe before
      we land this PR on nightly?
      
      This seems to cause a 10% performance regression in my imprecise
      attempt to benchmark item-body checking for #43613, but it's better to
      be slow and right than fast and wrong. If we want to recover that, I
      think we can change the constrained-type-parameter code to actually
      give a list of projections that are important for resolving inference
      variables and filter everything else out.
      b67f4283
    • A
      fix logic error in #44269's `prune_cache_value_obligations` · 91fdadba
      Ariel Ben-Yehuda 提交于
      We want to retain obligations that *contain* inference variables, not
      obligations that *don't contain* them, in order to fix #43132. Because
      of surrounding changes to inference, the ICE doesn't occur in its
      original case, but I believe it could still be made to occur on master.
      
      Maybe I should try to write a new test case? Certainly not right now
      (I'm mainly trying to get us a beta that we can ship) but maybe before
      we land this PR on nightly?
      
      This seems to cause a 10% performance regression in my imprecise
      attempt to benchmark item-body checking for #43613, but it's better to
      be slow and right than fast and wrong. If we want to recover that, I
      think we can change the constrained-type-parameter code to actually
      give a list of projections that are important for resolving inference
      variables and filter everything else out.
      91fdadba
    • B
      Auto merge of #44734 - mchlrhw:wip/hashmap-entry-and-then, r=BurntSushi · a8feaee5
      bors 提交于
      Implement `and_modify` on `Entry`
      
      ## Motivation
      
      `Entry`s are useful for allowing access to existing values in a map while also allowing default values to be inserted for absent keys. The existing API is similar to that of `Option`, where `or` and `or_with` can be used if the option variant is `None`.
      
      The `Entry` API is, however, missing an equivalent of `Option`'s `and_then` method. If it were present it would be possible to modify an existing entry before calling `or_insert` without resorting to matching on the entry variant.
      
      Tracking issue: https://github.com/rust-lang/rust/issues/44733.
      a8feaee5
    • B
      Auto merge of #44965 - oconnor663:res_init_glibc, r=dtolnay · 3ed8b698
      bors 提交于
      replace libc::res_init with res_init_if_glibc_before_2_26
      
      The previous workaround for gibc's res_init bug is not thread-safe on
      other implementations of libc, and it can cause crashes. Use a runtime
      check to make sure we only call res_init when we need to, which is also
      when it's safe. See https://github.com/rust-lang/rust/issues/43592.
      
      ~This PR is returning an InvalidData IO error if the glibc version string fails to parse. We could also have treated that case as "not glibc", and gotten rid of the idea that these functions could return an error. (Though I'm not a huge fan of ignoring error returns from `res_init` in any case.) Do other folks agree with these design choices?~
      
      I'm pretty new to hacking on libstd. Is there an easy way to build a toy rust program against my changes to test this, other than doing an entire `sudo make install` on my system? What's the usual workflow?
      3ed8b698
    • M
      Implement `entry_and_modify` · 9e36111f
      mchlrhw 提交于
      9e36111f
    • B
      Auto merge of #44818 - petrochenkov:astymac2, r=jseyfried · ed1cffdb
      bors 提交于
      Improve resolution of associated types in declarative macros 2.0
      
      Make various identifier comparisons for associated types (and sometimes other associated items) hygienic.
      Now declarative macros 2.0 can use `Self::AssocTy`, `TyParam::AssocTy`, `Trait<AssocTy = u8>` where `AssocTy` is an associated type of a trait `Trait` visible from the macro. Also, `Trait` can now be implemented inside the macro and specialization should work properly (fixes https://github.com/rust-lang/rust/pull/40847#issuecomment-310867299).
      
      r? @jseyfried or @EddyB
      ed1cffdb
    • B
      Auto merge of #44951 - vitiral:incr_struct_defs, r=michaelwoerister · b9158208
      bors 提交于
      incr compilation struct_defs.rs
      
      I am prematurely openeing this as I need mentoring help from @michaelwoerister (also pinged @nikomatsakis)
      
      First, is this the right approach for these changes?
      
      Second, I'm a bit confused by the results so far.
      
      - Changing `TupleStructFieldType(i32)` -> `...(u32)` changes only Hir and HirBody, not TypeOfItem
      - Chaning `TupleStructAddField(i32)` -> `...(i32, u32)` *does* change TypeOfItem
      
      This seems wrong. I feel like it should change TypeOfItem in both cases. Is this a bug in incr compilation or is it expected?
      b9158208
    • A
      `proc_macro::Span` API improvements · 7be36d2a
      Austin Bonander 提交于
      7be36d2a
    • B
      Auto merge of #45054 - andjo403:master, r=alexcrichton · f5e036a2
      bors 提交于
      Faster compile times for release builds with llvm fix
      
      Run global optimizations after the inliner to avoid spending time on optimizing dead code.
      
      fixes #44655
      f5e036a2
    • J
      replace libc::res_init with res_init_if_glibc_before_2_26 · 9602fe15
      Jack O'Connor 提交于
      The previous workaround for gibc's res_init bug is not thread-safe on
      other implementations of libc, and it can cause crashes. Use a runtime
      check to make sure we only call res_init when we need to, which is also
      when it's safe. See https://github.com/rust-lang/rust/issues/43592.
      9602fe15
    • V
      2d9161d1
    • B
      Auto merge of #44943 - nivkner:fixme_fixup, r=dtolnay · 417c7389
      bors 提交于
      address some FIXME whose associated issues were marked as closed
      
      part of #44366
      417c7389
    • A
      8fd3c8f7
    • B
      Auto merge of #44878 - Nashenas88:master, r=nikomatsakis · 4531131b
      bors 提交于
      Store a new Region value every time we create a new region variable
      
      Paired with @spastorino to walk through this and implement #44870.
      4531131b
  3. 05 10月, 2017 20 次提交