1. 13 8月, 2023 3 次提交
    • B
      Auto merge of #114763 - Kobzol:fix-ci-docker-caching, r=Mark-Simulacrum · 28eb857b
      bors 提交于
      CI: fix Docker layer caching
      
      As reported by `@klensy` on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/docker.20images.20always.20rebuilded), Github Actions have recently updated their Docker version from 20.x to 23.x, which enabled the BuildKit build backend by default.
      
      This broke our way of performing Docker layer caching on CI, which immediately made all non-PR CI builds (including try builds) ~1 hour longer (Docker caching didn't work on PR builds before, so it wasn't affected). The moment this started happening can be seen [here](https://github.com/rust-lang-ci/rust/actions?page=2&query=branch%3Aauto+is%3Asuccess).
      
      The problem is with the following command:
      ```
      docker history -q rust-ci | \
                grep -v missing | \
                xargs docker save | \
                gzip | \
                $upload
      ```
      which returns the intermediate layers as `<missing>`, if BuildKit is enabled. This was investigated by `@klensy` in https://github.com/rust-lang/rust/pull/114621. Thanks for that!
      
      I will continue experimenting with how we can enable the cache with BuildKit in https://github.com/rust-lang/rust/pull/114762, but for the time being, I think that we should just hotfix this.
      
      This PR reverts the build backend back to the old one, which fixes the caching. However, we also have to bust the cache of all Dockerfiles, otherwise caching would only start kicking in for them the next time they are updated (or the next time GH updates their docker version). Because when the Docker version was updated the last time, the Dockerfiles were cached on S3 with basically an empty cache, and unless we bust it, even after reverting to the old build engine, the CI script would just download the empty cache and rebuild the Dockerfile from scratch, thus nullifying our fix.
      
      r? `@Mark-Simulacrum`
      28eb857b
    • B
      Auto merge of #114756 - matthiaskrgr:rollup-4m7l4p6, r=matthiaskrgr · cbb48a5e
      bors 提交于
      Rollup of 7 pull requests
      
      Successful merges:
      
       - #94455 (Partially stabilize `int_roundings`)
       - #114132 (Better Debug for Vars and VarsOs)
       - #114584 (E0277 nolonger points at phantom `.await`)
       - #114667 (Record binder for bare trait object in LifetimeCollectVisitor)
       - #114692 (downgrade `internal_features` to warn)
       - #114703 (Cover ParamConst in smir)
       - #114734 (Mark oli as "on vacation")
      
      r? `@ghost`
      `@rustbot` modify labels: rollup
      cbb48a5e
    • J
      CI: fix Docker layer caching · 6ca13d05
      Jakub Beránek 提交于
      6ca13d05
  2. 12 8月, 2023 14 次提交
  3. 11 8月, 2023 23 次提交