Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
int
Rust
提交
b86285af
R
Rust
项目概览
int
/
Rust
大约 1 年 前同步成功
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
Rust
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b86285af
编写于
8月 21, 2023
作者:
E
Esteban Küber
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Do not emit invalid suggestion in E0191 when spans overlap
Fix #115019.
上级
bf766cd3
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
15 addition
and
6 deletion
+15
-6
compiler/rustc_hir_analysis/src/astconv/errors.rs
compiler/rustc_hir_analysis/src/astconv/errors.rs
+15
-1
tests/ui/associated-type-bounds/overlaping-bound-suggestion.stderr
...associated-type-bounds/overlaping-bound-suggestion.stderr
+0
-5
未找到文件。
compiler/rustc_hir_analysis/src/astconv/errors.rs
浏览文件 @
b86285af
...
...
@@ -597,7 +597,21 @@ pub(crate) fn complain_about_missing_associated_types(
}
}
}
if
!
suggestions
.is_empty
()
{
suggestions
.sort_by_key
(|
&
(
span
,
_
)|
span
);
// There are cases where one bound points to a span within another bound's span, like when
// you have code like the following (#115019), so we skip providing a suggestion in those
// cases to avoid having a malformed suggestion.
//
// pub struct Flatten<I> {
// inner: <IntoIterator<Item: IntoIterator<Item: >>::IntoIterator as Item>::core,
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// | ^^^^^^^^^^^^^^^^^^^^^
// | |
// | associated types `Item`, `IntoIter` must be specified
// associated types `Item`, `IntoIter` must be specified
// }
let
overlaps
=
suggestions
.windows
(
2
)
.any
(|
pair
|
pair
[
0
]
.0
.overlaps
(
pair
[
1
]
.0
));
if
!
suggestions
.is_empty
()
&&
!
overlaps
{
err
.multipart_suggestion
(
format!
(
"specify the associated type{}"
,
pluralize!
(
types_count
)),
suggestions
,
...
...
tests/ui/associated-type-bounds/overlaping-bound-suggestion.stderr
浏览文件 @
b86285af
...
...
@@ -6,11 +6,6 @@ LL | inner: <IntoIterator<Item: IntoIterator<Item: >>::IntoIterator as Item>
| | |
| | associated types `Item`, `IntoIter` must be specified
| associated types `Item`, `IntoIter` must be specified
|
help: specify the associated types
|
LL | inner: <IntoIterator<Item: IntoIterator<Item: >, Item = Type, IntoIter = Type>IntoIterator<Item: , Item = Type, IntoIter = Type>>::IntoIterator as Item>::Core,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error[E0223]: ambiguous associated type
--> $DIR/overlaping-bound-suggestion.rs:7:13
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录