Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
int
Rust
提交
b78367d8
R
Rust
项目概览
int
/
Rust
11 个月 前同步成功
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
Rust
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b78367d8
编写于
6月 21, 2019
作者:
S
Shotaro Yamada
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Support `impl Trait` in inlined documentation
上级
cdff9189
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
122 addition
and
22 deletion
+122
-22
src/librustdoc/clean/inline.rs
src/librustdoc/clean/inline.rs
+6
-3
src/librustdoc/clean/mod.rs
src/librustdoc/clean/mod.rs
+74
-17
src/librustdoc/core.rs
src/librustdoc/core.rs
+22
-2
src/test/rustdoc/inline_cross/auxiliary/impl_trait_aux.rs
src/test/rustdoc/inline_cross/auxiliary/impl_trait_aux.rs
+7
-0
src/test/rustdoc/inline_cross/impl_trait.rs
src/test/rustdoc/inline_cross/impl_trait.rs
+13
-0
未找到文件。
src/librustdoc/clean/inline.rs
浏览文件 @
b78367d8
...
...
@@ -217,8 +217,9 @@ fn build_external_function(cx: &DocContext<'_>, did: DefId) -> clean::Function {
};
let
predicates
=
cx
.tcx
.predicates_of
(
did
);
let
generics
=
(
cx
.tcx
.generics_of
(
did
),
&
predicates
)
.clean
(
cx
);
let
decl
=
(
did
,
sig
)
.clean
(
cx
);
let
(
generics
,
decl
)
=
clean
::
enter_impl_trait
(
cx
,
||
{
((
cx
.tcx
.generics_of
(
did
),
&
predicates
)
.clean
(
cx
),
(
did
,
sig
)
.clean
(
cx
))
});
let
(
all_types
,
ret_types
)
=
clean
::
get_all_types
(
&
generics
,
&
decl
,
cx
);
clean
::
Function
{
decl
,
...
...
@@ -372,7 +373,9 @@ pub fn build_impl(cx: &DocContext<'_>, did: DefId, attrs: Option<Attrs<'_>>,
None
}
})
.collect
::
<
Vec
<
_
>>
(),
(
tcx
.generics_of
(
did
),
&
predicates
)
.clean
(
cx
),
clean
::
enter_impl_trait
(
cx
,
||
{
(
tcx
.generics_of
(
did
),
&
predicates
)
.clean
(
cx
)
}),
)
};
let
polarity
=
tcx
.impl_polarity
(
did
);
...
...
src/librustdoc/clean/mod.rs
浏览文件 @
b78367d8
...
...
@@ -45,7 +45,7 @@
use
std
::
sync
::
Arc
;
use
std
::
u32
;
use
crate
::
core
::{
self
,
DocContext
};
use
crate
::
core
::{
self
,
DocContext
,
ImplTraitParam
};
use
crate
::
doctree
;
use
crate
::
html
::
render
::{
cache
,
ExternalLocation
};
use
crate
::
html
::
item_type
::
ItemType
;
...
...
@@ -1540,7 +1540,7 @@ fn clean(&self, cx: &DocContext<'_>) -> GenericParamDef {
ty
::
GenericParamDefKind
::
Lifetime
=>
{
(
self
.name
.to_string
(),
GenericParamDefKind
::
Lifetime
)
}
ty
::
GenericParamDefKind
::
Type
{
has_default
,
..
}
=>
{
ty
::
GenericParamDefKind
::
Type
{
has_default
,
synthetic
,
..
}
=>
{
cx
.renderinfo
.borrow_mut
()
.external_param_names
.insert
(
self
.def_id
,
self
.name
.clean
(
cx
));
let
default
=
if
has_default
{
...
...
@@ -1552,7 +1552,7 @@ fn clean(&self, cx: &DocContext<'_>) -> GenericParamDef {
did
:
self
.def_id
,
bounds
:
vec!
[],
// These are filled in from the where-clauses.
default
,
synthetic
:
None
,
synthetic
,
})
}
ty
::
GenericParamDefKind
::
Const
{
..
}
=>
{
...
...
@@ -1641,7 +1641,7 @@ fn is_impl_trait(param: &hir::GenericParam) -> bool {
match
param
.kind
{
GenericParamDefKind
::
Lifetime
=>
unreachable!
(),
GenericParamDefKind
::
Type
{
did
,
ref
bounds
,
..
}
=>
{
cx
.impl_trait_bounds
.borrow_mut
()
.insert
(
did
,
bounds
.clone
());
cx
.impl_trait_bounds
.borrow_mut
()
.insert
(
did
.into
()
,
bounds
.clone
());
}
GenericParamDefKind
::
Const
{
..
}
=>
unreachable!
(),
}
...
...
@@ -1696,25 +1696,76 @@ fn clean(&self, cx: &DocContext<'_>) -> Generics {
let
(
gens
,
preds
)
=
*
self
;
// Don't populate `cx.impl_trait_bounds` before `clean`ning `where` clauses,
// since `Clean for ty::Predicate` would consume them.
let
mut
impl_trait
=
FxHashMap
::
<
ImplTraitParam
,
Vec
<
_
>>
::
default
();
// Bounds in the type_params and lifetimes fields are repeated in the
// predicates field (see rustc_typeck::collect::ty_generics), so remove
// them.
let
stripped_typarams
=
gens
.params
.iter
()
.filter_map
(|
param
|
match
param
.kind
{
ty
::
GenericParamDefKind
::
Lifetime
=>
None
,
ty
::
GenericParamDefKind
::
Type
{
..
}
=>
{
if
param
.name
.as_symbol
()
==
kw
::
SelfUpper
{
assert_eq!
(
param
.index
,
0
);
return
None
;
let
stripped_typarams
=
gens
.params
.iter
()
.filter_map
(|
param
|
match
param
.kind
{
ty
::
GenericParamDefKind
::
Lifetime
=>
None
,
ty
::
GenericParamDefKind
::
Type
{
synthetic
,
..
}
=>
{
if
param
.name
.as_symbol
()
==
kw
::
SelfUpper
{
assert_eq!
(
param
.index
,
0
);
return
None
;
}
if
synthetic
==
Some
(
hir
::
SyntheticTyParamKind
::
ImplTrait
)
{
impl_trait
.insert
(
param
.index
.into
(),
vec!
[]);
return
None
;
}
Some
(
param
.clean
(
cx
))
}
Some
(
param
.clean
(
cx
))
}
ty
::
GenericParamDefKind
::
Const
{
..
}
=>
None
,
})
.collect
::
<
Vec
<
GenericParamDef
>>
();
ty
::
GenericParamDefKind
::
Const
{
..
}
=>
None
,
})
.collect
::
<
Vec
<
GenericParamDef
>>
();
let
mut
where_predicates
=
preds
.predicates
.iter
()
.flat_map
(|(
p
,
_
)|
p
.clean
(
cx
))
.flat_map
(|(
p
,
_
)|
{
let
param_idx
=
if
let
Some
(
trait_ref
)
=
p
.to_opt_poly_trait_ref
()
{
if
let
ty
::
Param
(
param
)
=
trait_ref
.self_ty
()
.sty
{
Some
(
param
.index
)
}
else
{
None
}
}
else
if
let
Some
(
outlives
)
=
p
.to_opt_type_outlives
()
{
if
let
ty
::
Param
(
param
)
=
outlives
.skip_binder
()
.0
.sty
{
Some
(
param
.index
)
}
else
{
None
}
}
else
{
None
};
let
p
=
p
.clean
(
cx
)
?
;
if
let
Some
(
b
)
=
param_idx
.and_then
(|
i
|
impl_trait
.get_mut
(
&
i
.into
()))
{
b
.extend
(
p
.get_bounds
()
.into_iter
()
.flatten
()
.cloned
()
.filter
(|
b
|
!
b
.is_sized_bound
(
cx
))
);
return
None
;
}
Some
(
p
)
})
.collect
::
<
Vec
<
_
>>
();
// Move `TraitPredicate`s to the front.
for
(
_
,
bounds
)
in
impl_trait
.iter_mut
()
{
bounds
.sort_by_key
(|
b
|
if
let
GenericBound
::
TraitBound
(
..
)
=
b
{
false
}
else
{
true
});
}
cx
.impl_trait_bounds
.borrow_mut
()
.extend
(
impl_trait
);
// Type parameters and have a Sized bound by default unless removed with
// ?Sized. Scan through the predicates and mark any type parameter with
// a Sized bound, removing the bounds as we find them.
...
...
@@ -2791,7 +2842,7 @@ fn clean(&self, cx: &DocContext<'_>) -> Type {
if
let
Some
(
new_ty
)
=
cx
.ty_substs
.borrow
()
.get
(
&
did
)
.cloned
()
{
return
new_ty
;
}
if
let
Some
(
bounds
)
=
cx
.impl_trait_bounds
.borrow_mut
()
.remove
(
&
did
)
{
if
let
Some
(
bounds
)
=
cx
.impl_trait_bounds
.borrow_mut
()
.remove
(
&
did
.into
()
)
{
return
ImplTrait
(
bounds
);
}
}
...
...
@@ -3082,7 +3133,13 @@ fn clean(&self, cx: &DocContext<'_>) -> Type {
ty
::
Projection
(
ref
data
)
=>
data
.clean
(
cx
),
ty
::
Param
(
ref
p
)
=>
Generic
(
p
.name
.to_string
()),
ty
::
Param
(
ref
p
)
=>
{
if
let
Some
(
bounds
)
=
cx
.impl_trait_bounds
.borrow_mut
()
.remove
(
&
p
.index
.into
())
{
ImplTrait
(
bounds
)
}
else
{
Generic
(
p
.name
.to_string
())
}
}
ty
::
Opaque
(
def_id
,
substs
)
=>
{
// Grab the "TraitA + TraitB" from `impl TraitA + TraitB`,
...
...
src/librustdoc/core.rs
浏览文件 @
b78367d8
...
...
@@ -61,8 +61,8 @@ pub struct DocContext<'tcx> {
pub
lt_substs
:
RefCell
<
FxHashMap
<
DefId
,
clean
::
Lifetime
>>
,
/// Table `DefId` of const parameter -> substituted const
pub
ct_substs
:
RefCell
<
FxHashMap
<
DefId
,
clean
::
Constant
>>
,
/// Table
DefId of
`impl Trait` in argument position -> bounds
pub
impl_trait_bounds
:
RefCell
<
FxHashMap
<
DefId
,
Vec
<
clean
::
GenericBound
>>>
,
/// Table
synthetic type parameter for
`impl Trait` in argument position -> bounds
pub
impl_trait_bounds
:
RefCell
<
FxHashMap
<
ImplTraitParam
,
Vec
<
clean
::
GenericBound
>>>
,
pub
fake_def_ids
:
RefCell
<
FxHashMap
<
CrateNum
,
DefId
>>
,
pub
all_fake_def_ids
:
RefCell
<
FxHashSet
<
DefId
>>
,
/// Auto-trait or blanket impls processed so far, as `(self_ty, trait_def_id)`.
...
...
@@ -459,3 +459,23 @@ fn report_deprecated_attr(name: &str, diag: &errors::Handler) {
})
})
}
/// `DefId` or parameter index (`ty::ParamTy.index`) of a synthetic type parameter
/// for `impl Trait` in argument position.
#[derive(Clone,
Copy,
PartialEq,
Eq,
Hash)]
pub
enum
ImplTraitParam
{
DefId
(
DefId
),
ParamIndex
(
u32
),
}
impl
From
<
DefId
>
for
ImplTraitParam
{
fn
from
(
did
:
DefId
)
->
Self
{
ImplTraitParam
::
DefId
(
did
)
}
}
impl
From
<
u32
>
for
ImplTraitParam
{
fn
from
(
idx
:
u32
)
->
Self
{
ImplTraitParam
::
ParamIndex
(
idx
)
}
}
src/test/rustdoc/inline_cross/auxiliary/impl_trait_aux.rs
0 → 100644
浏览文件 @
b78367d8
pub
fn
func
<
'a
>
(
_
x
:
impl
Clone
+
Into
<
Vec
<
u8
>>
+
'a
)
{}
pub
struct
Foo
;
impl
Foo
{
pub
fn
method
<
'a
>
(
_
x
:
impl
Clone
+
Into
<
Vec
<
u8
>>
+
'a
)
{}
}
src/test/rustdoc/inline_cross/impl_trait.rs
0 → 100644
浏览文件 @
b78367d8
// aux-build:impl_trait_aux.rs
extern
crate
impl_trait_aux
;
// @has impl_trait/fn.func.html
// @has - '//pre[@class="rust fn"]' "pub fn func<'a>(_x: impl Clone + Into<Vec<u8>> + 'a)"
// @!has - '//pre[@class="rust fn"]' 'where'
pub
use
impl_trait_aux
::
func
;
// @has impl_trait/struct.Foo.html
// @has - '//code[@id="method.v"]' "pub fn method<'a>(_x: impl Clone + Into<Vec<u8>> + 'a)"
// @!has - '//code[@id="method.v"]' 'where'
pub
use
impl_trait_aux
::
Foo
;
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录