Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
int
Rust
提交
0528693f
R
Rust
项目概览
int
/
Rust
接近 1 年 前同步成功
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
Rust
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
0528693f
编写于
1月 07, 2018
作者:
E
Esteban Küber
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Account for `pub` in `const` -> `static` suggestion
上级
ee220dac
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
32 addition
and
1 deletion
+32
-1
src/librustc_lint/builtin.rs
src/librustc_lint/builtin.rs
+6
-1
src/test/ui/suggestions/issue-45562.rs
src/test/ui/suggestions/issue-45562.rs
+14
-0
src/test/ui/suggestions/issue-45562.stderr
src/test/ui/suggestions/issue-45562.stderr
+12
-0
未找到文件。
src/librustc_lint/builtin.rs
浏览文件 @
0528693f
...
...
@@ -1214,8 +1214,13 @@ fn check_item(&mut self, cx: &LateContext, it: &hir::Item) {
// don't have anything to attach a symbol to
let
msg
=
"const items should never be #[no_mangle]"
;
let
mut
err
=
cx
.struct_span_lint
(
NO_MANGLE_CONST_ITEMS
,
it
.span
,
msg
);
// account for "pub const" (#45562)
let
start
=
cx
.tcx.sess
.codemap
()
.span_to_snippet
(
it
.span
)
.map
(|
snippet
|
snippet
.find
(
"const"
)
.unwrap_or
(
0
))
.unwrap_or
(
0
)
as
u32
;
// `const` is 5 chars
let
const_span
=
it
.span
.with_hi
(
BytePos
(
it
.span
.lo
()
.0
+
5
));
let
const_span
=
it
.span
.with_hi
(
BytePos
(
it
.span
.lo
()
.0
+
start
+
5
));
err
.span_suggestion
(
const_span
,
"try a static value"
,
"pub static"
.to_owned
());
...
...
src/test/ui/suggestions/issue-45562.rs
0 → 100644
浏览文件 @
0528693f
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
#[no_mangle]
pub
const
RAH
:
usize
=
5
;
//~^ ERROR const items should never be #[no_mangle]
fn
main
()
{}
src/test/ui/suggestions/issue-45562.stderr
0 → 100644
浏览文件 @
0528693f
error: const items should never be #[no_mangle]
--> $DIR/issue-45562.rs:11:14
|
11 | #[no_mangle] pub const RAH: usize = 5;
| ---------^^^^^^^^^^^^^^^^
| |
| help: try a static value: `pub static`
|
= note: #[deny(no_mangle_const_items)] on by default
error: aborting due to previous error
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录