mod.rs 81.0 KB
Newer Older
1 2 3 4 5
pub mod on_unimplemented;
pub mod suggestions;

use super::{
    ConstEvalFailure, EvaluationResult, FulfillmentError, FulfillmentErrorCode,
C
Camille GILLOT 已提交
6 7 8
    MismatchedProjectionTypes, Obligation, ObligationCause, ObligationCauseCode,
    OnUnimplementedDirective, OnUnimplementedNote, OutputTypeParameterMismatch, Overflow,
    PredicateObligation, SelectionContext, SelectionError, TraitNotObjectSafe,
9 10 11 12
};

use crate::infer::error_reporting::{TyCategory, TypeAnnotationNeeded as ErrorCode};
use crate::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
C
Camille GILLOT 已提交
13
use crate::infer::{self, InferCtxt, TyCtxtInferExt};
14
use rustc_data_structures::fx::FxHashMap;
15
use rustc_errors::{pluralize, struct_span_err, Applicability, DiagnosticBuilder, ErrorReported};
16 17
use rustc_hir as hir;
use rustc_hir::def_id::{DefId, LOCAL_CRATE};
18
use rustc_hir::intravisit::Visitor;
19
use rustc_hir::Node;
M
Mazdak Farrokhzad 已提交
20 21 22 23
use rustc_middle::mir::interpret::ErrorHandled;
use rustc_middle::ty::error::ExpectedFound;
use rustc_middle::ty::fold::TypeFolder;
use rustc_middle::ty::{
24 25
    self, fast_reject, AdtKind, SubtypePredicate, ToPolyTraitRef, ToPredicate, Ty, TyCtxt,
    TypeFoldable, WithConstness,
26
};
27
use rustc_session::DiagnosticMessageId;
28
use rustc_span::symbol::{kw, sym};
29
use rustc_span::{ExpnKind, MultiSpan, Span, DUMMY_SP};
30 31
use std::fmt;

C
Camille GILLOT 已提交
32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68
use crate::traits::query::evaluate_obligation::InferCtxtExt as _;
use crate::traits::query::normalize::AtExt as _;
use on_unimplemented::InferCtxtExt as _;
use suggestions::InferCtxtExt as _;

pub use rustc_infer::traits::error_reporting::*;

pub trait InferCtxtExt<'tcx> {
    fn report_fulfillment_errors(
        &self,
        errors: &[FulfillmentError<'tcx>],
        body_id: Option<hir::BodyId>,
        fallback_has_occurred: bool,
    );

    fn report_overflow_error<T>(
        &self,
        obligation: &Obligation<'tcx, T>,
        suggest_increasing_limit: bool,
    ) -> !
    where
        T: fmt::Display + TypeFoldable<'tcx>;

    fn report_overflow_error_cycle(&self, cycle: &[PredicateObligation<'tcx>]) -> !;

    fn report_selection_error(
        &self,
        obligation: &PredicateObligation<'tcx>,
        error: &SelectionError<'tcx>,
        fallback_has_occurred: bool,
        points_at_arg: bool,
    );

    /// Given some node representing a fn-like thing in the HIR map,
    /// returns a span and `ArgKind` information that describes the
    /// arguments it expects. This can be supplied to
    /// `report_arg_count_mismatch`.
69
    fn get_fn_like_arguments(&self, node: Node<'_>) -> Option<(Span, Vec<ArgKind>)>;
C
Camille GILLOT 已提交
70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85

    /// Reports an error when the number of arguments needed by a
    /// trait match doesn't match the number that the expression
    /// provides.
    fn report_arg_count_mismatch(
        &self,
        span: Span,
        found_span: Option<Span>,
        expected_args: Vec<ArgKind>,
        found_args: Vec<ArgKind>,
        is_closure: bool,
    ) -> DiagnosticBuilder<'tcx>;
}

impl<'a, 'tcx> InferCtxtExt<'tcx> for InferCtxt<'a, 'tcx> {
    fn report_fulfillment_errors(
86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105
        &self,
        errors: &[FulfillmentError<'tcx>],
        body_id: Option<hir::BodyId>,
        fallback_has_occurred: bool,
    ) {
        #[derive(Debug)]
        struct ErrorDescriptor<'tcx> {
            predicate: ty::Predicate<'tcx>,
            index: Option<usize>, // None if this is an old error
        }

        let mut error_map: FxHashMap<_, Vec<_>> = self
            .reported_trait_errors
            .borrow()
            .iter()
            .map(|(&span, predicates)| {
                (
                    span,
                    predicates
                        .iter()
106
                        .map(|&predicate| ErrorDescriptor { predicate, index: None })
107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
                        .collect(),
                )
            })
            .collect();

        for (index, error) in errors.iter().enumerate() {
            // We want to ignore desugarings here: spans are equivalent even
            // if one is the result of a desugaring and the other is not.
            let mut span = error.obligation.cause.span;
            let expn_data = span.ctxt().outer_expn_data();
            if let ExpnKind::Desugaring(_) = expn_data.kind {
                span = expn_data.call_site;
            }

            error_map.entry(span).or_default().push(ErrorDescriptor {
122
                predicate: error.obligation.predicate,
123 124 125 126 127 128 129
                index: Some(index),
            });

            self.reported_trait_errors
                .borrow_mut()
                .entry(span)
                .or_default()
130
                .push(error.obligation.predicate);
131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150
        }

        // We do this in 2 passes because we want to display errors in order, though
        // maybe it *is* better to sort errors by span or something.
        let mut is_suppressed = vec![false; errors.len()];
        for (_, error_set) in error_map.iter() {
            // We want to suppress "duplicate" errors with the same span.
            for error in error_set {
                if let Some(index) = error.index {
                    // Suppress errors that are either:
                    // 1) strictly implied by another error.
                    // 2) implied by an error with a smaller index.
                    for error2 in error_set {
                        if error2.index.map_or(false, |index2| is_suppressed[index2]) {
                            // Avoid errors being suppressed by already-suppressed
                            // errors, to prevent all errors from being suppressed
                            // at once.
                            continue;
                        }

151
                        if self.error_implies(error2.predicate, error.predicate)
152
                            && !(error2.index >= error.index
153
                                && self.error_implies(error.predicate, error2.predicate))
154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170
                        {
                            info!("skipping {:?} (implied by {:?})", error, error2);
                            is_suppressed[index] = true;
                            break;
                        }
                    }
                }
            }
        }

        for (error, suppressed) in errors.iter().zip(is_suppressed) {
            if !suppressed {
                self.report_fulfillment_error(error, body_id, fallback_has_occurred);
            }
        }
    }

C
Camille GILLOT 已提交
171 172 173 174 175 176 177 178 179 180 181 182 183 184
    /// Reports that an overflow has occurred and halts compilation. We
    /// halt compilation unconditionally because it is important that
    /// overflows never be masked -- they basically represent computations
    /// whose result could not be truly determined and thus we can't say
    /// if the program type checks or not -- and they are unusual
    /// occurrences in any case.
    fn report_overflow_error<T>(
        &self,
        obligation: &Obligation<'tcx, T>,
        suggest_increasing_limit: bool,
    ) -> !
    where
        T: fmt::Display + TypeFoldable<'tcx>,
    {
B
Bastian Kauschke 已提交
185
        let predicate = self.resolve_vars_if_possible(obligation.predicate.clone());
C
Camille GILLOT 已提交
186 187 188 189 190 191 192
        let mut err = struct_span_err!(
            self.tcx.sess,
            obligation.cause.span,
            E0275,
            "overflow evaluating the requirement `{}`",
            predicate
        );
193

C
Camille GILLOT 已提交
194 195
        if suggest_increasing_limit {
            self.suggest_new_overflow_limit(&mut err);
196 197
        }

C
Camille GILLOT 已提交
198 199 200 201 202
        self.note_obligation_cause_code(
            &mut err,
            &obligation.predicate,
            &obligation.cause.code,
            &mut vec![],
203
            &mut Default::default(),
C
Camille GILLOT 已提交
204 205 206 207 208
        );

        err.emit();
        self.tcx.sess.abort_if_errors();
        bug!();
209 210
    }

C
Camille GILLOT 已提交
211 212 213 214 215 216
    /// Reports that a cycle was detected which led to overflow and halts
    /// compilation. This is equivalent to `report_overflow_error` except
    /// that we can give a more helpful error message (and, in particular,
    /// we do not suggest increasing the overflow limit, which is not
    /// going to help).
    fn report_overflow_error_cycle(&self, cycle: &[PredicateObligation<'tcx>]) -> ! {
B
Bastian Kauschke 已提交
217
        let cycle = self.resolve_vars_if_possible(cycle.to_owned());
C
Camille GILLOT 已提交
218 219 220 221 222
        assert!(!cycle.is_empty());

        debug!("report_overflow_error_cycle: cycle={:?}", cycle);

        self.report_overflow_error(&cycle[0], false);
223 224
    }

C
Camille GILLOT 已提交
225
    fn report_selection_error(
226 227
        &self,
        obligation: &PredicateObligation<'tcx>,
C
Camille GILLOT 已提交
228 229 230
        error: &SelectionError<'tcx>,
        fallback_has_occurred: bool,
        points_at_arg: bool,
231
    ) {
C
Camille GILLOT 已提交
232 233
        let tcx = self.tcx;
        let span = obligation.cause.span;
234

C
Camille GILLOT 已提交
235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
        let mut err = match *error {
            SelectionError::Unimplemented => {
                if let ObligationCauseCode::CompareImplMethodObligation {
                    item_name,
                    impl_item_def_id,
                    trait_item_def_id,
                }
                | ObligationCauseCode::CompareImplTypeObligation {
                    item_name,
                    impl_item_def_id,
                    trait_item_def_id,
                } = obligation.cause.code
                {
                    self.report_extra_impl_obligation(
                        span,
                        item_name,
                        impl_item_def_id,
                        trait_item_def_id,
                        &format!("`{}`", obligation.predicate),
                    )
                    .emit();
                    return;
                }
258

J
Jack Huey 已提交
259
                let bound_predicate = obligation.predicate.bound_atom();
260
                match bound_predicate.skip_binder() {
B
Bastian Kauschke 已提交
261
                    ty::PredicateAtom::Trait(trait_predicate, _) => {
J
Jack Huey 已提交
262
                        let trait_predicate = bound_predicate.rebind(trait_predicate);
B
Bastian Kauschke 已提交
263
                        let trait_predicate = self.resolve_vars_if_possible(trait_predicate);
264

C
Camille GILLOT 已提交
265 266 267 268 269 270 271 272 273 274 275 276 277 278
                        if self.tcx.sess.has_errors() && trait_predicate.references_error() {
                            return;
                        }
                        let trait_ref = trait_predicate.to_poly_trait_ref();
                        let (post_message, pre_message, type_def) = self
                            .get_parent_trait_ref(&obligation.cause.code)
                            .map(|(t, s)| {
                                (
                                    format!(" in `{}`", t),
                                    format!("within `{}`, ", t),
                                    s.map(|s| (format!("within this `{}`", t), s)),
                                )
                            })
                            .unwrap_or_default();
279

C
Camille GILLOT 已提交
280 281 282 283 284 285 286 287 288 289
                        let OnUnimplementedNote { message, label, note, enclosing_scope } =
                            self.on_unimplemented_note(trait_ref, obligation);
                        let have_alt_message = message.is_some() || label.is_some();
                        let is_try = self
                            .tcx
                            .sess
                            .source_map()
                            .span_to_snippet(span)
                            .map(|s| &s == "?")
                            .unwrap_or(false);
290 291
                        let is_from = self.tcx.get_diagnostic_item(sym::from_trait)
                            == Some(trait_ref.def_id());
292 293
                        let is_unsize =
                            { Some(trait_ref.def_id()) == self.tcx.lang_items().unsize_trait() };
C
Camille GILLOT 已提交
294 295 296 297
                        let (message, note) = if is_try && is_from {
                            (
                                Some(format!(
                                    "`?` couldn't convert the error to `{}`",
298
                                    trait_ref.skip_binder().self_ty(),
C
Camille GILLOT 已提交
299 300 301
                                )),
                                Some(
                                    "the question mark operation (`?`) implicitly performs a \
302
                                        conversion on the error value using the `From` trait"
C
Camille GILLOT 已提交
303 304 305 306 307 308
                                        .to_owned(),
                                ),
                            )
                        } else {
                            (message, note)
                        };
309

C
Camille GILLOT 已提交
310 311 312 313 314 315 316
                        let mut err = struct_span_err!(
                            self.tcx.sess,
                            span,
                            E0277,
                            "{}",
                            message.unwrap_or_else(|| format!(
                                "the trait bound `{}` is not satisfied{}",
317
                                trait_ref.without_const().to_predicate(tcx),
C
Camille GILLOT 已提交
318 319 320
                                post_message,
                            ))
                        );
321

322
                        if is_try && is_from {
323 324 325 326 327 328 329 330
                            let none_error = self
                                .tcx
                                .get_diagnostic_item(sym::none_error)
                                .map(|def_id| tcx.type_of(def_id));
                            let should_convert_option_to_result =
                                Some(trait_ref.skip_binder().substs.type_at(1)) == none_error;
                            let should_convert_result_to_option =
                                Some(trait_ref.self_ty().skip_binder()) == none_error;
331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350
                            if should_convert_option_to_result {
                                err.span_suggestion_verbose(
                                    span.shrink_to_lo(),
                                    "consider converting the `Option<T>` into a `Result<T, _>` \
                                     using `Option::ok_or` or `Option::ok_or_else`",
                                    ".ok_or_else(|| /* error value */)".to_string(),
                                    Applicability::HasPlaceholders,
                                );
                            } else if should_convert_result_to_option {
                                err.span_suggestion_verbose(
                                    span.shrink_to_lo(),
                                    "consider converting the `Result<T, _>` into an `Option<T>` \
                                     using `Result::ok`",
                                    ".ok()".to_string(),
                                    Applicability::MachineApplicable,
                                );
                            }
                            if let Some(ret_span) = self.return_type_span(obligation) {
                                err.span_label(
                                    ret_span,
351 352 353 354
                                    &format!(
                                        "expected `{}` because of this",
                                        trait_ref.skip_binder().self_ty()
                                    ),
355 356
                                );
                            }
357 358
                        }

C
Camille GILLOT 已提交
359 360 361 362 363 364 365 366
                        let explanation =
                            if obligation.cause.code == ObligationCauseCode::MainFunctionType {
                                "consider using `()`, or a `Result`".to_owned()
                            } else {
                                format!(
                                    "{}the trait `{}` is not implemented for `{}`",
                                    pre_message,
                                    trait_ref.print_only_trait_path(),
367
                                    trait_ref.skip_binder().self_ty(),
C
Camille GILLOT 已提交
368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385
                                )
                            };

                        if self.suggest_add_reference_to_arg(
                            &obligation,
                            &mut err,
                            &trait_ref,
                            points_at_arg,
                            have_alt_message,
                        ) {
                            self.note_obligation_cause(&mut err, obligation);
                            err.emit();
                            return;
                        }
                        if let Some(ref s) = label {
                            // If it has a custom `#[rustc_on_unimplemented]`
                            // error message, let's display it as the label!
                            err.span_label(span, s.as_str());
L
LeSeulArtichaut 已提交
386
                            if !matches!(trait_ref.skip_binder().self_ty().kind(), ty::Param(_)) {
387 388 389 390 391
                                // When the self type is a type param We don't need to "the trait
                                // `std::marker::Sized` is not implemented for `T`" as we will point
                                // at the type param with a label to suggest constraining it.
                                err.help(&explanation);
                            }
C
Camille GILLOT 已提交
392 393 394 395 396 397 398 399 400 401 402
                        } else {
                            err.span_label(span, explanation);
                        }
                        if let Some((msg, span)) = type_def {
                            err.span_label(span, &msg);
                        }
                        if let Some(ref s) = note {
                            // If it has a custom `#[rustc_on_unimplemented]` note, let's display it
                            err.note(s.as_str());
                        }
                        if let Some(ref s) = enclosing_scope {
A
Aaron Hill 已提交
403 404 405 406 407 408
                            let body = tcx
                                .hir()
                                .opt_local_def_id(obligation.cause.body_id)
                                .unwrap_or_else(|| {
                                    tcx.hir().body_owner_def_id(hir::BodyId {
                                        hir_id: obligation.cause.body_id,
409
                                    })
A
Aaron Hill 已提交
410 411 412 413
                                });

                            let enclosing_scope_span =
                                tcx.hir().span_with_body(tcx.hir().local_def_id_to_hir_id(body));
C
Camille GILLOT 已提交
414 415 416 417

                            err.span_label(enclosing_scope_span, s.as_str());
                        }

B
Bastian Kauschke 已提交
418 419 420 421
                        self.suggest_dereferences(&obligation, &mut err, trait_ref, points_at_arg);
                        self.suggest_fn_call(&obligation, &mut err, trait_ref, points_at_arg);
                        self.suggest_remove_reference(&obligation, &mut err, trait_ref);
                        self.suggest_semicolon_removal(&obligation, &mut err, span, trait_ref);
C
Camille GILLOT 已提交
422
                        self.note_version_mismatch(&mut err, &trait_ref);
C
csmoe 已提交
423 424

                        if Some(trait_ref.def_id()) == tcx.lang_items().try_trait() {
B
Bastian Kauschke 已提交
425
                            self.suggest_await_before_try(&mut err, &obligation, trait_ref, span);
C
csmoe 已提交
426 427
                        }

B
Bastian Kauschke 已提交
428
                        if self.suggest_impl_trait(&mut err, span, &obligation, trait_ref) {
C
Camille GILLOT 已提交
429 430 431 432
                            err.emit();
                            return;
                        }

433 434 435 436 437 438 439 440 441 442 443
                        if is_unsize {
                            // If the obligation failed due to a missing implementation of the
                            // `Unsize` trait, give a pointer to why that might be the case
                            err.note(
                                "all implementations of `Unsize` are provided \
                                automatically by the compiler, see \
                                <https://doc.rust-lang.org/stable/std/marker/trait.Unsize.html> \
                                for more information",
                            );
                        }

444 445 446 447 448 449
                        let is_fn_trait = [
                            self.tcx.lang_items().fn_trait(),
                            self.tcx.lang_items().fn_mut_trait(),
                            self.tcx.lang_items().fn_once_trait(),
                        ]
                        .contains(&Some(trait_ref.def_id()));
L
LeSeulArtichaut 已提交
450 451 452 453 454 455 456
                        let is_target_feature_fn = if let ty::FnDef(def_id, _) =
                            *trait_ref.skip_binder().self_ty().kind()
                        {
                            !self.tcx.codegen_fn_attrs(def_id).target_features.is_empty()
                        } else {
                            false
                        };
457
                        if is_fn_trait && is_target_feature_fn {
458 459 460
                            err.note(
                                "`#[target_feature]` functions do not implement the `Fn` traits",
                            );
461 462
                        }

C
Camille GILLOT 已提交
463 464 465 466 467 468 469 470 471 472 473 474 475
                        // Try to report a help message
                        if !trait_ref.has_infer_types_or_consts()
                            && self.predicate_can_apply(obligation.param_env, trait_ref)
                        {
                            // If a where-clause may be useful, remind the
                            // user that they can add it.
                            //
                            // don't display an on-unimplemented note, as
                            // these notes will often be of the form
                            //     "the type `T` can't be frobnicated"
                            // which is somewhat confusing.
                            self.suggest_restricting_param_bound(
                                &mut err,
E
Esteban Küber 已提交
476
                                trait_ref,
C
Camille GILLOT 已提交
477 478 479 480 481 482 483 484
                                obligation.cause.body_id,
                            );
                        } else {
                            if !have_alt_message {
                                // Can't show anything else useful, try to find similar impls.
                                let impl_candidates = self.find_similar_impl_candidates(trait_ref);
                                self.report_similar_impl_candidates(impl_candidates, &mut err);
                            }
485 486 487 488 489 490
                            // Changing mutability doesn't make a difference to whether we have
                            // an `Unsize` impl (Fixes ICE in #71036)
                            if !is_unsize {
                                self.suggest_change_mut(
                                    &obligation,
                                    &mut err,
B
Bastian Kauschke 已提交
491
                                    trait_ref,
492 493 494
                                    points_at_arg,
                                );
                            }
C
Camille GILLOT 已提交
495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510
                        }

                        // If this error is due to `!: Trait` not implemented but `(): Trait` is
                        // implemented, and fallback has occurred, then it could be due to a
                        // variable that used to fallback to `()` now falling back to `!`. Issue a
                        // note informing about the change in behaviour.
                        if trait_predicate.skip_binder().self_ty().is_never()
                            && fallback_has_occurred
                        {
                            let predicate = trait_predicate.map_bound(|mut trait_pred| {
                                trait_pred.trait_ref.substs = self.tcx.mk_substs_trait(
                                    self.tcx.mk_unit(),
                                    &trait_pred.trait_ref.substs[1..],
                                );
                                trait_pred
                            });
511 512
                            let unit_obligation =
                                obligation.with(predicate.without_const().to_predicate(tcx));
C
Camille GILLOT 已提交
513 514 515 516 517 518 519 520 521 522 523 524 525 526 527
                            if self.predicate_may_hold(&unit_obligation) {
                                err.note(
                                    "the trait is implemented for `()`. \
                                     Possibly this error has been caused by changes to \
                                     Rust's type-inference algorithm (see issue #48950 \
                                     <https://github.com/rust-lang/rust/issues/48950> \
                                     for more information). Consider whether you meant to use \
                                     the type `()` here instead.",
                                );
                            }
                        }

                        err
                    }

B
Bastian Kauschke 已提交
528
                    ty::PredicateAtom::Subtype(predicate) => {
C
Camille GILLOT 已提交
529 530 531 532 533 534
                        // Errors for Subtype predicates show up as
                        // `FulfillmentErrorCode::CodeSubtypeError`,
                        // not selection error.
                        span_bug!(span, "subtype requirement gave wrong error: `{:?}`", predicate)
                    }

B
Bastian Kauschke 已提交
535
                    ty::PredicateAtom::RegionOutlives(predicate) => {
J
Jack Huey 已提交
536
                        let predicate = bound_predicate.rebind(predicate);
B
Bastian Kauschke 已提交
537
                        let predicate = self.resolve_vars_if_possible(predicate);
C
Camille GILLOT 已提交
538
                        let err = self
539
                            .region_outlives_predicate(&obligation.cause, predicate)
C
Camille GILLOT 已提交
540 541 542 543 544 545 546 547 548 549 550 551
                            .err()
                            .unwrap();
                        struct_span_err!(
                            self.tcx.sess,
                            span,
                            E0279,
                            "the requirement `{}` is not satisfied (`{}`)",
                            predicate,
                            err,
                        )
                    }

B
Bastian Kauschke 已提交
552
                    ty::PredicateAtom::Projection(..) | ty::PredicateAtom::TypeOutlives(..) => {
B
Bastian Kauschke 已提交
553
                        let predicate = self.resolve_vars_if_possible(obligation.predicate);
C
Camille GILLOT 已提交
554 555 556 557 558 559 560 561 562
                        struct_span_err!(
                            self.tcx.sess,
                            span,
                            E0280,
                            "the requirement `{}` is not satisfied",
                            predicate
                        )
                    }

B
Bastian Kauschke 已提交
563
                    ty::PredicateAtom::ObjectSafe(trait_def_id) => {
C
Camille GILLOT 已提交
564 565 566 567
                        let violations = self.tcx.object_safety_violations(trait_def_id);
                        report_object_safety_error(self.tcx, span, trait_def_id, violations)
                    }

B
Bastian Kauschke 已提交
568
                    ty::PredicateAtom::ClosureKind(closure_def_id, closure_substs, kind) => {
569
                        let found_kind = self.closure_kind(closure_substs).unwrap();
570 571 572 573
                        let closure_span =
                            self.tcx.sess.source_map().guess_head_span(
                                self.tcx.hir().span_if_local(closure_def_id).unwrap(),
                            );
574 575
                        let hir_id =
                            self.tcx.hir().local_def_id_to_hir_id(closure_def_id.expect_local());
C
Camille GILLOT 已提交
576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596
                        let mut err = struct_span_err!(
                            self.tcx.sess,
                            closure_span,
                            E0525,
                            "expected a closure that implements the `{}` trait, \
                             but this closure only implements `{}`",
                            kind,
                            found_kind
                        );

                        err.span_label(
                            closure_span,
                            format!("this closure implements `{}`, not `{}`", found_kind, kind),
                        );
                        err.span_label(
                            obligation.cause.span,
                            format!("the requirement to implement `{}` derives from here", kind),
                        );

                        // Additional context information explaining why the closure only implements
                        // a particular trait.
597 598 599
                        if let Some(typeck_results) = self.in_progress_typeck_results {
                            let typeck_results = typeck_results.borrow();
                            match (found_kind, typeck_results.closure_kind_origins().get(hir_id)) {
C
Camille GILLOT 已提交
600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627
                                (ty::ClosureKind::FnOnce, Some((span, name))) => {
                                    err.span_label(
                                        *span,
                                        format!(
                                            "closure is `FnOnce` because it moves the \
                                         variable `{}` out of its environment",
                                            name
                                        ),
                                    );
                                }
                                (ty::ClosureKind::FnMut, Some((span, name))) => {
                                    err.span_label(
                                        *span,
                                        format!(
                                            "closure is `FnMut` because it mutates the \
                                         variable `{}` here",
                                            name
                                        ),
                                    );
                                }
                                _ => {}
                            }
                        }

                        err.emit();
                        return;
                    }

B
Bastian Kauschke 已提交
628
                    ty::PredicateAtom::WellFormed(ty) => {
J
Jack Huey 已提交
629 630 631 632 633 634 635 636 637 638 639 640 641 642 643
                        if !self.tcx.sess.opts.debugging_opts.chalk {
                            // WF predicates cannot themselves make
                            // errors. They can only block due to
                            // ambiguity; otherwise, they always
                            // degenerate into other obligations
                            // (which may fail).
                            span_bug!(span, "WF predicate not satisfied for {:?}", ty);
                        } else {
                            // FIXME: we'll need a better message which takes into account
                            // which bounds actually failed to hold.
                            self.tcx.sess.struct_span_err(
                                span,
                                &format!("the type `{}` is not well-formed (chalk)", ty),
                            )
                        }
C
Camille GILLOT 已提交
644 645
                    }

B
Bastian Kauschke 已提交
646
                    ty::PredicateAtom::ConstEvaluatable(..) => {
C
Camille GILLOT 已提交
647 648 649 650 651 652 653 654 655
                        // Errors for `ConstEvaluatable` predicates show up as
                        // `SelectionError::ConstEvalFailure`,
                        // not `Unimplemented`.
                        span_bug!(
                            span,
                            "const-evaluatable requirement gave wrong error: `{:?}`",
                            obligation
                        )
                    }
656

B
Bastian Kauschke 已提交
657
                    ty::PredicateAtom::ConstEquate(..) => {
658 659 660 661 662 663 664 665 666
                        // Errors for `ConstEquate` predicates show up as
                        // `SelectionError::ConstEvalFailure`,
                        // not `Unimplemented`.
                        span_bug!(
                            span,
                            "const-equate requirement gave wrong error: `{:?}`",
                            obligation
                        )
                    }
667 668 669 670 671

                    ty::PredicateAtom::TypeWellFormedFromEnv(..) => span_bug!(
                        span,
                        "TypeWellFormedFromEnv predicate should only exist in the environment"
                    ),
C
Camille GILLOT 已提交
672 673 674
                }
            }

L
words  
lcnr 已提交
675 676 677
            OutputTypeParameterMismatch(found_trait_ref, expected_trait_ref, _) => {
                let found_trait_ref = self.resolve_vars_if_possible(found_trait_ref);
                let expected_trait_ref = self.resolve_vars_if_possible(expected_trait_ref);
C
Camille GILLOT 已提交
678 679 680 681 682

                if expected_trait_ref.self_ty().references_error() {
                    return;
                }

683 684 685 686
                let found_trait_ty = match found_trait_ref.self_ty().no_bound_vars() {
                    Some(ty) => ty,
                    None => return,
                };
C
Camille GILLOT 已提交
687

L
LeSeulArtichaut 已提交
688
                let found_did = match *found_trait_ty.kind() {
C
Camille GILLOT 已提交
689 690 691
                    ty::Closure(did, _) | ty::Foreign(did) | ty::FnDef(did, _) => Some(did),
                    ty::Adt(def, _) => Some(def.did),
                    _ => None,
692 693
                };

C
Camille GILLOT 已提交
694 695
                let found_span = found_did
                    .and_then(|did| self.tcx.hir().span_if_local(did))
696
                    .map(|sp| self.tcx.sess.source_map().guess_head_span(sp)); // the sp could be an fn def
697

C
Camille GILLOT 已提交
698 699 700 701 702 703 704 705
                if self.reported_closure_mismatch.borrow().contains(&(span, found_span)) {
                    // We check closures twice, with obligations flowing in different directions,
                    // but we want to complain about them only once.
                    return;
                }

                self.reported_closure_mismatch.borrow_mut().insert((span, found_span));

L
LeSeulArtichaut 已提交
706
                let found = match found_trait_ref.skip_binder().substs.type_at(1).kind() {
C
Camille GILLOT 已提交
707 708 709 710 711
                    ty::Tuple(ref tys) => vec![ArgKind::empty(); tys.len()],
                    _ => vec![ArgKind::empty()],
                };

                let expected_ty = expected_trait_ref.skip_binder().substs.type_at(1);
L
LeSeulArtichaut 已提交
712
                let expected = match expected_ty.kind() {
C
Camille GILLOT 已提交
713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728
                    ty::Tuple(ref tys) => tys
                        .iter()
                        .map(|t| ArgKind::from_expected_ty(t.expect_ty(), Some(span)))
                        .collect(),
                    _ => vec![ArgKind::Arg("_".to_owned(), expected_ty.to_string())],
                };

                if found.len() == expected.len() {
                    self.report_closure_arg_mismatch(
                        span,
                        found_span,
                        found_trait_ref,
                        expected_trait_ref,
                    )
                } else {
                    let (closure_span, found) = found_did
729 730 731 732
                        .and_then(|did| {
                            let node = self.tcx.hir().get_if_local(did)?;
                            let (found_span, found) = self.get_fn_like_arguments(node)?;
                            Some((Some(found_span), found))
C
Camille GILLOT 已提交
733 734 735 736 737 738 739 740 741 742
                        })
                        .unwrap_or((found_span, found));

                    self.report_arg_count_mismatch(
                        span,
                        closure_span,
                        expected,
                        found,
                        found_trait_ty.is_closure(),
                    )
743 744 745
                }
            }

C
Camille GILLOT 已提交
746 747 748 749 750
            TraitNotObjectSafe(did) => {
                let violations = self.tcx.object_safety_violations(did);
                report_object_safety_error(self.tcx, span, did, violations)
            }
            ConstEvalFailure(ErrorHandled::TooGeneric) => {
751
                bug!("too generic should have been handled in `is_const_evaluatable`");
752
            }
C
Camille GILLOT 已提交
753
            // Already reported in the query.
754 755 756 757 758 759 760 761 762 763 764
            ConstEvalFailure(ErrorHandled::Reported(ErrorReported)) => {
                // FIXME(eddyb) remove this once `ErrorReported` becomes a proof token.
                self.tcx.sess.delay_span_bug(span, "`ErrorReported` without an error");
                return;
            }

            // Already reported in the query, but only as a lint.
            // This shouldn't actually happen for constants used in types, modulo
            // bugs. The `delay_span_bug` here ensures it won't be ignored.
            ConstEvalFailure(ErrorHandled::Linted) => {
                self.tcx.sess.delay_span_bug(span, "constant in type had error reported as lint");
C
Camille GILLOT 已提交
765
                return;
766 767
            }

C
Camille GILLOT 已提交
768 769 770 771
            Overflow => {
                bug!("overflow should be handled before the `report_selection_error` path");
            }
        };
772

C
Camille GILLOT 已提交
773 774
        self.note_obligation_cause(&mut err, obligation);
        self.point_at_returns_when_relevant(&mut err, &obligation);
775

C
Camille GILLOT 已提交
776 777
        err.emit();
    }
778

C
Camille GILLOT 已提交
779 780 781 782
    /// Given some node representing a fn-like thing in the HIR map,
    /// returns a span and `ArgKind` information that describes the
    /// arguments it expects. This can be supplied to
    /// `report_arg_count_mismatch`.
783 784 785 786
    fn get_fn_like_arguments(&self, node: Node<'_>) -> Option<(Span, Vec<ArgKind>)> {
        let sm = self.tcx.sess.source_map();
        let hir = self.tcx.hir();
        Some(match node {
C
Camille GILLOT 已提交
787 788 789 790
            Node::Expr(&hir::Expr {
                kind: hir::ExprKind::Closure(_, ref _decl, id, span, _),
                ..
            }) => (
791 792
                sm.guess_head_span(span),
                hir.body(id)
C
Camille GILLOT 已提交
793 794 795 796 797 798
                    .params
                    .iter()
                    .map(|arg| {
                        if let hir::Pat { kind: hir::PatKind::Tuple(ref args, _), span, .. } =
                            *arg.pat
                        {
799
                            Some(ArgKind::Tuple(
C
Camille GILLOT 已提交
800 801 802
                                Some(span),
                                args.iter()
                                    .map(|pat| {
803 804 805
                                        sm.span_to_snippet(pat.span)
                                            .ok()
                                            .map(|snippet| (snippet, "_".to_owned()))
C
Camille GILLOT 已提交
806
                                    })
807 808
                                    .collect::<Option<Vec<_>>>()?,
                            ))
C
Camille GILLOT 已提交
809
                        } else {
810 811
                            let name = sm.span_to_snippet(arg.pat.span).ok()?;
                            Some(ArgKind::Arg(name, "_".to_owned()))
812
                        }
C
Camille GILLOT 已提交
813
                    })
814
                    .collect::<Option<Vec<ArgKind>>>()?,
C
Camille GILLOT 已提交
815 816 817 818
            ),
            Node::Item(&hir::Item { span, kind: hir::ItemKind::Fn(ref sig, ..), .. })
            | Node::ImplItem(&hir::ImplItem {
                span,
M
Mark Mansi 已提交
819
                kind: hir::ImplItemKind::Fn(ref sig, _),
C
Camille GILLOT 已提交
820 821 822 823 824 825 826
                ..
            })
            | Node::TraitItem(&hir::TraitItem {
                span,
                kind: hir::TraitItemKind::Fn(ref sig, _),
                ..
            }) => (
827
                sm.guess_head_span(span),
C
Camille GILLOT 已提交
828 829 830 831 832 833 834 835 836 837 838 839 840
                sig.decl
                    .inputs
                    .iter()
                    .map(|arg| match arg.clone().kind {
                        hir::TyKind::Tup(ref tys) => ArgKind::Tuple(
                            Some(arg.span),
                            vec![("_".to_owned(), "_".to_owned()); tys.len()],
                        ),
                        _ => ArgKind::empty(),
                    })
                    .collect::<Vec<ArgKind>>(),
            ),
            Node::Ctor(ref variant_data) => {
841 842
                let span = variant_data.ctor_hir_id().map(|id| hir.span(id)).unwrap_or(DUMMY_SP);
                let span = sm.guess_head_span(span);
C
Camille GILLOT 已提交
843
                (span, vec![ArgKind::empty(); variant_data.fields().len()])
844
            }
C
Camille GILLOT 已提交
845
            _ => panic!("non-FnLike node found: {:?}", node),
846
        })
847 848
    }

C
Camille GILLOT 已提交
849 850 851 852
    /// Reports an error when the number of arguments needed by a
    /// trait match doesn't match the number that the expression
    /// provides.
    fn report_arg_count_mismatch(
853
        &self,
C
Camille GILLOT 已提交
854 855 856 857 858 859 860
        span: Span,
        found_span: Option<Span>,
        expected_args: Vec<ArgKind>,
        found_args: Vec<ArgKind>,
        is_closure: bool,
    ) -> DiagnosticBuilder<'tcx> {
        let kind = if is_closure { "closure" } else { "function" };
861

C
Camille GILLOT 已提交
862 863
        let args_str = |arguments: &[ArgKind], other: &[ArgKind]| {
            let arg_length = arguments.len();
864
            let distinct = matches!(other, &[ArgKind::Tuple(..)]);
C
Camille GILLOT 已提交
865 866 867
            match (arg_length, arguments.get(0)) {
                (1, Some(&ArgKind::Tuple(_, ref fields))) => {
                    format!("a single {}-tuple as argument", fields.len())
868
                }
C
Camille GILLOT 已提交
869 870 871 872 873 874 875
                _ => format!(
                    "{} {}argument{}",
                    arg_length,
                    if distinct && arg_length > 1 { "distinct " } else { "" },
                    pluralize!(arg_length)
                ),
            }
876 877
        };

C
Camille GILLOT 已提交
878 879
        let expected_str = args_str(&expected_args, &found_args);
        let found_str = args_str(&found_args, &expected_args);
880 881 882

        let mut err = struct_span_err!(
            self.tcx.sess,
C
Camille GILLOT 已提交
883 884 885 886 887 888
            span,
            E0593,
            "{} is expected to take {}, but it takes {}",
            kind,
            expected_str,
            found_str,
889 890
        );

C
Camille GILLOT 已提交
891
        err.span_label(span, format!("expected {} that takes {}", kind, expected_str));
892

C
Camille GILLOT 已提交
893 894
        if let Some(found_span) = found_span {
            err.span_label(found_span, format!("takes {}", found_str));
895

C
Camille GILLOT 已提交
896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911
            // move |_| { ... }
            // ^^^^^^^^-- def_span
            //
            // move |_| { ... }
            // ^^^^^-- prefix
            let prefix_span = self.tcx.sess.source_map().span_until_non_whitespace(found_span);
            // move |_| { ... }
            //      ^^^-- pipe_span
            let pipe_span =
                if let Some(span) = found_span.trim_start(prefix_span) { span } else { found_span };

            // Suggest to take and ignore the arguments with expected_args_length `_`s if
            // found arguments is empty (assume the user just wants to ignore args in this case).
            // For example, if `expected_args_length` is 2, suggest `|_, _|`.
            if found_args.is_empty() && is_closure {
                let underscores = vec!["_"; expected_args.len()].join(", ");
912
                err.span_suggestion_verbose(
C
Camille GILLOT 已提交
913 914 915
                    pipe_span,
                    &format!(
                        "consider changing the closure to take and ignore the expected argument{}",
916
                        pluralize!(expected_args.len())
C
Camille GILLOT 已提交
917 918 919 920 921
                    ),
                    format!("|{}|", underscores),
                    Applicability::MachineApplicable,
                );
            }
922

C
Camille GILLOT 已提交
923 924 925 926 927 928 929
            if let &[ArgKind::Tuple(_, ref fields)] = &found_args[..] {
                if fields.len() == expected_args.len() {
                    let sugg = fields
                        .iter()
                        .map(|(name, _)| name.to_owned())
                        .collect::<Vec<String>>()
                        .join(", ");
930
                    err.span_suggestion_verbose(
C
Camille GILLOT 已提交
931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966
                        found_span,
                        "change the closure to take multiple arguments instead of a single tuple",
                        format!("|{}|", sugg),
                        Applicability::MachineApplicable,
                    );
                }
            }
            if let &[ArgKind::Tuple(_, ref fields)] = &expected_args[..] {
                if fields.len() == found_args.len() && is_closure {
                    let sugg = format!(
                        "|({}){}|",
                        found_args
                            .iter()
                            .map(|arg| match arg {
                                ArgKind::Arg(name, _) => name.to_owned(),
                                _ => "_".to_owned(),
                            })
                            .collect::<Vec<String>>()
                            .join(", "),
                        // add type annotations if available
                        if found_args.iter().any(|arg| match arg {
                            ArgKind::Arg(_, ty) => ty != "_",
                            _ => false,
                        }) {
                            format!(
                                ": ({})",
                                fields
                                    .iter()
                                    .map(|(_, ty)| ty.to_owned())
                                    .collect::<Vec<String>>()
                                    .join(", ")
                            )
                        } else {
                            String::new()
                        },
                    );
967
                    err.span_suggestion_verbose(
C
Camille GILLOT 已提交
968 969 970 971 972 973 974 975
                        found_span,
                        "change the closure to accept a tuple instead of individual arguments",
                        sugg,
                        Applicability::MachineApplicable,
                    );
                }
            }
        }
976

C
Camille GILLOT 已提交
977
        err
978
    }
C
Camille GILLOT 已提交
979 980 981 982 983
}

trait InferCtxtPrivExt<'tcx> {
    // returns if `cond` not occurring implies that `error` does not occur - i.e., that
    // `error` occurring implies that `cond` occurs.
984
    fn error_implies(&self, cond: ty::Predicate<'tcx>, error: ty::Predicate<'tcx>) -> bool;
985

C
Camille GILLOT 已提交
986
    fn report_fulfillment_error(
987
        &self,
C
Camille GILLOT 已提交
988 989 990 991
        error: &FulfillmentError<'tcx>,
        body_id: Option<hir::BodyId>,
        fallback_has_occurred: bool,
    );
992

C
Camille GILLOT 已提交
993 994 995 996 997
    fn report_projection_error(
        &self,
        obligation: &PredicateObligation<'tcx>,
        error: &MismatchedProjectionTypes<'tcx>,
    );
998

C
Camille GILLOT 已提交
999
    fn fuzzy_match_tys(&self, a: Ty<'tcx>, b: Ty<'tcx>) -> bool;
1000

C
Camille GILLOT 已提交
1001
    fn describe_generator(&self, body_id: hir::BodyId) -> Option<&'static str>;
1002

C
Camille GILLOT 已提交
1003 1004 1005 1006 1007 1008 1009 1010 1011 1012
    fn find_similar_impl_candidates(
        &self,
        trait_ref: ty::PolyTraitRef<'tcx>,
    ) -> Vec<ty::TraitRef<'tcx>>;

    fn report_similar_impl_candidates(
        &self,
        impl_candidates: Vec<ty::TraitRef<'tcx>>,
        err: &mut DiagnosticBuilder<'_>,
    );
1013 1014 1015 1016 1017

    /// Gets the parent trait chain start
    fn get_parent_trait_ref(
        &self,
        code: &ObligationCauseCode<'tcx>,
C
Camille GILLOT 已提交
1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
    ) -> Option<(String, Option<Span>)>;

    /// If the `Self` type of the unsatisfied trait `trait_ref` implements a trait
    /// with the same path as `trait_ref`, a help message about
    /// a probable version mismatch is added to `err`
    fn note_version_mismatch(
        &self,
        err: &mut DiagnosticBuilder<'_>,
        trait_ref: &ty::PolyTraitRef<'tcx>,
    );

1029 1030 1031 1032
    /// Creates a `PredicateObligation` with `new_self_ty` replacing the existing type in the
    /// `trait_ref`.
    ///
    /// For this to work, `new_self_ty` must have no escaping bound variables.
1033
    fn mk_trait_obligation_with_new_self_ty(
C
Camille GILLOT 已提交
1034 1035
        &self,
        param_env: ty::ParamEnv<'tcx>,
B
Bastian Kauschke 已提交
1036
        trait_ref: ty::PolyTraitRef<'tcx>,
1037
        new_self_ty: Ty<'tcx>,
C
Camille GILLOT 已提交
1038
    ) -> PredicateObligation<'tcx>;
1039

C
Camille GILLOT 已提交
1040
    fn maybe_report_ambiguity(
1041 1042
        &self,
        obligation: &PredicateObligation<'tcx>,
C
Camille GILLOT 已提交
1043 1044
        body_id: Option<hir::BodyId>,
    );
1045

C
Camille GILLOT 已提交
1046 1047 1048 1049 1050
    fn predicate_can_apply(
        &self,
        param_env: ty::ParamEnv<'tcx>,
        pred: ty::PolyTraitRef<'tcx>,
    ) -> bool;
1051

C
Camille GILLOT 已提交
1052 1053
    fn note_obligation_cause(
        &self,
1054
        err: &mut DiagnosticBuilder<'tcx>,
C
Camille GILLOT 已提交
1055 1056
        obligation: &PredicateObligation<'tcx>,
    );
1057

C
Camille GILLOT 已提交
1058 1059
    fn suggest_unsized_bound_if_applicable(
        &self,
1060
        err: &mut DiagnosticBuilder<'tcx>,
C
Camille GILLOT 已提交
1061 1062
        obligation: &PredicateObligation<'tcx>,
    );
1063

C
Camille GILLOT 已提交
1064 1065 1066 1067 1068 1069
    fn is_recursive_obligation(
        &self,
        obligated_types: &mut Vec<&ty::TyS<'tcx>>,
        cause_code: &ObligationCauseCode<'tcx>,
    ) -> bool;
}
1070

C
Camille GILLOT 已提交
1071 1072 1073
impl<'a, 'tcx> InferCtxtPrivExt<'tcx> for InferCtxt<'a, 'tcx> {
    // returns if `cond` not occurring implies that `error` does not occur - i.e., that
    // `error` occurring implies that `cond` occurs.
1074
    fn error_implies(&self, cond: ty::Predicate<'tcx>, error: ty::Predicate<'tcx>) -> bool {
C
Camille GILLOT 已提交
1075 1076 1077
        if cond == error {
            return true;
        }
1078

1079
        // FIXME: It should be possible to deal with `ForAll` in a cleaner way.
J
Jack Huey 已提交
1080
        let bound_error = error.bound_atom();
1081
        let (cond, error) = match (cond.skip_binders(), bound_error.skip_binder()) {
B
Bastian Kauschke 已提交
1082
            (ty::PredicateAtom::Trait(..), ty::PredicateAtom::Trait(error, _)) => {
J
Jack Huey 已提交
1083
                (cond, bound_error.rebind(error))
1084
            }
C
Camille GILLOT 已提交
1085 1086 1087 1088 1089
            _ => {
                // FIXME: make this work in other cases too.
                return false;
            }
        };
1090

1091
        for obligation in super::elaborate_predicates(self.tcx, std::iter::once(cond)) {
J
Jack Huey 已提交
1092
            let bound_predicate = obligation.predicate.bound_atom();
1093
            if let ty::PredicateAtom::Trait(implication, _) = bound_predicate.skip_binder() {
C
Camille GILLOT 已提交
1094
                let error = error.to_poly_trait_ref();
J
Jack Huey 已提交
1095
                let implication = bound_predicate.rebind(implication.trait_ref);
C
Camille GILLOT 已提交
1096 1097 1098 1099 1100 1101 1102 1103 1104 1105
                // FIXME: I'm just not taking associated types at all here.
                // Eventually I'll need to implement param-env-aware
                // `Γ₁ ⊦ φ₁ => Γ₂ ⊦ φ₂` logic.
                let param_env = ty::ParamEnv::empty();
                if self.can_sub(param_env, error, implication).is_ok() {
                    debug!("error_implies: {:?} -> {:?} -> {:?}", cond, error, implication);
                    return true;
                }
            }
        }
1106

C
Camille GILLOT 已提交
1107 1108
        false
    }
1109

C
Camille GILLOT 已提交
1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140
    fn report_fulfillment_error(
        &self,
        error: &FulfillmentError<'tcx>,
        body_id: Option<hir::BodyId>,
        fallback_has_occurred: bool,
    ) {
        debug!("report_fulfillment_error({:?})", error);
        match error.code {
            FulfillmentErrorCode::CodeSelectionError(ref selection_error) => {
                self.report_selection_error(
                    &error.obligation,
                    selection_error,
                    fallback_has_occurred,
                    error.points_at_arg_span,
                );
            }
            FulfillmentErrorCode::CodeProjectionError(ref e) => {
                self.report_projection_error(&error.obligation, e);
            }
            FulfillmentErrorCode::CodeAmbiguity => {
                self.maybe_report_ambiguity(&error.obligation, body_id);
            }
            FulfillmentErrorCode::CodeSubtypeError(ref expected_found, ref err) => {
                self.report_mismatched_types(
                    &error.obligation.cause,
                    expected_found.expected,
                    expected_found.found,
                    err.clone(),
                )
                .emit();
            }
1141 1142 1143 1144 1145 1146 1147 1148 1149
            FulfillmentErrorCode::CodeConstEquateError(ref expected_found, ref err) => {
                self.report_mismatched_consts(
                    &error.obligation.cause,
                    expected_found.expected,
                    expected_found.found,
                    err.clone(),
                )
                .emit();
            }
C
Camille GILLOT 已提交
1150 1151
        }
    }
1152

C
Camille GILLOT 已提交
1153 1154 1155 1156 1157
    fn report_projection_error(
        &self,
        obligation: &PredicateObligation<'tcx>,
        error: &MismatchedProjectionTypes<'tcx>,
    ) {
B
Bastian Kauschke 已提交
1158
        let predicate = self.resolve_vars_if_possible(obligation.predicate);
1159

C
Camille GILLOT 已提交
1160 1161 1162
        if predicate.references_error() {
            return;
        }
1163

C
Camille GILLOT 已提交
1164 1165 1166 1167
        self.probe(|_| {
            let err_buf;
            let mut err = &error.err;
            let mut values = None;
1168

C
Camille GILLOT 已提交
1169 1170 1171 1172
            // try to find the mismatched types to report the error with.
            //
            // this can fail if the problem was higher-ranked, in which
            // cause I have no idea for a good error message.
J
Jack Huey 已提交
1173
            let bound_predicate = predicate.bound_atom();
1174
            if let ty::PredicateAtom::Projection(data) = bound_predicate.skip_binder() {
C
Camille GILLOT 已提交
1175 1176 1177 1178
                let mut selcx = SelectionContext::new(self);
                let (data, _) = self.replace_bound_vars_with_fresh_vars(
                    obligation.cause.span,
                    infer::LateBoundRegionConversionTime::HigherRankedType,
B
Bastian Kauschke 已提交
1179
                    bound_predicate.rebind(data),
C
Camille GILLOT 已提交
1180 1181 1182 1183 1184 1185 1186 1187 1188 1189
                );
                let mut obligations = vec![];
                let normalized_ty = super::normalize_projection_type(
                    &mut selcx,
                    obligation.param_env,
                    data.projection_ty,
                    obligation.cause.clone(),
                    0,
                    &mut obligations,
                );
1190

C
Camille GILLOT 已提交
1191 1192 1193 1194
                debug!(
                    "report_projection_error obligation.cause={:?} obligation.param_env={:?}",
                    obligation.cause, obligation.param_env
                );
1195

C
Camille GILLOT 已提交
1196 1197 1198 1199
                debug!(
                    "report_projection_error normalized_ty={:?} data.ty={:?}",
                    normalized_ty, data.ty
                );
1200

1201
                let is_normalized_ty_expected = !matches!(obligation.cause.code, ObligationCauseCode::ItemObligation(_)
C
Camille GILLOT 已提交
1202
                    | ObligationCauseCode::BindingObligation(_, _)
1203
                    | ObligationCauseCode::ObjectCastObligation(_));
1204

C
Camille GILLOT 已提交
1205 1206 1207 1208 1209 1210 1211 1212 1213 1214
                if let Err(error) = self.at(&obligation.cause, obligation.param_env).eq_exp(
                    is_normalized_ty_expected,
                    normalized_ty,
                    data.ty,
                ) {
                    values = Some(infer::ValuePairs::Types(ExpectedFound::new(
                        is_normalized_ty_expected,
                        normalized_ty,
                        data.ty,
                    )));
1215

C
Camille GILLOT 已提交
1216 1217
                    err_buf = error;
                    err = &err_buf;
1218 1219 1220
                }
            }

C
Camille GILLOT 已提交
1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237
            let msg = format!("type mismatch resolving `{}`", predicate);
            let error_id = (DiagnosticMessageId::ErrorId(271), Some(obligation.cause.span), msg);
            let fresh = self.tcx.sess.one_time_diagnostics.borrow_mut().insert(error_id);
            if fresh {
                let mut diag = struct_span_err!(
                    self.tcx.sess,
                    obligation.cause.span,
                    E0271,
                    "type mismatch resolving `{}`",
                    predicate
                );
                self.note_type_err(&mut diag, &obligation.cause, None, values, err);
                self.note_obligation_cause(&mut diag, obligation);
                diag.emit();
            }
        });
    }
1238

C
Camille GILLOT 已提交
1239 1240 1241 1242
    fn fuzzy_match_tys(&self, a: Ty<'tcx>, b: Ty<'tcx>) -> bool {
        /// returns the fuzzy category of a given type, or None
        /// if the type can be equated to any type.
        fn type_category(t: Ty<'_>) -> Option<u32> {
L
LeSeulArtichaut 已提交
1243
            match t.kind() {
C
Camille GILLOT 已提交
1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266
                ty::Bool => Some(0),
                ty::Char => Some(1),
                ty::Str => Some(2),
                ty::Int(..) | ty::Uint(..) | ty::Infer(ty::IntVar(..)) => Some(3),
                ty::Float(..) | ty::Infer(ty::FloatVar(..)) => Some(4),
                ty::Ref(..) | ty::RawPtr(..) => Some(5),
                ty::Array(..) | ty::Slice(..) => Some(6),
                ty::FnDef(..) | ty::FnPtr(..) => Some(7),
                ty::Dynamic(..) => Some(8),
                ty::Closure(..) => Some(9),
                ty::Tuple(..) => Some(10),
                ty::Projection(..) => Some(11),
                ty::Param(..) => Some(12),
                ty::Opaque(..) => Some(13),
                ty::Never => Some(14),
                ty::Adt(adt, ..) => match adt.adt_kind() {
                    AdtKind::Struct => Some(15),
                    AdtKind::Union => Some(16),
                    AdtKind::Enum => Some(17),
                },
                ty::Generator(..) => Some(18),
                ty::Foreign(..) => Some(19),
                ty::GeneratorWitness(..) => Some(20),
1267
                ty::Placeholder(..) | ty::Bound(..) | ty::Infer(..) | ty::Error(_) => None,
C
Camille GILLOT 已提交
1268 1269
            }
        }
1270

C
Camille GILLOT 已提交
1271
        match (type_category(a), type_category(b)) {
L
LeSeulArtichaut 已提交
1272
            (Some(cat_a), Some(cat_b)) => match (a.kind(), b.kind()) {
C
Camille GILLOT 已提交
1273 1274 1275 1276 1277 1278 1279
                (&ty::Adt(def_a, _), &ty::Adt(def_b, _)) => def_a == def_b,
                _ => cat_a == cat_b,
            },
            // infer and error can be equated to all types
            _ => true,
        }
    }
1280

C
Camille GILLOT 已提交
1281 1282 1283 1284 1285 1286 1287 1288
    fn describe_generator(&self, body_id: hir::BodyId) -> Option<&'static str> {
        self.tcx.hir().body(body_id).generator_kind.map(|gen_kind| match gen_kind {
            hir::GeneratorKind::Gen => "a generator",
            hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Block) => "an async block",
            hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Fn) => "an async function",
            hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Closure) => "an async closure",
        })
    }
1289

C
Camille GILLOT 已提交
1290 1291 1292 1293 1294 1295
    fn find_similar_impl_candidates(
        &self,
        trait_ref: ty::PolyTraitRef<'tcx>,
    ) -> Vec<ty::TraitRef<'tcx>> {
        let simp = fast_reject::simplify_type(self.tcx, trait_ref.skip_binder().self_ty(), true);
        let all_impls = self.tcx.all_impls(trait_ref.def_id());
1296

C
Camille GILLOT 已提交
1297 1298
        match simp {
            Some(simp) => all_impls
1299
                .filter_map(|def_id| {
C
Camille GILLOT 已提交
1300 1301 1302 1303 1304 1305 1306
                    let imp = self.tcx.impl_trait_ref(def_id).unwrap();
                    let imp_simp = fast_reject::simplify_type(self.tcx, imp.self_ty(), true);
                    if let Some(imp_simp) = imp_simp {
                        if simp != imp_simp {
                            return None;
                        }
                    }
1307 1308 1309
                    if self.tcx.impl_polarity(def_id) == ty::ImplPolarity::Negative {
                        return None;
                    }
C
Camille GILLOT 已提交
1310 1311 1312
                    Some(imp)
                })
                .collect(),
1313 1314 1315 1316 1317 1318 1319 1320
            None => all_impls
                .filter_map(|def_id| {
                    if self.tcx.impl_polarity(def_id) == ty::ImplPolarity::Negative {
                        return None;
                    }
                    self.tcx.impl_trait_ref(def_id)
                })
                .collect(),
C
Camille GILLOT 已提交
1321 1322
        }
    }
1323

C
Camille GILLOT 已提交
1324 1325 1326 1327 1328 1329 1330 1331
    fn report_similar_impl_candidates(
        &self,
        impl_candidates: Vec<ty::TraitRef<'tcx>>,
        err: &mut DiagnosticBuilder<'_>,
    ) {
        if impl_candidates.is_empty() {
            return;
        }
1332

C
Camille GILLOT 已提交
1333 1334
        let len = impl_candidates.len();
        let end = if impl_candidates.len() <= 5 { impl_candidates.len() } else { 4 };
1335

C
Camille GILLOT 已提交
1336 1337 1338 1339 1340 1341 1342
        let normalize = |candidate| {
            self.tcx.infer_ctxt().enter(|ref infcx| {
                let normalized = infcx
                    .at(&ObligationCause::dummy(), ty::ParamEnv::empty())
                    .normalize(candidate)
                    .ok();
                match normalized {
1343 1344
                    Some(normalized) => format!("\n  {}", normalized.value),
                    None => format!("\n  {}", candidate),
1345
                }
C
Camille GILLOT 已提交
1346 1347
            })
        };
1348

C
Camille GILLOT 已提交
1349 1350
        // Sort impl candidates so that ordering is consistent for UI tests.
        let mut normalized_impl_candidates =
B
Bastian Kauschke 已提交
1351
            impl_candidates.iter().copied().map(normalize).collect::<Vec<String>>();
1352

C
Camille GILLOT 已提交
1353 1354 1355 1356
        // Sort before taking the `..end` range,
        // because the ordering of `impl_candidates` may not be deterministic:
        // https://github.com/rust-lang/rust/pull/57475#issuecomment-455519507
        normalized_impl_candidates.sort();
1357

C
Camille GILLOT 已提交
1358 1359 1360 1361 1362 1363
        err.help(&format!(
            "the following implementations were found:{}{}",
            normalized_impl_candidates[..end].join(""),
            if len > 5 { format!("\nand {} others", len - 4) } else { String::new() }
        ));
    }
1364

C
Camille GILLOT 已提交
1365 1366 1367 1368 1369 1370 1371
    /// Gets the parent trait chain start
    fn get_parent_trait_ref(
        &self,
        code: &ObligationCauseCode<'tcx>,
    ) -> Option<(String, Option<Span>)> {
        match code {
            &ObligationCauseCode::BuiltinDerivedObligation(ref data) => {
B
Bastian Kauschke 已提交
1372
                let parent_trait_ref = self.resolve_vars_if_possible(data.parent_trait_ref);
C
Camille GILLOT 已提交
1373 1374 1375 1376 1377 1378 1379 1380 1381
                match self.get_parent_trait_ref(&data.parent_code) {
                    Some(t) => Some(t),
                    None => {
                        let ty = parent_trait_ref.skip_binder().self_ty();
                        let span =
                            TyCategory::from_ty(ty).map(|(_, def_id)| self.tcx.def_span(def_id));
                        Some((ty.to_string(), span))
                    }
                }
1382
            }
C
Camille GILLOT 已提交
1383 1384
            _ => None,
        }
1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395
    }

    /// If the `Self` type of the unsatisfied trait `trait_ref` implements a trait
    /// with the same path as `trait_ref`, a help message about
    /// a probable version mismatch is added to `err`
    fn note_version_mismatch(
        &self,
        err: &mut DiagnosticBuilder<'_>,
        trait_ref: &ty::PolyTraitRef<'tcx>,
    ) {
        let get_trait_impl = |trait_def_id| {
1396
            self.tcx.find_map_relevant_impl(trait_def_id, trait_ref.skip_binder().self_ty(), Some)
1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418
        };
        let required_trait_path = self.tcx.def_path_str(trait_ref.def_id());
        let all_traits = self.tcx.all_traits(LOCAL_CRATE);
        let traits_with_same_path: std::collections::BTreeSet<_> = all_traits
            .iter()
            .filter(|trait_def_id| **trait_def_id != trait_ref.def_id())
            .filter(|trait_def_id| self.tcx.def_path_str(**trait_def_id) == required_trait_path)
            .collect();
        for trait_with_same_path in traits_with_same_path {
            if let Some(impl_def_id) = get_trait_impl(*trait_with_same_path) {
                let impl_span = self.tcx.def_span(impl_def_id);
                err.span_help(impl_span, "trait impl with same name found");
                let trait_crate = self.tcx.crate_name(trait_with_same_path.krate);
                let crate_msg = format!(
                    "perhaps two different versions of crate `{}` are being used?",
                    trait_crate
                );
                err.note(&crate_msg);
            }
        }
    }

1419
    fn mk_trait_obligation_with_new_self_ty(
1420 1421
        &self,
        param_env: ty::ParamEnv<'tcx>,
B
Bastian Kauschke 已提交
1422
        trait_ref: ty::PolyTraitRef<'tcx>,
1423
        new_self_ty: Ty<'tcx>,
1424
    ) -> PredicateObligation<'tcx> {
1425 1426
        assert!(!new_self_ty.has_escaping_bound_vars());

1427 1428 1429 1430 1431 1432 1433 1434 1435 1436
        let trait_ref = trait_ref.map_bound_ref(|tr| ty::TraitRef {
            substs: self.tcx.mk_substs_trait(new_self_ty, &tr.substs[1..]),
            ..*tr
        });

        Obligation::new(
            ObligationCause::dummy(),
            param_env,
            trait_ref.without_const().to_predicate(self.tcx),
        )
1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448
    }

    fn maybe_report_ambiguity(
        &self,
        obligation: &PredicateObligation<'tcx>,
        body_id: Option<hir::BodyId>,
    ) {
        // Unable to successfully determine, probably means
        // insufficient type information, but could mean
        // ambiguous impls. The latter *ought* to be a
        // coherence violation, so we don't report it here.

B
Bastian Kauschke 已提交
1449
        let predicate = self.resolve_vars_if_possible(obligation.predicate);
1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462
        let span = obligation.cause.span;

        debug!(
            "maybe_report_ambiguity(predicate={:?}, obligation={:?} body_id={:?}, code={:?})",
            predicate, obligation, body_id, obligation.cause.code,
        );

        // Ambiguity errors are often caused as fallout from earlier
        // errors. So just ignore them if this infcx is tainted.
        if self.is_tainted_by_errors() {
            return;
        }

J
Jack Huey 已提交
1463
        let bound_predicate = predicate.bound_atom();
1464
        let mut err = match bound_predicate.skip_binder() {
B
Bastian Kauschke 已提交
1465
            ty::PredicateAtom::Trait(data, _) => {
J
Jack Huey 已提交
1466
                let trait_ref = bound_predicate.rebind(data.trait_ref);
1467
                debug!("trait_ref {:?}", trait_ref);
1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481

                if predicate.references_error() {
                    return;
                }
                // Typically, this ambiguity should only happen if
                // there are unresolved type inference variables
                // (otherwise it would suggest a coherence
                // failure). But given #21974 that is not necessarily
                // the case -- we can have multiple where clauses that
                // are only distinguished by a region, which results
                // in an ambiguity even when all types are fully
                // known, since we don't dispatch based on region
                // relationships.

1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492
                // Pick the first substitution that still contains inference variables as the one
                // we're going to emit an error for. If there are none (see above), fall back to
                // the substitution for `Self`.
                let subst = {
                    let substs = data.trait_ref.substs;
                    substs
                        .iter()
                        .find(|s| s.has_infer_types_or_consts())
                        .unwrap_or_else(|| substs[0])
                };

1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505
                // This is kind of a hack: it frequently happens that some earlier
                // error prevents types from being fully inferred, and then we get
                // a bunch of uninteresting errors saying something like "<generic
                // #0> doesn't implement Sized".  It may even be true that we
                // could just skip over all checks where the self-ty is an
                // inference variable, but I was afraid that there might be an
                // inference variable created, registered as an obligation, and
                // then never forced by writeback, and hence by skipping here we'd
                // be ignoring the fact that we don't KNOW the type works
                // out. Though even that would probably be harmless, given that
                // we're only talking about builtin traits, which are known to be
                // inhabited. We used to check for `self.tcx.sess.has_errors()` to
                // avoid inundating the user with unnecessary errors, but we now
M
Matthias Krüger 已提交
1506
                // check upstream for type errors and don't add the obligations to
1507
                // begin with in those cases.
1508
                if self.tcx.lang_items().sized_trait() == Some(trait_ref.def_id()) {
1509
                    self.emit_inference_failure_err(body_id, span, subst, ErrorCode::E0282).emit();
1510 1511
                    return;
                }
1512 1513
                let mut err =
                    self.emit_inference_failure_err(body_id, span, subst, ErrorCode::E0283);
1514
                err.note(&format!("cannot satisfy `{}`", predicate));
1515 1516 1517 1518 1519 1520 1521 1522 1523
                if let ObligationCauseCode::ItemObligation(def_id) = obligation.cause.code {
                    self.suggest_fully_qualified_path(&mut err, def_id, span, trait_ref.def_id());
                } else if let (
                    Ok(ref snippet),
                    ObligationCauseCode::BindingObligation(ref def_id, _),
                ) =
                    (self.tcx.sess.source_map().span_to_snippet(span), &obligation.cause.code)
                {
                    let generics = self.tcx.generics_of(*def_id);
1524
                    if generics.params.iter().any(|p| p.name != kw::SelfUpper)
1525 1526
                        && !snippet.ends_with('>')
                    {
1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543
                        // FIXME: To avoid spurious suggestions in functions where type arguments
                        // where already supplied, we check the snippet to make sure it doesn't
                        // end with a turbofish. Ideally we would have access to a `PathSegment`
                        // instead. Otherwise we would produce the following output:
                        //
                        // error[E0283]: type annotations needed
                        //   --> $DIR/issue-54954.rs:3:24
                        //    |
                        // LL | const ARR_LEN: usize = Tt::const_val::<[i8; 123]>();
                        //    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^
                        //    |                        |
                        //    |                        cannot infer type
                        //    |                        help: consider specifying the type argument
                        //    |                        in the function call:
                        //    |                        `Tt::const_val::<[i8; 123]>::<T>`
                        // ...
                        // LL |     const fn const_val<T: Sized>() -> usize {
1544
                        //    |                        - required by this bound in `Tt::const_val`
1545
                        //    |
1546
                        //    = note: cannot satisfy `_: Tt`
1547

1548 1549
                        err.span_suggestion_verbose(
                            span.shrink_to_hi(),
1550 1551
                            &format!(
                                "consider specifying the type argument{} in the function call",
1552
                                pluralize!(generics.params.len()),
1553 1554
                            ),
                            format!(
1555
                                "::<{}>",
1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569
                                generics
                                    .params
                                    .iter()
                                    .map(|p| p.name.to_string())
                                    .collect::<Vec<String>>()
                                    .join(", ")
                            ),
                            Applicability::HasPlaceholders,
                        );
                    }
                }
                err
            }

B
Bastian Kauschke 已提交
1570
            ty::PredicateAtom::WellFormed(arg) => {
1571 1572
                // Same hacky approach as above to avoid deluging user
                // with error messages.
1573
                if arg.references_error() || self.tcx.sess.has_errors() {
1574 1575 1576
                    return;
                }

B
Bastian Kauschke 已提交
1577
                self.emit_inference_failure_err(body_id, span, arg, ErrorCode::E0282)
B
Bastian Kauschke 已提交
1578 1579
            }

B
Bastian Kauschke 已提交
1580
            ty::PredicateAtom::Subtype(data) => {
1581 1582 1583 1584
                if data.references_error() || self.tcx.sess.has_errors() {
                    // no need to overload user in such cases
                    return;
                }
B
Bastian Kauschke 已提交
1585
                let SubtypePredicate { a_is_expected: _, a, b } = data;
1586 1587
                // both must be type variables, or the other would've been instantiated
                assert!(a.is_ty_var() && b.is_ty_var());
B
Bastian Kauschke 已提交
1588
                self.emit_inference_failure_err(body_id, span, a.into(), ErrorCode::E0282)
1589
            }
B
Bastian Kauschke 已提交
1590
            ty::PredicateAtom::Projection(data) => {
J
Jack Huey 已提交
1591
                let trait_ref = bound_predicate.rebind(data).to_poly_trait_ref(self.tcx);
1592
                let self_ty = trait_ref.skip_binder().self_ty();
1593
                let ty = data.ty;
1594 1595 1596
                if predicate.references_error() {
                    return;
                }
1597 1598
                if self_ty.needs_infer() && ty.needs_infer() {
                    // We do this for the `foo.collect()?` case to produce a suggestion.
B
Bastian Kauschke 已提交
1599 1600 1601 1602 1603 1604
                    let mut err = self.emit_inference_failure_err(
                        body_id,
                        span,
                        self_ty.into(),
                        ErrorCode::E0284,
                    );
1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617
                    err.note(&format!("cannot satisfy `{}`", predicate));
                    err
                } else {
                    let mut err = struct_span_err!(
                        self.tcx.sess,
                        span,
                        E0284,
                        "type annotations needed: cannot satisfy `{}`",
                        predicate,
                    );
                    err.span_label(span, &format!("cannot satisfy `{}`", predicate));
                    err
                }
1618 1619 1620 1621 1622 1623 1624 1625 1626 1627
            }

            _ => {
                if self.tcx.sess.has_errors() {
                    return;
                }
                let mut err = struct_span_err!(
                    self.tcx.sess,
                    span,
                    E0284,
1628
                    "type annotations needed: cannot satisfy `{}`",
1629 1630
                    predicate,
                );
1631
                err.span_label(span, &format!("cannot satisfy `{}`", predicate));
1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656
                err
            }
        };
        self.note_obligation_cause(&mut err, obligation);
        err.emit();
    }

    /// Returns `true` if the trait predicate may apply for *some* assignment
    /// to the type parameters.
    fn predicate_can_apply(
        &self,
        param_env: ty::ParamEnv<'tcx>,
        pred: ty::PolyTraitRef<'tcx>,
    ) -> bool {
        struct ParamToVarFolder<'a, 'tcx> {
            infcx: &'a InferCtxt<'a, 'tcx>,
            var_map: FxHashMap<Ty<'tcx>, Ty<'tcx>>,
        }

        impl<'a, 'tcx> TypeFolder<'tcx> for ParamToVarFolder<'a, 'tcx> {
            fn tcx<'b>(&'b self) -> TyCtxt<'tcx> {
                self.infcx.tcx
            }

            fn fold_ty(&mut self, ty: Ty<'tcx>) -> Ty<'tcx> {
L
LeSeulArtichaut 已提交
1657
                if let ty::Param(ty::ParamTy { name, .. }) = *ty.kind() {
1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
                    let infcx = self.infcx;
                    self.var_map.entry(ty).or_insert_with(|| {
                        infcx.next_ty_var(TypeVariableOrigin {
                            kind: TypeVariableOriginKind::TypeParameterDefinition(name, None),
                            span: DUMMY_SP,
                        })
                    })
                } else {
                    ty.super_fold_with(self)
                }
            }
        }

        self.probe(|_| {
            let mut selcx = SelectionContext::new(self);

            let cleaned_pred =
                pred.fold_with(&mut ParamToVarFolder { infcx: self, var_map: Default::default() });

            let cleaned_pred = super::project::normalize(
                &mut selcx,
                param_env,
                ObligationCause::dummy(),
B
Bastian Kauschke 已提交
1681
                cleaned_pred,
1682 1683 1684
            )
            .value;

1685 1686 1687
            let obligation = Obligation::new(
                ObligationCause::dummy(),
                param_env,
1688
                cleaned_pred.without_const().to_predicate(selcx.tcx()),
1689
            );
1690 1691 1692 1693 1694 1695 1696

            self.predicate_may_hold(&obligation)
        })
    }

    fn note_obligation_cause(
        &self,
1697
        err: &mut DiagnosticBuilder<'tcx>,
1698 1699 1700 1701 1702 1703 1704 1705 1706 1707
        obligation: &PredicateObligation<'tcx>,
    ) {
        // First, attempt to add note to this error with an async-await-specific
        // message, and fall back to regular note otherwise.
        if !self.maybe_note_obligation_cause_for_async_await(err, obligation) {
            self.note_obligation_cause_code(
                err,
                &obligation.predicate,
                &obligation.cause.code,
                &mut vec![],
1708
                &mut Default::default(),
1709
            );
1710 1711 1712 1713 1714 1715
            self.suggest_unsized_bound_if_applicable(err, obligation);
        }
    }

    fn suggest_unsized_bound_if_applicable(
        &self,
1716
        err: &mut DiagnosticBuilder<'tcx>,
1717 1718
        obligation: &PredicateObligation<'tcx>,
    ) {
B
Bastian Kauschke 已提交
1719 1720 1721 1722 1723 1724 1725 1726
        let (pred, item_def_id, span) =
            match (obligation.predicate.skip_binders(), obligation.cause.code.peel_derives()) {
                (
                    ty::PredicateAtom::Trait(pred, _),
                    &ObligationCauseCode::BindingObligation(item_def_id, span),
                ) => (pred, item_def_id, span),
                _ => return,
            };
1727 1728

        let node = match (
1729
            self.tcx.hir().get_if_local(item_def_id),
1730 1731 1732 1733 1734 1735 1736 1737 1738 1739
            Some(pred.def_id()) == self.tcx.lang_items().sized_trait(),
        ) {
            (Some(node), true) => node,
            _ => return,
        };
        let generics = match node.generics() {
            Some(generics) => generics,
            None => return,
        };
        for param in generics.params {
1740
            if param.span != span
1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762
                || param.bounds.iter().any(|bound| {
                    bound.trait_ref().and_then(|trait_ref| trait_ref.trait_def_id())
                        == self.tcx.lang_items().sized_trait()
                })
            {
                continue;
            }
            match node {
                hir::Node::Item(
                    item
                    @
                    hir::Item {
                        kind:
                            hir::ItemKind::Enum(..)
                            | hir::ItemKind::Struct(..)
                            | hir::ItemKind::Union(..),
                        ..
                    },
                ) => {
                    // Suggesting `T: ?Sized` is only valid in an ADT if `T` is only used in a
                    // borrow. `struct S<'a, T: ?Sized>(&'a T);` is valid, `struct S<T: ?Sized>(T);`
                    // is not.
1763 1764 1765 1766 1767
                    let mut visitor = FindTypeParam {
                        param: param.name.ident().name,
                        invalid_spans: vec![],
                        nested: false,
                    };
1768
                    visitor.visit_item(item);
1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790
                    if !visitor.invalid_spans.is_empty() {
                        let mut multispan: MultiSpan = param.span.into();
                        multispan.push_span_label(
                            param.span,
                            format!("this could be changed to `{}: ?Sized`...", param.name.ident()),
                        );
                        for sp in visitor.invalid_spans {
                            multispan.push_span_label(
                                sp,
                                format!(
                                    "...if indirection was used here: `Box<{}>`",
                                    param.name.ident(),
                                ),
                            );
                        }
                        err.span_help(
                            multispan,
                            &format!(
                                "you could relax the implicit `Sized` bound on `{T}` if it were \
                                 used through indirection like `&{T}` or `Box<{T}>`",
                                T = param.name.ident(),
                            ),
1791 1792 1793 1794
                        );
                        return;
                    }
                }
1795
                _ => {}
1796
            }
1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807
            let (span, separator) = match param.bounds {
                [] => (span.shrink_to_hi(), ":"),
                [.., bound] => (bound.span().shrink_to_hi(), " +"),
            };
            err.span_suggestion_verbose(
                span,
                "consider relaxing the implicit `Sized` restriction",
                format!("{} ?Sized", separator),
                Applicability::MachineApplicable,
            );
            return;
1808 1809 1810 1811 1812 1813 1814 1815 1816
        }
    }

    fn is_recursive_obligation(
        &self,
        obligated_types: &mut Vec<&ty::TyS<'tcx>>,
        cause_code: &ObligationCauseCode<'tcx>,
    ) -> bool {
        if let ObligationCauseCode::BuiltinDerivedObligation(ref data) = cause_code {
B
Bastian Kauschke 已提交
1817
            let parent_trait_ref = self.resolve_vars_if_possible(data.parent_trait_ref);
1818 1819 1820 1821 1822 1823 1824 1825 1826

            if obligated_types.iter().any(|ot| ot == &parent_trait_ref.skip_binder().self_ty()) {
                return true;
            }
        }
        false
    }
}

1827 1828 1829 1830
/// Look for type `param` in an ADT being used only through a reference to confirm that suggesting
/// `param: ?Sized` would be a valid constraint.
struct FindTypeParam {
    param: rustc_span::Symbol,
1831 1832
    invalid_spans: Vec<Span>,
    nested: bool,
1833 1834 1835 1836 1837 1838 1839 1840 1841 1842
}

impl<'v> Visitor<'v> for FindTypeParam {
    type Map = rustc_hir::intravisit::ErasedMap<'v>;

    fn nested_visit_map(&mut self) -> hir::intravisit::NestedVisitorMap<Self::Map> {
        hir::intravisit::NestedVisitorMap::None
    }

    fn visit_ty(&mut self, ty: &hir::Ty<'_>) {
E
Esteban Küber 已提交
1843 1844 1845 1846 1847 1848
        // We collect the spans of all uses of the "bare" type param, like in `field: T` or
        // `field: (T, T)` where we could make `T: ?Sized` while skipping cases that are known to be
        // valid like `field: &'a T` or `field: *mut T` and cases that *might* have further `Sized`
        // obligations like `Box<T>` and `Vec<T>`, but we perform no extra analysis for those cases
        // and suggest `T: ?Sized` regardless of their obligations. This is fine because the errors
        // in that case should make what happened clear enough.
1849
        match ty.kind {
1850
            hir::TyKind::Ptr(_) | hir::TyKind::Rptr(..) | hir::TyKind::TraitObject(..) => {}
1851 1852 1853
            hir::TyKind::Path(hir::QPath::Resolved(None, path))
                if path.segments.len() == 1 && path.segments[0].ident.name == self.param =>
            {
1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865
                if !self.nested {
                    self.invalid_spans.push(ty.span);
                }
            }
            hir::TyKind::Path(_) => {
                let prev = self.nested;
                self.nested = true;
                hir::intravisit::walk_ty(self, ty);
                self.nested = prev;
            }
            _ => {
                hir::intravisit::walk_ty(self, ty);
1866 1867 1868 1869 1870
            }
        }
    }
}

C
Camille GILLOT 已提交
1871 1872 1873
pub fn recursive_type_with_infinite_size_error(
    tcx: TyCtxt<'tcx>,
    type_def_id: DefId,
1874 1875
    spans: Vec<Span>,
) {
C
Camille GILLOT 已提交
1876 1877
    assert!(type_def_id.is_local());
    let span = tcx.hir().span_if_local(type_def_id).unwrap();
1878
    let span = tcx.sess.source_map().guess_head_span(span);
1879 1880 1881
    let path = tcx.def_path_str(type_def_id);
    let mut err =
        struct_span_err!(tcx.sess, span, E0072, "recursive type `{}` has infinite size", path);
C
Camille GILLOT 已提交
1882
    err.span_label(span, "recursive type has infinite size");
1883 1884 1885 1886 1887 1888 1889
    for &span in &spans {
        err.span_label(span, "recursive without indirection");
    }
    let msg = format!(
        "insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `{}` representable",
        path,
    );
1890 1891 1892 1893 1894 1895
    if spans.len() <= 4 {
        err.multipart_suggestion(
            &msg,
            spans
                .iter()
                .flat_map(|&span| {
1896 1897 1898
                    vec![
                        (span.shrink_to_lo(), "Box<".to_string()),
                        (span.shrink_to_hi(), ">".to_string()),
1899 1900 1901 1902 1903 1904 1905 1906
                    ]
                    .into_iter()
                })
                .collect(),
            Applicability::HasPlaceholders,
        );
    } else {
        err.help(&msg);
1907 1908
    }
    err.emit();
C
Camille GILLOT 已提交
1909 1910
}

1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931
/// Summarizes information
#[derive(Clone)]
pub enum ArgKind {
    /// An argument of non-tuple type. Parameters are (name, ty)
    Arg(String, String),

    /// An argument of tuple type. For a "found" argument, the span is
    /// the locationo in the source of the pattern. For a "expected"
    /// argument, it will be None. The vector is a list of (name, ty)
    /// strings for the components of the tuple.
    Tuple(Option<Span>, Vec<(String, String)>),
}

impl ArgKind {
    fn empty() -> ArgKind {
        ArgKind::Arg("_".to_owned(), "_".to_owned())
    }

    /// Creates an `ArgKind` from the expected type of an
    /// argument. It has no name (`_`) and an optional source span.
    pub fn from_expected_ty(t: Ty<'_>, span: Option<Span>) -> ArgKind {
L
LeSeulArtichaut 已提交
1932 1933
        match t.kind() {
            ty::Tuple(tys) => ArgKind::Tuple(
1934 1935 1936 1937 1938 1939 1940
                span,
                tys.iter().map(|ty| ("_".to_owned(), ty.to_string())).collect::<Vec<_>>(),
            ),
            _ => ArgKind::Arg("_".to_owned(), t.to_string()),
        }
    }
}