exit.rs 1.8 KB
Newer Older
H
Heinz N. Gies 已提交
1
use crate::utils::{is_entrypoint_fn, match_def_path, paths, qpath_res, span_lint};
H
Heinz N. Gies 已提交
2
use if_chain::if_chain;
M
Matthias Krüger 已提交
3
use rustc::declare_lint_pass;
H
Heinz N. Gies 已提交
4
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
Y
Yuki Okushi 已提交
5
use rustc_hir::{Expr, ExprKind, Item, ItemKind, Node};
M
Matthias Krüger 已提交
6
use rustc_session::declare_tool_lint;
H
Heinz N. Gies 已提交
7 8 9 10 11 12 13 14

declare_clippy_lint! {
    /// **What it does:** `exit()`  terminates the program and doesn't provide a
    /// stack trace.
    ///
    /// **Why is this bad?** Ideally a program is terminated by finishing
    /// the main function.
    ///
H
Heinz N. Gies 已提交
15
    /// **Known problems:** None.
H
Heinz N. Gies 已提交
16 17 18 19 20 21 22 23 24 25 26 27 28
    ///
    /// **Example:**
    /// ```ignore
    /// std::process::exit(0)
    /// ```
    pub EXIT,
    restriction,
    "`std::process::exit` is called, terminating the program"
}

declare_lint_pass!(Exit => [EXIT]);

impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Exit {
Y
Yuki Okushi 已提交
29
    fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr<'_>) {
H
Heinz N. Gies 已提交
30 31 32 33 34 35
        if_chain! {
            if let ExprKind::Call(ref path_expr, ref _args) = e.kind;
            if let ExprKind::Path(ref path) = path_expr.kind;
            if let Some(def_id) = qpath_res(cx, path, path_expr.hir_id).opt_def_id();
            if match_def_path(cx, def_id, &paths::EXIT);
            then {
L
Lzu Tao 已提交
36 37
                let parent = cx.tcx.hir().get_parent_item(e.hir_id);
                if let Some(Node::Item(Item{kind: ItemKind::Fn(..), ..})) = cx.tcx.hir().find(parent) {
H
Heinz N. Gies 已提交
38 39 40 41 42
                    // If the next item up is a function we check if it is an entry point
                    // and only then emit a linter warning
                    let def_id = cx.tcx.hir().local_def_id(parent);
                    if !is_entrypoint_fn(cx, def_id) {
                        span_lint(cx, EXIT, e.span, "usage of `process::exit`");
H
Heinz N. Gies 已提交
43 44
                    }
                }
H
Heinz N. Gies 已提交
45 46 47 48
            }
        }
    }
}