fixed tests for copy assignment

src/json.hpp

@@ -445,7 +445,6 @@ class basic_json
     /// copy assignment
     inline reference& operator=(basic_json other) noexcept
     {
-        assert(false); // not sure if function will ever be called
         std::swap(m_type, other.m_type);
         std::swap(m_value, other.m_value);
         return *this;

src/json.hpp.re2c

@@ -445,7 +445,6 @@ class basic_json
     /// copy assignment
     inline reference& operator=(basic_json other) noexcept
     {
-        assert(false); // not sure if function will ever be called
         std::swap(m_type, other.m_type);
         std::swap(m_value, other.m_value);
         return *this;

test/unit.cpp

@@ -963,49 +963,56 @@ TEST_CASE("other constructors and destructor")
         SECTION("object")
         {
             json j {{"foo", 1}, {"bar", false}};
-            json k = j;
+            json k;
+            k = j;
             CHECK(j == k);
         }
 
         SECTION("array")
         {
             json j {"foo", 1, 42.23, false};
-            json k = j;
+            json k;
+            k = j;
             CHECK(j == k);
         }
 
         SECTION("null")
         {
             json j(nullptr);
-            json k = j;
+            json k;
+            k = j;
             CHECK(j == k);
         }
 
         SECTION("boolean")
         {
             json j(true);
-            json k = j;
+            json k;
+            k = j;
             CHECK(j == k);
         }
 
         SECTION("string")
         {
             json j("Hello world");
-            json k = j;
+            json k;
+            k = j;
             CHECK(j == k);
         }
 
         SECTION("number (integer)")
         {
             json j(42);
-            json k = j;
+            json k;
+            k = j;
             CHECK(j == k);
         }
 
         SECTION("number (floating-point)")
         {
             json j(42.23);
-            json k = j;
+            json k;
+            k = j;
             CHECK(j == k);
         }
     }