1. 24 3月, 2015 1 次提交
    • A
      Replication: disconnect blocked clients when switching to slave role. · 96aa6106
      antirez 提交于
      Bug as old as Redis and blocking operations. It's hard to trigger since
      only happens on instance role switch, but the results are quite bad
      since an inconsistency between master and slave is created.
      
      How to trigger the bug is a good description of the bug itself.
      
      1. Client does "BLPOP mylist 0" in master.
      2. Master is turned into slave, that replicates from New-Master.
      3. Client does "LPUSH mylist foo" in New-Master.
      4. New-Master propagates write to slave.
      5. Slave receives the LPUSH, the blocked client get served.
      
      Now Master "mylist" key has "foo", Slave "mylist" key is empty.
      
      Highlights:
      
      * At step "2" above, the client remains attached, basically escaping any
        check performed during command dispatch: read only slave, in that case.
      * At step "5" the slave (that was the master), serves the blocked client
        consuming a list element, which is not consumed on the master side.
      
      This scenario is technically likely to happen during failovers, however
      since Redis Sentinel already disconnects clients using the CLIENT
      command when changing the role of the instance, the bug is avoided in
      Sentinel deployments.
      
      Closes #2473.
      96aa6106
  2. 08 3月, 2015 1 次提交
  3. 05 3月, 2015 1 次提交
    • A
      Fix iterator for issue #2438. · f8f40afd
      antirez 提交于
      Itereator misuse due to analyzeLatencyForEvent() accessing the
      dictionary during the iteration, without the iterator being
      reclared as safe.
      f8f40afd
  4. 10 2月, 2015 9 次提交
  5. 03 2月, 2015 1 次提交
    • M
      Update redis-cli.c · 61290d81
      mattcollier 提交于
      Code was adding '\n'  (line 521) to the end of NIL values exlusively making csv output inconsistent.  Removed '\n'
      61290d81
  6. 22 1月, 2015 3 次提交
  7. 21 1月, 2015 1 次提交
    • A
      AOF rewrite: set iterator var to NULL when freed. · e7aa5fb5
      antirez 提交于
      The cleanup code expects that if 'di' is not NULL, it is a valid
      iterator that should be freed.
      
      The result of this bug was a crash of the AOF rewriting process if an
      error occurred after the DBs data are written and the iterator is no
      longer valid.
      e7aa5fb5
  8. 09 1月, 2015 2 次提交
  9. 08 1月, 2015 2 次提交
  10. 23 12月, 2014 1 次提交
    • A
      INFO loading stats: three fixes. · 22a0fe8d
      antirez 提交于
      1. Server unxtime may remain not updated while loading AOF, so ETA is
      not updated correctly.
      
      2. Number of processed byte was not initialized.
      
      3. Possible division by zero condition (likely cause of issue #1932).
      22a0fe8d
  11. 22 12月, 2014 1 次提交
  12. 19 12月, 2014 1 次提交
  13. 17 12月, 2014 1 次提交
  14. 16 12月, 2014 1 次提交
  15. 13 12月, 2014 5 次提交
  16. 11 12月, 2014 4 次提交
  17. 09 12月, 2014 5 次提交