1. 21 6月, 2014 10 次提交
    • A
      CLIENT KILL: fix closing link of the current client. · 61d9a73d
      antirez 提交于
      61d9a73d
    • A
      New features for CLIENT KILL. · 09dc6dad
      antirez 提交于
      09dc6dad
    • A
      Assign an unique non-repeating ID to each new client. · cad13223
      antirez 提交于
      This will be used by CLIENT KILL and is also a good way to ensure a
      given client is still the same across CLIENT LIST calls.
      
      The output of CLIENT LIST was modified to include the new ID, but this
      change is considered to be backward compatible as the API does not imply
      you can do positional parsing, since each filed as a different name.
      cad13223
    • A
      Client types generalized. · b6a26b52
      antirez 提交于
      Because of output buffer limits Redis internals had this idea of type of
      clients: normal, pubsub, slave. It is possible to set different output
      buffer limits for the three kinds of clients.
      
      However all the macros and API were named after output buffer limit
      classes, while the idea of a client type is a generic one that can be
      reused.
      
      This commit does two things:
      
      1) Rename the API and defines with more general names.
      2) Change the class of clients executing the MONITOR command from "slave"
         to "normal".
      
      "2" is a good idea because you want to have very special settings for
      slaves, that are not a good idea for MONITOR clients that are instead
      normal clients even if they are conceptually slave-alike (since it is a
      push protocol).
      
      The backward-compatibility breakage resulting from "2" is considered to
      be minimal to care, since MONITOR is a debugging command, and because
      anyway this change is not going to break the format or the behavior, but
      just when a connection is closed on big output buffer issues.
      b6a26b52
    • A
      ROLE output improved for slaves. · 8060de98
      antirez 提交于
      Info about the replication state with the master added.
      8060de98
    • A
      ROLE command added. · 41a15205
      antirez 提交于
      The new ROLE command is designed in order to provide a client with
      informations about the replication in a fast and easy to use way
      compared to the INFO command where the same information is also
      available.
      41a15205
    • A
      CLIENT LIST speedup via peerid caching + smart allocation. · d8d415e7
      antirez 提交于
      This commit adds peer ID caching in the client structure plus an API
      change and the use of sdsMakeRoomFor() in order to improve the
      reallocation pattern to generate the CLIENT LIST output.
      
      Both the changes account for a very significant speedup.
      d8d415e7
    • A
      52189cb9
    • A
      Added new sdscatfmt() %u and %U format specifiers. · 4acc3daa
      antirez 提交于
      This commit also fixes a bug in the implementation of sdscatfmt()
      resulting from stale references to the SDS string header after
      sdsMakeRoomFor() calls.
      4acc3daa
    • A
      sdscatfmt() added to SDS library. · 3a915ace
      antirez 提交于
      sdscatprintf() relies on printf() family libc functions and is sometimes
      too slow in critical code paths. sdscatfmt() is an alternative which is:
      
      1) Far less capable.
      2) Format specifier uncompatible.
      3) Faster.
      
      It is suitable to be used in those speed critical code paths such as
      CLIENT LIST output generation.
      3a915ace
  2. 20 6月, 2014 2 次提交
  3. 19 6月, 2014 5 次提交
    • A
      Sentinel test: tolerate larger delays in init tests. · 2355ae9b
      antirez 提交于
      2355ae9b
    • A
      fd2faee5
    • A
      Sentinel: send hello messages ASAP after config change. · 93ee0f26
      antirez 提交于
      Eventual configuration convergence is guaranteed by our periodic hello
      messages to all the instances, however when there are important notices
      to share, better make a phone call. With this commit we force an hello
      message to other Sentinal and Redis instances within the next 100
      milliseconds of a config update, which is practically better than
      waiting a few seconds.
      93ee0f26
    • A
      Sentinel: handle SRI_PROMOTED flag correctly. · 9b883974
      antirez 提交于
      Lack of check of the SRI_PROMOTED flag caused Sentienl to act with the
      promoted slave turned into a master during failover like if it was a
      normal instance.
      
      Normally this problem was not apparent because during real failovers the
      old master is down so the bugged code path was not entered, however with
      manual failovers via the SENTINEL FAILOVER command, the problem was
      easily triggered.
      
      This commit prevents promoted slaves from getting reconfigured, moreover
      we now explicitly check that during a failover the slave turning into a
      master is the one we selected for promotion and not a different one.
      9b883974
    • A
      Sentinel test: add manual failover test. · 7665cc67
      antirez 提交于
      7665cc67
  4. 18 6月, 2014 8 次提交
  5. 16 6月, 2014 2 次提交
    • A
      Scripting: regression test for issue #1811. · 258f3cd3
      antirez 提交于
      258f3cd3
    • A
      Fix semantics of Lua calls to SELECT. · ca6b95df
      antirez 提交于
      Lua scripts are executed in the context of the currently selected
      database (as selected by the caller of the script).
      
      However Lua scripts are also free to use the SELECT command in order to
      affect other DBs. When SELECT is called frm Lua, the old behavior, before
      this commit, was to automatically set the Lua caller selected DB to the
      last DB selected by Lua. See for example the following sequence of
      commands:
      
          SELECT 0
          SET x 10
          EVAL "redis.call('select','1')" 0
          SET x 20
      
      Before this commit after the execution of this sequence of commands,
      we'll have x=10 in DB 0, and x=20 in DB 1.
      
      Because of the problem above, there was a bug affecting replication of
      Lua scripts, because of the actual implementation of replication. It was
      possible to fix the implementation of Lua scripts in order to fix the
      issue, but looking closely, the bug is the consequence of the behavior
      of Lua ability to set the caller's DB.
      
      Under the old semantics, a script selecting a different DB, has no simple
      ways to restore the state and select back the previously selected DB.
      Moreover the script auhtor must remember that the restore is needed,
      otherwise the new commands executed by the caller, will be executed in
      the context of a different DB.
      
      So this commit fixes both the replication issue, and this hard-to-use
      semantics, by removing the ability of Lua, after the script execution,
      to force the caller to switch to the DB selected by the Lua script.
      
      The new behavior of the previous sequence of commadns is to just set
      X=20 in DB 0. However Lua scripts are still capable of writing / reading
      from different DBs if needed.
      
      WARNING: This is a semantical change that will break programs that are
      conceived to select the client selected DB via Lua scripts.
      
      This fixes issue #1811.
      ca6b95df
  6. 11 6月, 2014 3 次提交
    • A
      Redis 2.8.11. · b0f39223
      antirez 提交于
      b0f39223
    • A
      Scripting: Fix for a #1118 regression simplified. · a3b0dbcc
      antirez 提交于
      It is more straightforward to just test for a numerical type avoiding
      Lua's automatic conversion. The code is technically more correct now,
      however Lua should automatically convert to number only if the original
      type is a string that "looks like a number", and not from other types,
      so practically speaking the fix is identical AFAIK.
      a3b0dbcc
    • M
      Scripting: Fix regression from #1118 · ba76daa4
      Matt Stancliff 提交于
      The new check-for-number behavior of Lua arguments broke
      users who use large strings of just integers.
      
      The Lua number check would convert the string to a number, but
      that breaks user data because
      Lua numbers have limited precision compared to an arbitrarily
      precise number wrapped in a string.
      
      Regression fixed and new test added.
      
      Fixes #1118 again.
      ba76daa4
  7. 09 6月, 2014 3 次提交
    • M
      Fix lack of strtold under Cygwin · 8f774ee7
      Matt Stancliff 提交于
      Renaming strtold to strtod then casting
      the result is the standard way of dealing with
      no strtold in Cygwin.
      8f774ee7
    • M
      Fix lack of SA_ONSTACK under Cygwin · 2af24143
      Matt Stancliff 提交于
      Fixes #232
      2af24143
    • M
      Fix blocking operations from missing new lists · b4f9761d
      Matt Stancliff 提交于
      Behrad Zari discovered [1] and Josiah reported [2]: if you block
      and wait for a list to exist, but the list creates from
      a non-push command, the blocked client never gets notified.
      
      This commit adds notification of blocked clients into
      the DB layer and away from individual commands.
      
      Lists can be created by [LR]PUSH, SORT..STORE, RENAME, MOVE,
      and RESTORE.  Previously, blocked client notifications were
      only triggered by [LR]PUSH.  Your client would never get
      notified if a list were created by SORT..STORE or RENAME or
      a RESTORE, etc.
      
      Blocked client notification now happens in one unified place:
        - dbAdd() triggers notification when adding a list to the DB
      
      Two new tests are added that fail prior to this commit.
      
      All test pass.
      
      Fixes #1668
      
      [1]: https://groups.google.com/forum/#!topic/redis-db/k4oWfMkN1NU
      [2]: #1668
      b4f9761d
  8. 06 6月, 2014 4 次提交
  9. 05 6月, 2014 3 次提交