1. 21 1月, 2013 2 次提交
  2. 19 1月, 2013 8 次提交
  3. 18 1月, 2013 1 次提交
    • N
      redis-cli --rdb fails if server sends a ping · 0f4dbd9a
      Nathan Parry 提交于
      Redis pings slaves in "pre-synchronization stage" with newlines. (See
      https://github.com/antirez/redis/blob/2.6.9/src/replication.c#L814)
      However, redis-cli does not expect this - it sees the newline as the end
      of the bulk length line, and ends up returning 0 as bulk the length.
      This manifests as the following when running redis-cli:
      
          $ ./src/redis-cli --rdb some_file
          SYNC sent to master, writing 0 bytes to 'some_file'
          Transfer finished with success.
      
      With this commit, we just ignore leading newlines while reading the bulk
      length line.
      
      To reproduce the problem, load enough data into Redis so that the
      preparation of the RDB snapshot takes long enough for a ping to occur
      while redis-cli is waiting for the data.
      0f4dbd9a
  4. 17 1月, 2013 2 次提交
  5. 15 1月, 2013 4 次提交
    • A
      Tests for CLIENT GETNAME/SETNAME. · f9c1263f
      antirez 提交于
      f9c1263f
    • A
      Typo fixed, ASCI -> ASCII. · 1b2ac3b2
      antirez 提交于
      1b2ac3b2
    • A
      CLIENT GETNAME and CLIENT SETNAME introduced. · c5f23ca7
      antirez 提交于
      Sometimes it is much simpler to debug complex Redis installations if it
      is possible to assign clients a name that is displayed in the CLIENT
      LIST output.
      
      This is the case, for example, for "leaked" connections. The ability to
      provide a name to the client makes it quite trivial to understand what
      is the part of the code implementing the client not releasing the
      resources appropriately.
      
      Behavior:
      
          CLIENT SETNAME: set a name for the client, or remove the current
                          name if an empty name is set.
          CLIENT GETNAME: get the current name, or a nil.
          CLIENT LIST: now displays the client name if any.
      
      Thanks to Mark Gravell for pushing this idea forward.
      c5f23ca7
    • A
      Undo slave-master handshake when SLAVEOF sets a new slave. · 27abaa23
      antirez 提交于
      Issue #828 shows how Redis was not correctly undoing a non-blocking
      connection attempt with the previous master when the master was set to a
      new address using the SLAVEOF command.
      
      This was also a result of lack of refactoring, so now there is a
      function to cancel the non blocking handshake with the master.
      The new function is now used when SLAVEOF NO ONE is called or when
      SLAVEOF is used to set the master to a different address.
      27abaa23
  6. 12 1月, 2013 1 次提交
  7. 11 1月, 2013 1 次提交
  8. 10 1月, 2013 3 次提交
  9. 03 1月, 2013 2 次提交
  10. 20 12月, 2012 1 次提交
  11. 17 12月, 2012 2 次提交
  12. 13 12月, 2012 1 次提交
  13. 12 12月, 2012 1 次提交
    • A
      Fix config.h endianess detection to work on Linux / PPC64. · d64a9cf5
      antirez 提交于
      Config.h performs endianess detection including OS-specific headers to
      define the endianess macros, or when this is not possible, checking the
      processor type via ifdefs.
      
      Sometimes when the OS-specific macro is included, only __BYTE_ORDER is
      defined, while BYTE_ORDER remains undefined. There is code at the end of
      config.h endianess detection in order to define the macros without the
      underscore, but it was not working correctly.
      
      This commit fixes endianess detection fixing Redis on Linux / PPC64 and
      possibly other systems.
      d64a9cf5
  14. 03 12月, 2012 5 次提交
    • A
      Redis 2.6.7 · d9301f05
      antirez 提交于
      d9301f05
    • B
      Issue 804 Add Default-Start and Default-Stop LSB tags for RedHat startup and... · 6c9897f6
      Brian J. McManus 提交于
      Issue 804 Add Default-Start and Default-Stop LSB tags for RedHat startup and update-rc.d compatability.
      6c9897f6
    • A
      Memory leak fixed: release client's bpop->keys dictionary. · 984f6edf
      antirez 提交于
      Refactoring performed after issue #801 resolution (see commit
      2f87cf8b) introduced a memory leak that
      is fixed by this commit.
      
      I simply forgot to free the new allocated dictionary in the client
      structure trusting the output of "make test" on OSX.
      
      However due to changes in the "leaks" utility the test was no longer
      testing memory leaks. This problem was also fixed.
      
      Fortunately the CI test running at ci.redis.io spotted the bug in the
      valgrind run.
      
      The leak never ended into a stable release.
      984f6edf
    • A
      Test: fixed osx "leaks" support in test. · a2b3fff2
      antirez 提交于
      Due to changes in recent releases of osx leaks utility, the osx leak
      detection no longer worked. Now it is fixed in a way that should be
      backward compatible.
      a2b3fff2
    • A
      Blocking POP: use a dictionary to store keys clinet side. · 54b08c86
      antirez 提交于
      To store the keys we block for during a blocking pop operation, in the
      case the client is blocked for more data to arrive, we used a simple
      linear array of redis objects, in the blockingState structure:
      
          robj **keys;
          int count;
      
      However in order to fix issue #801 we also use a dictionary in order to
      avoid to end in the blocked clients queue for the same key multiple
      times with the same client.
      
      The dictionary was only temporary, just to avoid duplicates, but since
      we create / destroy it there is no point in doing this duplicated work,
      so this commit simply use a dictionary as the main structure to store
      the keys we are blocked for. So instead of the previous fields we now
      just have:
      
          dict *keys;
      
      This simplifies the code and reduces the work done by the server during
      a blocking POP operation.
      54b08c86
  15. 02 12月, 2012 1 次提交
  16. 01 12月, 2012 1 次提交
    • A
      Client should not block multiple times on the same key. · cac49a90
      antirez 提交于
      Sending a command like:
      
      BLPOP foo foo foo foo 0
      
      Resulted into a crash before this commit since the client ended being
      inserted in the waiting list for this key multiple times.
      This resulted into the function handleClientsBlockedOnLists() to fail
      because we have code like that:
      
          if (de) {
              list *clients = dictGetVal(de);
              int numclients = listLength(clients);
      
              while(numclients--) {
                  listNode *clientnode = listFirst(clients);
      
                  /* server clients here... */
              }
          }
      
      The code to serve clients used to remove the served client from the
      waiting list, so if a client is blocking multiple times, eventually the
      call to listFirst() will return NULL or worse will access random memory
      since the list may no longer exist as it is removed by the function
      unblockClientWaitingData() if there are no more clients waiting for this
      list.
      
      To avoid making the rest of the implementation more complex, this commit
      modifies blockForKeys() so that a client will be put just a single time
      into the waiting list for a given key.
      
      Since it is Saturday, I hope this fixes issue #801.
      cac49a90
  17. 29 11月, 2012 3 次提交
  18. 23 11月, 2012 1 次提交