1. 18 6月, 2014 1 次提交
  2. 16 6月, 2014 2 次提交
    • A
      Scripting: regression test for issue #1811. · 258f3cd3
      antirez 提交于
      258f3cd3
    • A
      Fix semantics of Lua calls to SELECT. · ca6b95df
      antirez 提交于
      Lua scripts are executed in the context of the currently selected
      database (as selected by the caller of the script).
      
      However Lua scripts are also free to use the SELECT command in order to
      affect other DBs. When SELECT is called frm Lua, the old behavior, before
      this commit, was to automatically set the Lua caller selected DB to the
      last DB selected by Lua. See for example the following sequence of
      commands:
      
          SELECT 0
          SET x 10
          EVAL "redis.call('select','1')" 0
          SET x 20
      
      Before this commit after the execution of this sequence of commands,
      we'll have x=10 in DB 0, and x=20 in DB 1.
      
      Because of the problem above, there was a bug affecting replication of
      Lua scripts, because of the actual implementation of replication. It was
      possible to fix the implementation of Lua scripts in order to fix the
      issue, but looking closely, the bug is the consequence of the behavior
      of Lua ability to set the caller's DB.
      
      Under the old semantics, a script selecting a different DB, has no simple
      ways to restore the state and select back the previously selected DB.
      Moreover the script auhtor must remember that the restore is needed,
      otherwise the new commands executed by the caller, will be executed in
      the context of a different DB.
      
      So this commit fixes both the replication issue, and this hard-to-use
      semantics, by removing the ability of Lua, after the script execution,
      to force the caller to switch to the DB selected by the Lua script.
      
      The new behavior of the previous sequence of commadns is to just set
      X=20 in DB 0. However Lua scripts are still capable of writing / reading
      from different DBs if needed.
      
      WARNING: This is a semantical change that will break programs that are
      conceived to select the client selected DB via Lua scripts.
      
      This fixes issue #1811.
      ca6b95df
  3. 11 6月, 2014 3 次提交
    • A
      Redis 2.8.11. · b0f39223
      antirez 提交于
      b0f39223
    • A
      Scripting: Fix for a #1118 regression simplified. · a3b0dbcc
      antirez 提交于
      It is more straightforward to just test for a numerical type avoiding
      Lua's automatic conversion. The code is technically more correct now,
      however Lua should automatically convert to number only if the original
      type is a string that "looks like a number", and not from other types,
      so practically speaking the fix is identical AFAIK.
      a3b0dbcc
    • M
      Scripting: Fix regression from #1118 · ba76daa4
      Matt Stancliff 提交于
      The new check-for-number behavior of Lua arguments broke
      users who use large strings of just integers.
      
      The Lua number check would convert the string to a number, but
      that breaks user data because
      Lua numbers have limited precision compared to an arbitrarily
      precise number wrapped in a string.
      
      Regression fixed and new test added.
      
      Fixes #1118 again.
      ba76daa4
  4. 09 6月, 2014 3 次提交
    • M
      Fix lack of strtold under Cygwin · 8f774ee7
      Matt Stancliff 提交于
      Renaming strtold to strtod then casting
      the result is the standard way of dealing with
      no strtold in Cygwin.
      8f774ee7
    • M
      Fix lack of SA_ONSTACK under Cygwin · 2af24143
      Matt Stancliff 提交于
      Fixes #232
      2af24143
    • M
      Fix blocking operations from missing new lists · b4f9761d
      Matt Stancliff 提交于
      Behrad Zari discovered [1] and Josiah reported [2]: if you block
      and wait for a list to exist, but the list creates from
      a non-push command, the blocked client never gets notified.
      
      This commit adds notification of blocked clients into
      the DB layer and away from individual commands.
      
      Lists can be created by [LR]PUSH, SORT..STORE, RENAME, MOVE,
      and RESTORE.  Previously, blocked client notifications were
      only triggered by [LR]PUSH.  Your client would never get
      notified if a list were created by SORT..STORE or RENAME or
      a RESTORE, etc.
      
      Blocked client notification now happens in one unified place:
        - dbAdd() triggers notification when adding a list to the DB
      
      Two new tests are added that fail prior to this commit.
      
      All test pass.
      
      Fixes #1668
      
      [1]: https://groups.google.com/forum/#!topic/redis-db/k4oWfMkN1NU
      [2]: #1668
      b4f9761d
  5. 06 6月, 2014 4 次提交
  6. 05 6月, 2014 6 次提交
    • A
      Redis 2.8.10. · 987a47b8
      antirez 提交于
      987a47b8
    • A
      Don't process min-slaves-to-write for slaves. · 430bec34
      antirez 提交于
      Replication is totally broken when a slave has this option, since it
      stops accepting updates from masters.
      
      This fixes issue #1434.
      430bec34
    • A
      Tests for min-slaves-* feature. · 3a30be51
      antirez 提交于
      3a30be51
    • A
      Fixed dbuf variable scope in luaRedisGenericCommand(). · 42504169
      antirez 提交于
      I'm not sure if while the visibility is the inner block, the fact we
      point to 'dbuf' is a problem or not, probably the stack var isx
      guaranteed to live until the function returns. However obvious code is
      better anyway.
      42504169
    • A
      Regression test for issue #1118. · 26359d57
      antirez 提交于
      26359d57
    • A
      Scripting: better Lua number -> string conversion in luaRedisGenericCommand(). · 768994b6
      antirez 提交于
      The lua_to*string() family of functions use a non optimal format
      specifier when converting integers to strings. This has both the problem
      of the number being converted in exponential notation, which we don't
      use as a Redis return value when floating point numbers are involed,
      and, moreover, there is a loss of precision since the default format
      specifier is not able to represent numbers that must be represented
      exactly in the IEEE 754 number mantissa.
      
      The new code handles it as a special case using a saner conversion.
      
      This fixes issue #1118.
      768994b6
  7. 28 5月, 2014 1 次提交
  8. 26 5月, 2014 2 次提交
  9. 22 5月, 2014 4 次提交
    • A
      Test: fixed scripting.tcl test false positive. · 1a14eba2
      antirez 提交于
      1a14eba2
    • A
      Process events with processEventsWhileBlocked() when blocked. · f4823497
      antirez 提交于
      When we are blocked and a few events a processed from time to time, it
      is smarter to call the event handler a few times in order to handle the
      accept, read, write, close cycle of a client in a single pass, otherwise
      there is too much latency added for clients to receive a reply while the
      server is busy in some way (for example during the DB loading).
      f4823497
    • A
      Accept multiple clients per iteration. · f3d3c606
      antirez 提交于
      When the listening sockets readable event is fired, we have the chance
      to accept multiple clients instead of accepting a single one. This makes
      Redis more responsive when there is a mass-connect event (for example
      after the server startup), and in workloads where a connect-disconnect
      pattern is used often, so that multiple clients are waiting to be
      accepted continuously.
      
      As a side effect, this commit makes the LOADING, BUSY, and similar
      errors much faster to deliver to the client, making Redis more
      responsive when there is to return errors to inform the clients that the
      server is blocked in an not interruptible operation.
      f3d3c606
    • A
      While ANET_ERR is -1, check syscall retval for -1 itself. · 41134739
      antirez 提交于
      41134739
  10. 20 5月, 2014 4 次提交
  11. 19 5月, 2014 2 次提交
  12. 15 5月, 2014 1 次提交
  13. 12 5月, 2014 3 次提交
  14. 09 5月, 2014 1 次提交
  15. 08 5月, 2014 2 次提交
    • A
      Sentinel: log when a failover will be attempted again. · 13d8b2b0
      antirez 提交于
      When a Sentinel performs a failover (successful or not), or when a
      Sentinel votes for a different Sentinel trying to start a failover, it
      sets a min delay before it will try to get elected for a failover.
      
      While not strictly needed, because if multiple Sentinels will try
      to failover the same master at the same time, only one configuration
      will eventually win, this serialization is practically very useful.
      Normal failovers are cleaner: one Sentinel starts to failover, the
      others update their config when the Sentinel performing the failover
      is able to get the selected slave to move from the role of slave to the
      one of master.
      
      However currently this timeout was implicit, so users could see
      Sentinels not reacting, after a failed failover, for some time, without
      giving any feedback in the logs to the poor sysadmin waiting for clues.
      
      This commit makes Sentinels more verbose about the delay: when a master
      is down and a failover attempt is not performed because the delay has
      still not elaped, something like that will be logged:
      
          Next failover delay: I will not start a failover
          before Thu May  8 16:48:59 2014
      13d8b2b0
    • A
      Sentinel: generate +config-update-from event when a new config is received. · 909d1883
      antirez 提交于
      This event makes clear, before the switch-master event is generated,
      that a Sentinel received a configuration update from another Sentinel.
      909d1883
  16. 07 5月, 2014 1 次提交
    • A
      Scripting test: check that Lua can call commands rewirting argv. · 80b96bc4
      antirez 提交于
      SPOP, tested in the new test, is among the commands rewritng the
      client->argv argument vector (it gets rewritten as SREM) for command
      replication purposes.
      
      Because of recent optimizations to client->argv caching in the context
      of the Lua internal Redis client, it is important to test for SPOP to be
      callable from Lua without bad effects to the other commands.
      80b96bc4