aof.tcl 7.9 KB
Newer Older
1
set defaults { appendonly {yes} appendfilename {appendonly.aof} }
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
set server_path [tmpdir server.aof]
set aof_path "$server_path/appendonly.aof"

proc append_to_aof {str} {
    upvar fp fp
    puts -nonewline $fp $str
}

proc create_aof {code} {
    upvar fp fp aof_path aof_path
    set fp [open $aof_path w+]
    uplevel 1 $code
    close $fp
}

proc start_server_aof {overrides code} {
    upvar defaults defaults srv srv server_path server_path
19 20
    set config [concat $defaults $overrides]
    set srv [start_server [list overrides $config]]
21 22 23 24
    uplevel 1 $code
    kill_server $srv
}

P
Pieter Noordhuis 已提交
25
tags {"aof"} {
A
antirez 已提交
26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
    ## Server can start when aof-load-truncated is set to yes and AOF
    ## is truncated, with an incomplete MULTI block.
    create_aof {
        append_to_aof [formatCommand set foo hello]
        append_to_aof [formatCommand multi]
        append_to_aof [formatCommand set bar world]
    }

    start_server_aof [list dir $server_path aof-load-truncated yes] {
        test "Unfinished MULTI: Server should start if load-truncated is yes" {
            assert_equal 1 [is_alive $srv]
        }
    }

    ## Should also start with truncated AOF without incomplete MULTI block.
    create_aof {
A
antirez 已提交
42 43 44 45 46 47
        append_to_aof [formatCommand incr foo]
        append_to_aof [formatCommand incr foo]
        append_to_aof [formatCommand incr foo]
        append_to_aof [formatCommand incr foo]
        append_to_aof [formatCommand incr foo]
        append_to_aof [string range [formatCommand incr foo] 0 end-1]
A
antirez 已提交
48 49 50 51 52 53
    }

    start_server_aof [list dir $server_path aof-load-truncated yes] {
        test "Short read: Server should start if load-truncated is yes" {
            assert_equal 1 [is_alive $srv]
        }
A
antirez 已提交
54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76

        set client [redis [dict get $srv host] [dict get $srv port]]

        test "Truncated AOF loaded: we expect foo to be equal to 5" {
            assert {[$client get foo] eq "5"}
        }

        test "Append a new command after loading an incomplete AOF" {
            $client incr foo
        }
    }

    # Now the AOF file is expected to be correct
    start_server_aof [list dir $server_path aof-load-truncated yes] {
        test "Short read + command: Server should start" {
            assert_equal 1 [is_alive $srv]
        }

        set client [redis [dict get $srv host] [dict get $srv port]]

        test "Truncated AOF loaded: we expect foo to be equal to 6 now" {
            assert {[$client get foo] eq "6"}
        }
A
antirez 已提交
77 78
    }

A
antirez 已提交
79 80 81 82 83 84 85
    ## Test that the server exits when the AOF contains a format error
    create_aof {
        append_to_aof [formatCommand set foo hello]
        append_to_aof "!!!"
        append_to_aof [formatCommand set foo hello]
    }

A
antirez 已提交
86
    start_server_aof [list dir $server_path aof-load-truncated yes] {
A
antirez 已提交
87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
        test "Bad format: Server should have logged an error" {
            set pattern "*Bad file format reading the append only file*"
            set retry 10
            while {$retry} {
                set result [exec tail -n1 < [dict get $srv stdout]]
                if {[string match $pattern $result]} {
                    break
                }
                incr retry -1
                after 1000
            }
            if {$retry == 0} {
                error "assertion:expected error not found on config file"
            }
        }
    }

P
Pieter Noordhuis 已提交
104 105 106 107 108 109
    ## Test the server doesn't start when the AOF contains an unfinished MULTI
    create_aof {
        append_to_aof [formatCommand set foo hello]
        append_to_aof [formatCommand multi]
        append_to_aof [formatCommand set bar world]
    }
110

111
    start_server_aof [list dir $server_path aof-load-truncated no] {
P
Pieter Noordhuis 已提交
112
        test "Unfinished MULTI: Server should have logged an error" {
113 114 115
            set pattern "*Unexpected end of file reading the append only file*"
            set retry 10
            while {$retry} {
116
                set result [exec tail -n1 < [dict get $srv stdout]]
117 118 119 120 121 122 123 124 125
                if {[string match $pattern $result]} {
                    break
                }
                incr retry -1
                after 1000
            }
            if {$retry == 0} {
                error "assertion:expected error not found on config file"
            }
P
Pieter Noordhuis 已提交
126
        }
P
Pieter Noordhuis 已提交
127
    }
128

P
Pieter Noordhuis 已提交
129 130 131 132 133
    ## Test that the server exits when the AOF contains a short read
    create_aof {
        append_to_aof [formatCommand set foo hello]
        append_to_aof [string range [formatCommand set bar world] 0 end-1]
    }
134

135
    start_server_aof [list dir $server_path aof-load-truncated no] {
P
Pieter Noordhuis 已提交
136
        test "Short read: Server should have logged an error" {
137
            set pattern "*Unexpected end of file reading the append only file*"
138 139
            set retry 10
            while {$retry} {
140
                set result [exec tail -n1 < [dict get $srv stdout]]
141 142 143 144 145 146 147 148 149
                if {[string match $pattern $result]} {
                    break
                }
                incr retry -1
                after 1000
            }
            if {$retry == 0} {
                error "assertion:expected error not found on config file"
            }
P
Pieter Noordhuis 已提交
150
        }
P
Pieter Noordhuis 已提交
151
    }
152

P
Pieter Noordhuis 已提交
153
    ## Test that redis-check-aof indeed sees this AOF is not valid
P
Pieter Noordhuis 已提交
154
    test "Short read: Utility should confirm the AOF is not valid" {
P
Pieter Noordhuis 已提交
155
        catch {
156
            exec src/redis-check-aof $aof_path
P
Pieter Noordhuis 已提交
157 158 159
        } result
        assert_match "*not valid*" $result
    }
160

P
Pieter Noordhuis 已提交
161
    test "Short read: Utility should be able to fix the AOF" {
162
        set result [exec src/redis-check-aof --fix $aof_path << "y\n"]
P
Pieter Noordhuis 已提交
163 164
        assert_match "*Successfully truncated AOF*" $result
    }
165

P
Pieter Noordhuis 已提交
166
    ## Test that the server can be started using the truncated AOF
167
    start_server_aof [list dir $server_path aof-load-truncated no] {
P
Pieter Noordhuis 已提交
168 169 170
        test "Fixed AOF: Server should have been started" {
            assert_equal 1 [is_alive $srv]
        }
171

172
        test "Fixed AOF: Keyspace should contain values that were parsable" {   
P
Pieter Noordhuis 已提交
173
            set client [redis [dict get $srv host] [dict get $srv port]]
174 175 176 177 178
            wait_for_condition 50 100 {
                [catch {$client ping} e] == 0
            } else {
                fail "Loading DB is taking too much time."
            }
P
Pieter Noordhuis 已提交
179 180 181
            assert_equal "hello" [$client get foo]
            assert_equal "" [$client get bar]
        }
P
Pieter Noordhuis 已提交
182
    }
183

184
    ## Test that SPOP (that modifies the client's argc/argv) is correctly free'd
185 186 187 188 189 190
    create_aof {
        append_to_aof [formatCommand sadd set foo]
        append_to_aof [formatCommand sadd set bar]
        append_to_aof [formatCommand spop set]
    }

191
    start_server_aof [list dir $server_path aof-load-truncated no] {
192 193 194 195 196 197
        test "AOF+SPOP: Server should have been started" {
            assert_equal 1 [is_alive $srv]
        }

        test "AOF+SPOP: Set should have 1 member" {
            set client [redis [dict get $srv host] [dict get $srv port]]
198 199 200 201 202
            wait_for_condition 50 100 {
                [catch {$client ping} e] == 0
            } else {
                fail "Loading DB is taking too much time."
            }
203 204 205
            assert_equal 1 [$client scard set]
        }
    }
206 207 208 209 210 211 212 213

    ## Test that EXPIREAT is loaded correctly
    create_aof {
        append_to_aof [formatCommand rpush list foo]
        append_to_aof [formatCommand expireat list 1000]
        append_to_aof [formatCommand rpush list bar]
    }

214
    start_server_aof [list dir $server_path aof-load-truncated no] {
215 216 217 218 219 220
        test "AOF+EXPIRE: Server should have been started" {
            assert_equal 1 [is_alive $srv]
        }

        test "AOF+EXPIRE: List should be empty" {
            set client [redis [dict get $srv host] [dict get $srv port]]
221 222 223 224 225
            wait_for_condition 50 100 {
                [catch {$client ping} e] == 0
            } else {
                fail "Loading DB is taking too much time."
            }
226 227 228
            assert_equal 0 [$client llen list]
        }
    }
229 230 231 232 233 234 235

    start_server {overrides {appendonly {yes} appendfilename {appendonly.aof}}} {
        test {Redis should not try to convert DEL into EXPIREAT for EXPIRE -1} {
            r set x 10
            r expire x -1
        }
    }
236
}