1. 25 7月, 2017 2 次提交
    • D
      scsi: qedi: Fix return code in qedi_ep_connect() · 2c675218
      Dan Carpenter 提交于
      We shouldn't be writing over the "ret" variable.  It means we return
      ERR_PTR(0) which is NULL and it results in a NULL dereference in the
      caller.
      
      Fixes: ace7f46b ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
      Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      2c675218
    • N
      scsi: qedi: Add ISCSI_BOOT_SYSFS to Kconfig · cc20c29e
      Nilesh Javali 提交于
      qedi uses iscsi_boot_sysfs to export the targets used for boot to
      sysfs. Select the config option to make sure the module is built.
      
      This addresses the compile time issue,
          drivers/scsi/qedi/qedi_main.o: In function `qedi_remove':
          qedi_main.c:(.text+0x3bbd): undefined reference to `iscsi_boot_destroy_kset'
          drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.0':
          qedi_main.c:(.text+0x577a): undefined reference to `iscsi_boot_create_target'
          qedi_main.c:(.text+0x5807): undefined reference to `iscsi_boot_create_target'
          qedi_main.c:(.text+0x587f): undefined reference to `iscsi_boot_create_initiator'
          qedi_main.c:(.text+0x58f3): undefined reference to `iscsi_boot_create_ethernet'
          qedi_main.c:(.text+0x5927): undefined reference to `iscsi_boot_destroy_kset'
          qedi_main.c:(.text+0x5d7b): undefined reference to `iscsi_boot_create_host_kset'
      
      [mkp: fixed whitespace]
      Signed-off-by: NNilesh Javali <nilesh.javali@cavium.com>
      Fixes: c57ec8fb ("scsi: qedi: Add support for Boot from SAN over iSCSI offload")
      Reported-by: NArnd Bergmann <arnd@arndb.de>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      cc20c29e
  2. 13 7月, 2017 2 次提交
  3. 27 6月, 2017 1 次提交
  4. 20 6月, 2017 2 次提交
  5. 25 5月, 2017 1 次提交
  6. 24 5月, 2017 7 次提交
  7. 19 5月, 2017 1 次提交
  8. 20 4月, 2017 1 次提交
  9. 16 3月, 2017 2 次提交
  10. 14 3月, 2017 1 次提交
  11. 07 3月, 2017 1 次提交
    • A
      scsi: qedi: fix build error without DEBUG_FS · bd571195
      Arnd Bergmann 提交于
      Without CONFIG_DEBUG_FS, we run into a link error:
      
      drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_poll':
      qedi_iscsi.c:(.text.qedi_ep_poll+0x134): undefined reference to `do_not_recover'
      drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_disconnect':
      qedi_iscsi.c:(.text.qedi_ep_disconnect+0x36c): undefined reference to `do_not_recover'
      drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_connect':
      qedi_iscsi.c:(.text.qedi_ep_connect+0x350): undefined reference to `do_not_recover'
      drivers/scsi/qedi/qedi_fw.o: In function `qedi_tmf_work':
      qedi_fw.c:(.text.qedi_tmf_work+0x3b4): undefined reference to `do_not_recover'
      
      This defines the symbol as a constant in this case, as there is no way to
      set it to anything other than zero without DEBUG_FS. In addition, I'm renaming
      it to qedi_do_not_recover in order to put it into a driver specific namespace,
      as "do_not_recover" is a really bad name for a kernel-wide global identifier
      when it is used only in one driver.
      
      Fixes: ace7f46b ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
      Reviewed-by: NJohannes Thumshirn <jthumshirn@suse.de>
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Acked-by: NManish Rangankar <Manish.Rangankar@cavium.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      bd571195
  12. 01 3月, 2017 1 次提交
  13. 28 2月, 2017 1 次提交
  14. 10 2月, 2017 1 次提交
  15. 07 2月, 2017 1 次提交
  16. 05 1月, 2017 1 次提交
  17. 25 12月, 2016 1 次提交
    • T
      scsi: qedi: Convert to hotplug state machine · a98d1a0c
      Thomas Gleixner 提交于
      The CPU hotplug code is a trainwreck. It leaks a notifier in case of driver
      registration error and the per cpu loop is racy against cpu hotplug. Aside
      of that the driver should have been written and merged with the new state
      machine interfaces in the first place.
      
      Mop up the mess and Convert it to the hotplug state machine.
      Signed-off-by: NThomas Grumpy Gleixner <tglx@linutronix.de>
      Cc: Nilesh Javali <nilesh.javali@cavium.com>
      Cc: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com>
      Cc: Chad Dupuis <chad.dupuis@cavium.com>
      Cc: Saurav Kashyap <saurav.kashyap@cavium.com>
      Cc: Arun Easi <arun.easi@cavium.com>
      Cc: Manish Rangankar <manish.rangankar@cavium.com>
      Cc: Johannes Thumshirn <jthumshirn@suse.de>
      Cc: Hannes Reinecke <hare@suse.de>
      Cc: Martin K. Petersen <martin.petersen@oracle.com>
      Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
      a98d1a0c
  18. 21 12月, 2016 1 次提交
  19. 15 12月, 2016 1 次提交