1. 01 8月, 2017 1 次提交
    • M
      pinctrl: stm32: select IRQ_DOMAIN_HIERARCHY instead of depends on · 8db63f53
      Masahiro Yamada 提交于
      Drivers that need IRQ_DOMAIN_HIERARCHY should "select" it, but
      drivers/pinctrl/stm32/Kconfig is the only exception that uses
      "depends on" syntax.  This prevents GPIO drivers from select'ing
      IRQ_DOMAIN_HIERARCHY.
      
      For example, if I add "select IRQ_DOMAIN_HIERARCHY" to GPIO_XGENE_SB,
      I get the following recursive dependency error.
      
      drivers/gpio/Kconfig:13:error: recursive dependency detected!
      For a resolution refer to Documentation/kbuild/kconfig-language.txt
      subsection "Kconfig recursive dependency limitations"
      drivers/gpio/Kconfig:13:	symbol GPIOLIB is selected by PINCTRL_STM32
      For a resolution refer to Documentation/kbuild/kconfig-language.txt
      subsection "Kconfig recursive dependency limitations"
      drivers/pinctrl/stm32/Kconfig:3:	symbol PINCTRL_STM32 is selected by PINCTRL_STM32F429
      For a resolution refer to Documentation/kbuild/kconfig-language.txt
      subsection "Kconfig recursive dependency limitations"
      drivers/pinctrl/stm32/Kconfig:11:	symbol PINCTRL_STM32F429 depends on IRQ_DOMAIN_HIERARCHY
      For a resolution refer to Documentation/kbuild/kconfig-language.txt
      subsection "Kconfig recursive dependency limitations"
      kernel/irq/Kconfig:67:	symbol IRQ_DOMAIN_HIERARCHY is selected by GPIO_XGENE_SB
      For a resolution refer to Documentation/kbuild/kconfig-language.txt
      subsection "Kconfig recursive dependency limitations"
      drivers/gpio/Kconfig:502:	symbol GPIO_XGENE_SB depends on GPIOLIB
      Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>
      Tested-by: NAlexandre TORGUE <alexandre.torgue@st.com>
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      8db63f53
  2. 24 4月, 2017 1 次提交
  3. 06 2月, 2017 1 次提交
  4. 15 9月, 2016 1 次提交
    • A
      pinctrl: stm32: add IRQ_DOMAIN_HIERARCHY dependency · 49cf2f29
      Arnd Bergmann 提交于
      The newly added irqchip support for the stm32 pinctrl driver uses
      hierarchical IRQ domains as provided by the NVIC primary irqchip.
      This works great for any configuration that may be relevant on
      stm32, but when doing compile-testing (randconfig), we can
      enable it without NVIC or any other primary irqchip that
      enables IRQ_DOMAIN_HIERARCHY:
      
      drivers/pinctrl/stm32/pinctrl-stm32.c:212:13: error: 'irq_chip_eoi_parent' undeclared here (not in a function)
      drivers/pinctrl/stm32/pinctrl-stm32.c:213:20: error: 'irq_chip_mask_parent' undeclared here (not in a function)
      drivers/pinctrl/stm32/pinctrl-stm32.c:214:20: error: 'irq_chip_unmask_parent' undeclared here (not in a function)
      drivers/pinctrl/stm32/pinctrl-stm32.c:215:20: error: 'irq_chip_set_type_parent' undeclared here (not in a function)
      
      This adds a Kconfig dependency to limit compile-testing to
      configurations that have IRQ_DOMAIN_HIERARCHY already enabled.
      It's not obvious whether we should use 'depends on' or 'select'
      here, I think either one works, with 'depends on' being more
      intuitive, while 'select' would be less likely to cause dependency
      loops.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Fixes: 0eb9f683 ("pinctrl: Add IRQ support to STM32 gpios")
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      49cf2f29
  5. 13 9月, 2016 1 次提交
  6. 11 7月, 2016 1 次提交
  7. 27 1月, 2016 1 次提交