1. 05 1月, 2006 10 次提交
  2. 22 12月, 2005 1 次提交
    • P
      [PATCH] USB Storage: Force starget->scsi_level in usb-storage scsiglue.c · 28120be5
      Paul Walmsley 提交于
      When the usb-storage module forces sdev->scsi_level to SCSI_2, it should
      also force starget->scsi_level to the same value.  Otherwise, the SCSI
      layer may attempt to issue SCSI-3 commands to the device, such as REPORT
      LUNS, which it cannot handle.  This can prevent the device from working
      with Linux.
      
      The AMS Venus DS3 DS2316SU2S SATA-to-SATA+USB enclosure, based on the
      Oxford Semiconductor OXU921S chip, requires this patch to function
      correctly on Linux.  The enclosure reports a SCSI-3 SPC-2 command set
      level, but does not correctly handle the REPORT LUNS SCSI command -
      probably due to a bug in its firmware.
      
      It seems likely that other USB storage enclosures with similar bugs will
      also benefit from this patch.
      
      Tony Lindgren <tony@atomide.com> collaborated in the development of this
      patch.
      Signed-off-by: NPaul Walmsley <paul@booyaka.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      28120be5
  3. 24 11月, 2005 1 次提交
    • D
      [PATCH] USB: fix USB key generates ioctl_internal_command errors issue · 63dc3ff3
      David Hrdeman 提交于
      On Wed, Nov 16, 2005 at 06:34:24PM -0800, Pete Zaitcev wrote:
      >On Wed, 16 Nov 2005 23:52:32 +0100, David Hrdeman <david@2gen.com> wrote:
      >> usb-storage: waiting for device to settle before scanning
      >>   Vendor: I0MEGA    Model: UMni1GB*IOM2K4    Rev: 1.01
      >>   Type:   Direct-Access                      ANSI SCSI revision: 02
      >> SCSI device sda: 2048000 512-byte hdwr sectors (1049 MB)
      >> sda: Write Protect is off
      >> sda: Mode Sense: 00 00 00 00
      >> sda: assuming drive cache: write through
      >> ioctl_internal_command: <8 0 0 0> return code = 8000002
      >>    : Current: sense key=0x0
      >>     ASC=0x0 ASCQ=0x0
      >> SCSI device sda: 2048000 512-byte hdwr sectors (1049 MB)
      >
      >I think it's harmless. I saw things like that, and initially I plugged
      >them with workarounds like this:
      
      Thanks for the pointer, and yes, it is harmless, but it floods the
      console with the messages which hides other (potentially important)
      messages...following your example I've made a patch which fixes the
      problem.
      Signed-off-by: NDavid Hrdeman <david@2gen.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      63dc3ff3
  4. 18 11月, 2005 4 次提交
  5. 29 10月, 2005 13 次提交
  6. 13 9月, 2005 4 次提交
  7. 09 9月, 2005 7 次提交
    • N
      [PATCH] USB Storage: code cleanups for onetouch.c · d6450e19
      Nick Sillik 提交于
      As sugested by Alan Stern here are a few code cleanups for onetouch.c:
      
      -Check number of endpoints before directly referencing intf->endpoint[2]
      -Use defined constants instead of magic numbers
      -Revmove the non-ascii characters from copyright notice
      -Make registration and deregistration messages more similar
      Signed-off-by: NNick Sillik <n.sillik@temple.edu>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      d6450e19
    • D
      [PATCH] USB: Fix HP8200 detection in shuttle_usbat · 68a6457e
      Daniel Drake 提交于
      Adding flash-device support to the shuttle_usbat driver in 2.6.11
      introduced the need to detect which type of device we are dealing with:
      CDRW drive, or flash media reader.
      
      The detection routine used turned out to not work for HP8200 CDRW users,
      who saw their devices being detected as a flash disk.
      
      This patch (which has been tested on both flash and cdrom) removes some
      unnecessary code, moves device detection to much later during
      initialization, and introduces a new detection routine which appears to
      work.
      Signed-off-by: NDaniel Drake <dsd@gentoo.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      68a6457e
    • A
      [PATCH] USB: URB_ASYNC_UNLINK flag removed from the kernel · b375a049
      Alan Stern 提交于
      29 July 2005, Cambridge, MA:
      
      This afternoon Alan Stern submitted a patch to remove the URB_ASYNC_UNLINK
      flag from the Linux kernel.  Mr. Stern explained, "This flag is a relic
      from an earlier, less-well-designed system.  For over a year it hasn't
      been used for anything other than printing warning messages."
      
      An anonymous spokesman for the Linux kernel development community
      commented, "This is exactly the sort of thing we see happening all the
      time.  As the kernel evolves, support for old techniques and old code can
      be jettisoned and replaced by newer, better approaches.  Proprietary
      operating systems do not have the freedom or flexibility to change so
      quickly."
      
      Mr. Stern, a staff member at Harvard University's Rowland Institute who
      works on Linux only as a hobby, noted that the patch (labelled as548) did
      not update two files, keyspan.c and option.c, in the USB drivers' "serial"
      subdirectory.  "Those files need more extensive changes," he remarked.
      "They examine the status field of several URBs at times when they're not
      supposed to.  That will need to be fixed before the URB_ASYNC_UNLINK flag
      is removed."
      
      Greg Kroah-Hartman, the kernel maintainer responsible for overseeing all
      of Linux's USB drivers, did not respond to our inquiries or return our
      calls.  His only comment was "Applied, thanks."
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      b375a049
    • M
      [PATCH] USB Storage: wedge SCSI revision at 2 for usb-storage devices · a4e62832
      Matthew Dharm 提交于
      This patch started life as as479b, and has been rediffed.  Please note
      the order of submission of this latest patch series -- even tho this has
      an older original number, it is the last patch I'll be sending today.
      
      This patch changes the reported SCSI revision level to 2 for all
      disk-type devices.  This is needed in a few cases because the device
      reports a level of 3 or higher but then crashes when given a REPORT LUNS
      command (for which support is supposed to be mandatory at those levels).
      This shouldn't harm us, since it only matters for sparse LUNs and we
      have separate ways of coping with that.
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: NMatthew Dharm <mdharm-usb@one-eyed-alien.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      a4e62832
    • M
      [PATCH] USB Storage: add support for Maxtor One-Touch button · 34008dbf
      Matthew Dharm 提交于
      This patch is originally from Nick Sillik, and has been rediffed against
      the latest tree.
      
      This patch adds usability to the OneTouch Button on Maxtor External USB
      Hard Drives. Using an unusual device entry it declares an extra init
      function which claims the interrupt endpoint associated with this
      button.  The button is connected to the input system.
      Signed-off-by: NNick Sillik <n.sillik@temple.edu>
      Signed-off-by: NMatthew Dharm <mdharm-usb@one-eyed-alien.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      34008dbf
    • M
      [PATCH] USB Storage: close a race condition in disconnect near queuecommand · 26186ba7
      Matthew Dharm 提交于
      This patch started life as as534, and has been re-diffed against the latest
      tree.
      
      usb-storage has a small loophole, a window between the time queuecommand
      accepts a new command and the time the control thread starts to execute
      it.  If disconnect is called during that window, the driver won't cancel
      the pending command -- we've been relying on the SCSI core to cancel it
      for us during host removal.  But it's better for usb-storage to cancel
      it;  this avoids races and reduces reliance on the SCSI core.
      Fortunately cancelling these commands is easy to do; the key is to do it
      _before_ calling scsi_remove_host.
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: NMatthew Dharm <mdharm-usb@one-eyed-alien.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      26186ba7
    • M
      [PATCH] USB Storage: close a race condition in disconnect near probe · 77f46328
      Matthew Dharm 提交于
      This patch started life as as533, and has been re-diffed against the
      current tree.
      
      Disconnect processing in usb-storage naturally divides into two parts:
      one to quiesce the driver (make sure no commands are executing or
      queued) and remove the host, and the other to deallocate all the USB and
      non-USB resources.  This patch creates two subroutines to handle those
      two parts.  Mostly it's just code movement, but there is one significant
      change.  If the scsi-scanning thread fails to initialize but the host
      has successfully been added, we need to quiesce the driver before
      removing the host.  After all, it's possible that scanning could have
      been initiated from somewhere else, such as userspace -- very low
      probability, but it's easily handled by calling the new subroutine.
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      Signed-off-by: NMatthew Dharm <mdharm-usb@one-eyed-alien.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      77f46328