When polled input device is opened and closed and there are no other
users of polled device, the workqueue is created and destroyed in
every open / close operation. It is probable that at some point
dynamic allocation of internal parts of the workqueue cause changes to the
workqueue.

When a work is queued to the workqueue the work struct contains pointers
to the workqueue data. If the workqueue has been changed and the work
has never been queued to the new workqueue, work-struct contains pointers
to the non-existing workqueue. This will cause crash at the work
cancellation during device close since cancellation of a work assumes
that the workqueue exists.

To prevent that, work struct is cleaned up at device close. This keeps
work struct clean for the next use.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Most laptops have keys that are intended to toggle all device state, not
just wifi. These are currently generally mapped to KEY_WLAN. As a result,
rfkill will only kill or enable wifi in response to the key press. This
confuses users and can make it difficult for them to enable bluetooth
and wwan devices.

This patch adds a new keycode, KEY_RFKILL. It indicates that the system
should toggle the state of all rfkillable devices.
Signed-off-by: NMatthew Garrett <mjg@redhat.com>
Acked-by: NMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

633aae23 "Input: i8042 - switch to using dev_pm_ops" removed handling
for PMSG_THAW, since we do not need to do anything during freeze and
thus it was thougt that thaw is not needed as well. However, there is
a period when interrupts are kept off, and if key happens to be pressed
during that time KBC becomes jammed. To avoid the jam we simply need
to poll KBC once during thaw.
Signed-off-by: NAlan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Set state of the device as "initializing" during and after cleanup
to ensure that unsolicited data from the device is not passed on.
We especially want to avoid processing new device announcements
"0xaa 0x00" that can come up before we perform reconnect operation.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This patch documents a new ABS_MT parameter and adds further text to
clarify some points around the MT protocol.
Requested-by: NYoonyoung Shim <jy0922.shim@samsung.com>
Requested-by: NMika Kuoppala <mika.kuoppala@nokia.com>
Requested-by: NPeter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: NHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

For pressure-based multi-touch devices, a direct way to send sensor
intensity data per finger is needed. This patch adds the ABS_MT_PRESSURE
event to the MT protocol.
Requested-by: NYoonyoung Shim <jy0922.shim@samsung.com>
Requested-by: NMika Kuoppala <mika.kuoppala@nokia.com>
Requested-by: NPeter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: NHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

I missed converting one dev_info call to deb_dbg before submitting the driver.
Without this change, a message will be printed to dmesg for each button press
if a RC6 remote is used.
Signed-off-by: NDavid Härdeman <david@hardeman.nu>
Cc: stable <stable@kernel.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

There are many many ways one can capitalize "Lifebook B Series"...
Signed-off-by: NJon Dodgson <crayzeejon@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Drop the simple fancy sysfs hooks for the aux GPIOs and expose these via
the gpiolib interface so that other drivers can use them.
Signed-off-by: NMichael Hennerich <michael.hennerich@analog.com>
Signed-off-by: NMike Frysinger <vapier@gentoo.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NTai-hwa Liang <avatar@sentelic.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Sentelic probes confuse IBM trackpoints so they stop responding to
TP_READ_ID command. See:

	http://bugzilla.kernel.org/show_bug.cgi?id=14970

Let's move FSP detection lower so it is probed after trackpoint and
others, just before we strat probing for Intellimouse Explorer.
Signed-off-by: NTai-hwa Liang <avatar@sentelic.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Input core displays capabilities bitmasks in form of one or more longs printed
in hex form and separated by spaces. Unfortunately it does not work well
for 32-bit applications running on 64-bit kernels since applications expect
that number is "worth" only 32 bits when kernel advances by 64 bits.

Fix that by ensuring that output produced for compat tasks uses 32-bit units.
Reported-and-tested-by: NMichael Tokarev <mjt@tls.msk.ru>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NElliott Sales de Andrade <quantum.analyst@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

xbox_play_effect() is called while holding dev->event_lock with
interrupts disabled and thus may not use GFP_KERNEL when submitting
urbs.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

For configurations where Synaptics hardware is present but the Synaptics
extensions support is not compiled in, the mouse is reprobed and a new
device is allocated on every suspend/resume.

During probe, psmouse_switch_protocol() calls psmouse_extensions() with
set_properties=1. This calls the dummy synaptics_init() which returns an
error code, instructing us not to use the synaptics extensions.

During resume, psmouse_reconnect() calls psmouse_extensions() with
set_properties=0, in which case call to synaptics_init() is bypassed and
PSMOUSE_SYNAPTICS is returned. Since the result is different from previous
attempt psmouse_reconnect() fails and full re-probe happens.

Fix this by tweaking the set_properties=0 codepath in psmouse_extensions()
to be more careful about offering PSMOUSE_SYNAPTICS extensions.
Signed-off-by: NDaniel Drake <dsd@laptop.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Make bcm5974 report raw multi-touch (MT) data in the form of ABS_MT events.

[dtor@mail.ru: get rid of module option, always report all events]
Signed-off-by: NHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Add a function pointer in the platform data of the DaVinci Keyscan driver
called device_enable, in order to perform board specific actions when
the device is initialized, like setup the PINMUX configuration.
Signed-off-by: NMiguel Aguilar <miguel.aguilar@ridgerun.com>
Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

When using realtime signals, we'll enqueue one signal for every event.
This is unfortunate, because (for example) keyboard presses are three
events: key, msc scancode, and syn.  They'll be enqueued fast enough in
kernel space that all three events will be ready to read by the time
userspace runs, so the first invocation of the signal handler will read
all three events, but then the second two invocations still have to run
to do no work.

Instead, only send the SIGIO notification on syn events.  This is a
slight abuse of SIGIO semantics, in principle it ought to fire as soon
as any events are readable.  But it matches evdev semantics, which is
more important since SIGIO is rather vaguely defined to begin with.
Signed-off-by: NAdam Jackson <ajax@redhat.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We need to first unregister input device and only then cancel event work
since events can arrive (and cause event work to get scheduled again)
until input_unregister_device() returns.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

sysfs_remove_group() waits for sysfs attributes to be removed, therefore
we do not need to worry about driver-specific attributes being accessed
after driver has been detached from the device. In fact, attempts to take
serio->drv_mutex in attribute methods may lead to the following deadlock:

                                          sysfs_read_file()
                                            fill_read_buffer()
                                              sysfs_get_active_two()
                                                psmouse_attr_show_helper()
                                                  serio_pin_driver()
serio_disconnect_driver()
  mutex_lock(&serio->drv_mutex);
                                <-------->        mutex_lock(&serio_drv_mutex);
    psmouse_disconnect()
      sysfs_remove_group(... psmouse_attr_group);
        ....
        sysfs_deactivate();
          wait_for_completion();

Fix this by removing calls to serio_[un]pin_driver() and functions themselves
and using driver-private mutexes to serialize access to attribute's set()
methods that may change device state.
Signed-off-by: NEric W. Biederman <ebiederm@xmission.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This always evaluates to true.
Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We need to wait for the command to disable FF effects to complete before
continuing with closing the device.
Tested-by: NJohannes Ebke <johannes.ebke@physik.uni-muenchen.de>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NFelipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NFelipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Lifebook protocol can only be activated if we find known DMI signature.
It is useles without DMI.
Reported-by: NRakib Mullick <rakib.mullick@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This should fix the following compile warning:

drivers/input/misc/wistron_btns.c:1331:5: warning: "CONFIG_PM" is not defined
Signed-off-by: NRakib Mullick <rakib.mullick@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The variable 'dev' is unused in function 'hgpk_register'.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

On certain boards not all GPIOs may be used as wakeup sources, in which
case some of enable_irq_wake() calls will fail. On resume calling
disable_irq_wake() will warn about unbalanced IRQ wake disable.

Solve this by checking whether enable_irq_wake() succeeded or not and
no not call disable_irq_wake() for these GPIOs/IRQs that have not been
enabled.
Reported-by: NPavel Machek <pavel@ucw.cz>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Do not try to free iforce device when we closing input device; disconnect
is the only place where it should be deleted.
Reported-by: NJohannes Ebke <johannes.ebke@physik.uni-muenchen.de>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This adds simple direction calculation when combining effects. It's useful
to decide motor direction for rumble (vibrator).
Signed-off-by: NJari Vanhala <ext-jari.vanhala@nokia.com>
Acked-by: NAnssi Hannula <anssi.hannula@iki.fi>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The commit 9e68177e changed 'gain' from
signed to unsigned to fix an issue with rumble effect calculation, however
it introduced problems when calculating constant effects. Having 'gain'
being unsigned int was an unfortunate choice since it dominates all
implicit type conversions causing everything to be treated as unsigned
int.

Let's change it back to signed int and simply add proper casts to rumble
effect calculations.
Reported-by: NGary Stein <lordcnidarian@gmail.com>
Acked-by: NAnssi Hannula <anssi.hannula@iki.fi>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Instead of waiting for the next timer tick to start playing an effect
do it immediately. This mostly helps systems using low HZ setting.
Signed-off-by: NJari Vanhala <ext-jari.vanhala@nokia.com>
Acked-by: NAnssi Hannula <anssi.hannula@iki.fi>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We used to make kseriod freezable to prevent unnecessary attempts at
resuming keyboard and mouse before taking hibernation image when suspend
and hibernation were sharing PM operations. Now that they are separated
and we don't risk resuming during 'thaw' we don't need to freeze kseriod
anymore. This will allow us to start resetting mouse and keyboard a bit
earlier, before rest of the userspace comes back up.
Acked-by: NRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Instead of doing full-blown reset while suspending or shutting down
the box use lighter form of reset that should take less time.
Tested-by: NAlan Stern <stern@rowland.harvard.edu>
Tested-by: NRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Properly handle version of the protocol where standard PS/2 packets
from trackpoint are stuffed into middle (byte 3-6) of the standard
ALPS packets when both the touchpad and trackpoint are used together.

The patch is based on work done by Matthew Chapman and additional
research done by David Kubicek and Erik Osterholm:

	https://bugs.launchpad.net/ubuntu/+source/linux/+bug/296610

Many thanks to David Kubicek for his efforts in researching fine points
of this new version of the protocol, especially interaction between pad
and stick in these models.
Signed-off-by: NSebastian Kapfer <sebastian_kapfer@gmx.net>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The commit 66d2a595 introduces a bug:
for every beep requested, a bell is also generated.
Reported-by: NPaul Martin <pm@debian.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

ps2if->irq is unsigned so the test does not work.
Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This driver provides support for the touchscreen interface
integrated into the Freescale MC13783.
Signed-off-by: NSascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: NLuotao Fu <l.fu@pengutronix.de>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This driver was merged before the ep93xx core support was added
for the keypad clock and acquiring/releasing the necessary gpio's.
Now that the proper support is in the ep93xx core this driver
needs to be updated to work correctly.

Summary of changes:
  1) Remove some unused members from the platform data.
  2) Remove the custom KEY macro and use the ones available in
     <linux/input/matrix_keypad.h>
  3) Remove the keypad_{readl/writel} macros and just use
     __raw_{readl/writel} directly.
  4) Update the clk_set_rate() call to work with the core support.
  5) Cleanup the probe routine and remove some unneeded messages.
  6) Use the ep93xx core functions to acquire and release the gpio's.
  7) Fix the clk_get() call to get the keypad clock.
Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>