- 14 10月, 2015 1 次提交
-
-
由 Anish Bhatt 提交于
Use the BIT(x) macro directly instead using multiple BITX defines. Signed-off-by: NAnish Bhatt <anish@gatech.edu> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 20 3月, 2015 1 次提交
-
-
由 Hatice ERTÜRK 提交于
Fix checkpatch.pl issues with "unnecessary whitespace before a quoted newline" in r819xU_phy.c Signed-off-by: NHatice ERTURK <haticeerturk27@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 16 3月, 2015 2 次提交
-
-
由 Haneen Mohammed 提交于
Parentheses are not needed around the right hand side of an assignment. This patch remove parenthese of such occurenses. Issue was detected and solved using the following coccinelle script: @rule1@ identifier x, y, z; expression E1, E2; @@ ( x = (y == z); | x = (E1 == E2); | x = -( ... -) ; ) Signed-off-by: NHaneen Mohammed <hamohammed.sa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Cristina Opriceana 提交于
This patch removes explicit true/false comparations to bool variables. Warning found by coccinelle: "WARNING: Comparison to bool" Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 02 3月, 2015 1 次提交
-
-
由 Ksenija Stanojevic 提交于
Replace all occurrences of TRUE and FALSE by true and false respectively. Signed-off-by: NKsenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 27 2月, 2015 5 次提交
-
-
由 Ksenija Stanojevic 提交于
This patch fixes the checkpatch.pl warning: WARNING: "break is not useful after a goto or return" Signed-off-by: NKsenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ksenija Stanojevic 提交于
This patch simplifies the code by not having two identical paths and fixes the warning given by checkpatch.pl: "else is not useful after a break or return". Signed-off-by: NKsenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ksenija Stanojevic 提交于
Remove unnecessary TRUE statement. Field bMediaConnect is of bool type, so such change is correct. Signed-off-by: NKsenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ksenija Stanojevic 提交于
This patch simplifies the code by removing else and fixes the following checkpatch.pl warning: "else is not useful after break or return". Signed-off-by: NKsenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ksenija Stanojevic 提交于
This patch fixes the checkpatch.pl warning: WARNING: "please, no space before tabs" Signed-off-by: NKsenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 20 10月, 2014 1 次提交
-
-
由 Melike Yurtoglu 提交于
Missing a blank line after declarations" checkpatch.pl warning in r819xU_phy.c Signed-off-by: NMelike Yurtoglu <aysemelikeyurtoglu@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 11 7月, 2014 2 次提交
-
-
由 sanjeev sharma 提交于
This patch will fix switch and case indentation Error reported by checkpatch script. Signed-off-by: NSanjeev Sharma <Sanjeev_Sharma@mentor.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 sanjeev sharma 提交于
This patch will remove unneeded return statements in code. Signed-off-by: NSanjeev Sharma <Sanjeev_Sharma@mentor.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 27 5月, 2014 1 次提交
-
-
由 Peter Senna Tschudin 提交于
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // </smpl> Signed-off-by: NPeter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 04 5月, 2014 1 次提交
-
-
由 Rui Miguel Silva 提交于
fix some code style related to the use of braces in a one statement block Signed-off-by: NRui Miguel Silva <rmfrfs@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 17 3月, 2014 1 次提交
-
-
由 Ana Rey 提交于
Make some local functions static and fix coding style in these function declarations when It is necessary These are the local functions that were made static: rtl8192_CalculateBitShift, rtl8192_phy_RFSerialRead, rtl8192_phy_RFSerialWrite, rtl8192_InitBBRFRegDef, rtl8192_BB_Config_ParaFile,rtl8192_SetTxPowerLevel, rtl8192_phy_SetSwChnlCmdArray, rtl8192_phy_SwChnlStepByStep, rtl8192_phy_FinishSwChnlNow Fixed the following sparse warnings in r819xU_phy.c drivers/staging/rtl8192u/r819xU_phy.c:47:5: warning: symbol 'rtl8192_CalculateBitShift' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:147:5: warning: symbol 'rtl8192_phy_RFSerialRead' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:232:6: warning: symbol 'rtl8192_phy_RFSerialWrite' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:574:6: warning: symbol 'rtl8192_InitBBRFRegDef' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:783:6: warning: symbol 'rtl8192_BB_Config_ParaFile' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:1073:6: warning: symbol 'rtl8192_SetTxPowerLevel' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:1242:4: warning: symbol 'rtl8192_phy_SetSwChnlCmdArray' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:1279:4: warning: symbol 'rtl8192_phy_SwChnlStepByStep' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_phy.c:1436:6: warning: symbol 'rtl8192_phy_FinishSwChnlNow' was not declared. Should it be static? Signed-off-by: NAna Rey <anarey@gmail.com> Signed-off-by: NPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-
- 17 10月, 2013 1 次提交
-
-
由 Teodora Baluta 提交于
These functions are already marked extern in the header file drivers/staging/rtl8192u/r819xU_phy.c:1716:13: warning: function 'InitialGainOperateWorkItemCallBack' with external linkage has definition drivers/staging/rtl8192u/r819xU_cmdpkt.c:497:12: warning: function 'cmpk_message_handle_rx' with external linkage has definition Signed-off-by: NTeodora Baluta <teobaluta@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 26 9月, 2013 1 次提交
-
-
由 Xenia Ragiadakou 提交于
This patch removes the unused code inside #ifdef RTL8190P and #ifdef RTL8192E guards since RTL8190P and RTL8192E are not defined. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 25 6月, 2013 5 次提交
-
-
由 Xenia Ragiadakou 提交于
This patch fixes the newlines by: - adding a newline after variables declarations. - removing the newlines following the return statement. - removing the newlines between function header comments and function definitions. - adding one newline between function definitions. - adding a newline at the end of RT_TRACE messages. This was done to improve code's and logmessages' readability. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the following checkpatch warning: WARNING: msleep < 20ms can sleep for up to 20ms The implementation of msleep() is based on jiffies timeout subsystem. Hence, its resolution is constrained by the value of HZ tick rate. When HZ variable is configured to 100, the jiffies variable is updated every 10 ms, so a timeout of 1ms cannot be met using jiffies (it will be rounded up to 10ms). This patch replaces msleep(1) with usleep_range(1000, 1000). usleep_range() uses hrtimers subsystem which is not bound to HZ value and can provide microsecond-level resolution. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch renames the following variables: 'dwRegRead' into 'reg' 'rtStatus' into 'status' This is done primarily to reduce line length below 80 chars, since the size and the usage of dwRegRead variable can be deduced by its type and the function called to assign it, so it can be replaced by simply 'reg'. Also, rtStatus is not more informative than just status in the given context. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the following checkpatch warning: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch limits the line size below 80 characters, when possible without producing new checkpatch errors. This is done by adjusting identation, replacing hardcoded function names in messages with __func__, merging some trailing comments with the header comments when they both refer to the same line and removing some unnecessary parenthesis. Also, changes slightly some RT_TRACE messages to make them shorter without altering their content. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 20 6月, 2013 3 次提交
-
-
由 Xenia Ragiadakou 提交于
This patch fixes the comments in r819xU_phy.c by: - replacing "// ..." with "/* .... */" - removing unnecessary comments, the dates and names of developers from comments - fixing some inconsistent comments - fixing some typos - fixing alignment issues Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the whitespace around ',' to meet the linux kernel coding style. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch removes variable 'Ret' from rtl8192_QueryBBReg() since its value is returned immediately after it is assigned. The name 'Ret', anyway, does not give any insight and the function description comment is sufficiently informative regarding the returned value. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 19 6月, 2013 6 次提交
-
-
由 Xenia Ragiadakou 提交于
This patch renames the following variables: - dwRegAddr and RegAddr into reg_addr - dwData and Data into data - BitShift into bitshift - Offset into offset - NewOffset into new_offset - Bandwidth into bandwidth The renaming was done to remove camel case and unnecessary 'dw' prefix from the above variable names. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch renames BitMask and dwBitMask variables into bitmask to remove camel case. dwBitMask in the given context can be renamed into simply bitmask since its number of bits (dw->32) can be deduced by its type which is u32. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch renames the variables OriginalValue, NewValue, Original_Value, New_Value and retValue to reg, and the variables bRegValue and dwRegValue to reg_u8 and reg_u32, respectively. This is done primarily in order to reduce the variable name length and consequently line length. Also, it replaces the pair of Original and New variables with one variable. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the whitespace around relational operators to meet the linux kernel coding style. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the whitespace around ';' to meet the linux kernel coding style. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the whitespace around the assignment operator to meet linux kernel coding style. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 18 6月, 2013 8 次提交
-
-
由 Xenia Ragiadakou 提交于
This patch fixes the alignment of function arguments to make it uniform across the driver trying to keep the line size below 80 characters. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch removes whitespace after ')' and before ')' following the linux kernel coding style conventions. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch removes commented-out code to improve code readability. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes whitespace around 'for' and 'while' following the linux kernel coding style conventions. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes whitepace around 'if' following the linux kernel coding style convention. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the following checkpatch error: ERROR: return is not a function, parentheses are not required Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch fixes the brace position and the whitespace around braces. That corrects the following checkpatch errors: ERROR: that open brace { should be on the previous line ERROR: else should follow close brace '}' ERROR: space required after that close brace '}' Also, it removes completely an if(0) statement, instead of correcting its braces. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Xenia Ragiadakou 提交于
This patch uses the ffs linux built-in routine in the computation of the bitshift to take advantage of architecture specific instructions that implement this computation more efficiently. Signed-off-by: NXenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-