- 09 6月, 2015 40 次提交
-
-
由 David Kershner 提交于
When the bus device was created the list_all variables were not being initialized. When the CONTROLVM_BUS_CONFIGURE message was being sent, it was failing to find the bus and produced a panic. Initialize the bus_info->list_all variable by doing a INIT_LIST_HEAD. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
When unloading a module, we need to cleanup the platform registration. However, unregistering the platform uncovered a couple of quirks, namely a missing device_release function. Fix things up so module unload works and allows us to reload the module. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
When we combined visorchipset and visorbus into one driver we negelected to strip out some of the MODULE_ stuff from one of the files. When building the drivers in, it causes a WARN that we try to create /proc/modules/visorbus/version when it is already created. visorchipset.c is the driver entry point, remove the cruft from visorbus_main.c. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Get rid of unused values in the enum. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Diagchannel.h is used primarily for the diagnostics channel. The diagnostics channel is not being used by linux guests currently, so the majority of the file is not needed. What is left is what is needed to perform postcode vmcalls. Those postcodes will eventually end up in the diag channel. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Give the enum the correct values instead of based on other values. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Jes Sorensen 提交于
min_size/max_size aren't used anywhere, and they were just causing headaches in the drivers being ported over to the new interfaces. Signed-off-by: NJes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
This patch removes the legacy dev_info struct and instead creates and passes around a traditional struct device. This allows us to remove a lot of the various look up code and removes the doubt if the struct exists or not. Half of the churn is just the conversion of visorchipset_device_info to visor_device. Various cleanups include re-arranging the failure paths to make more sense. Pay attention to the create_visor_device function. This had a lot of churn to simplify everything. Lots of functions disappeared because they are not needed any more. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
This patch removes the legacy bus_info struct and instead creates and passes around a traditional struct device. This allows us to remove a lot of the various look up code and removes the doubt if the struct exists or not. Half of the churn is just the conversion of visorchipset_bus_info to visor_device. Various cleanups include re-arranging the failure paths to make more sense. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
I used 0 as the device id for the bus root, neglecting the fact that device 0 is a valid id in Unisys's configuration. Modify this to use UINT_MAX instead as a unique number. As fallout from this change it was noticed the bus_no and dev_no was not defined the same way consistently. Fix visorbus.h to use u32 there. Fix the resulting printk warning too. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
The bus driver doesn't work in server mode, just remove the left over pieces. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
Removing stuff that isn't being used. Another prepartion patch to allow us to use visor_device everywhere without the baggage of bus/dev_info. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Don Zickus 提交于
The bus device and regular device were using two different structs. Let's combine them as they are not entirely different from one another. This allows us to move this creation up the stack later and actually remove bus/dev_info easily. Most of the churn is just renaming devdata -> dev and 'struct visorbus_devdata' to 'struct visor_device'. Signed-off-by: NDon Zickus <dzickus@redhat.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Chaitanya Dhere 提交于
This change was detected with help of checkpatch.pl script. Signed-off-by: NChaitanya Dhere <cvijaydh@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Chaitanya Dhere 提交于
In this patch, the if, else conditions are modified to remove the unnecessary equality checks. This change was detected with help of coccinelle tool. Signed-off-by: NChaitanya Dhere <cvijaydh@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c Signed-off-by: NDouglas Barbonaglia Sathler Figueiredo <eng.douglasfigueiredo@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Madhusudhanan Ravindran 提交于
removed the commented INFO lines. Signed-off-by: NMadhusudhanan Ravindran <mravindr@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Fixed indentation issue in few lines Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
remove an unwanted assignment to a variable which is overwritten in the very next line.The first value assigned is not used. Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Remove the ununsed Macro Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in ddk750_display.c: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in ddk750_help.c and ddk750_mode.c: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in ddk750_power.c and ddk750_swi2c.c: ERROR: space required after that ',' Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>: Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in sm750_cursor.c: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in sm750_accel.c: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in sm750_hw.c: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in ddk750_hwi2c.h, ddk750_help.h and ddk750_chip.h: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in sm750_cursor.h, sm750_accel.h, ddk750_power.h and ddk750_mode.h: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in sm750.h: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas to rectify the following checkpatch errors in sm750_help.h: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Isaac Assegai 提交于
Insert Spaces after commas in sm750_hw.h to rectify the following checkpatch errors in sm750_hw.h: ERROR: space required after that ',' Signed-off-by: NIsaac Assegai <isaac.a.travers@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
The sm750fb driver has few Framebuffer configuration dependencies that need to be selected in order to get compiled successfully Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Decotigny 提交于
Source and destination have the same little-endian annotation: this patch removes incorrect byte-swap on non-LE cpus. This addresses the following sparse warning: drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: warning: incorrect type in argument 1 (different base types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: expected unsigned short [unsigned] [usertype] val drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: got restricted __le16 [usertype] BA_timeout_value Signed-off-by: NDavid Decotigny <ddecotig@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Decotigny 提交于
This fixes bitwise arithmetic performed on the host on a variable previously converted to little-endian, and subsequently converted again to little-endian: - issue_action_BA23a() called with "status" crafted in host byte order - "status" converted to LE - bitwise arithmetic on the (LE) "status", performed with masks and shifts in host byte order - result converted to LE (again) and stored in device structure Sparse warning addressed by this patch: drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16: warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16: expected unsigned short [unsigned] status drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3806:16: got restricted __le16 [usertype] <noident> Additional notes: initial cpu_to_le16 was introduced by kernel bulk commit 5e93f352 "staging: r8723au: Add source files for new driver - part 1", initially from github according to commit description. On github, this traces back to another bulk commit: 2896bda04353 "Add new files in core directory", which is the 1st version of the driver. Signed-off-by: NDavid Decotigny <ddecotig@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Sudip Mukherjee 提交于
str was 16 bytes but was mentioned as 128 in snprintf. again msg is 128 bytes but not sufficient to hold the complete debug message of register values. Now removed the use of str, msg and print the register values from the loop. Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Madhusudhanan Ravindran 提交于
This patch attempts to simplify the debugging using standard dev_dbg call so that individual debug prints can be enabled or disbled by dynamic debugging rather than using module params. Signed-off-by: NMadhusudhanan Ravindran <mravindr@visteon.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Abhishek Sharma 提交于
Replace unnecessary conditional checks for variable 'ret' and replace by single return statement. Signed-off-by: NAbhishek Sharma <asharm14@visteon.com> Reviewed-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Joglekar Tejas 提交于
This patch fix warning given by checkpatch.pl abouts spaces given before tab Signed-off-by: NJoglekar Tejas <joglekartejas@gmail.com> Reviewed-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Antonio Murdaca 提交于
cleanup checkpatch.pl warnings about not needed else clauses after a break or return Signed-off-by: NAntonio Murdaca <antonio.murdaca@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Dan Carpenter 提交于
Add some limits here so we don't corrupt memory. Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-