1. 29 11月, 2009 3 次提交
    • D
      pcmcia: rework the irq_req_t typedef · 5fa9167a
      Dominik Brodowski 提交于
      Most of the irq_req_t typedef'd struct can be re-worked quite
      easily:
      
      (1) IRQInfo2 was unused in any case, so drop it.
      
      (2) IRQInfo1 was used write-only, so drop it.
      
      (3) Instance (private data to be passed to the IRQ handler):
      	Most PCMCIA drivers using pcmcia_request_irq() to actually
      	register an IRQ handler set the "dev_id" to the same pointer
      	as the "priv" pointer in struct pcmcia_device. Modify the two
      	exceptions (ipwireless, ibmtr_cs) to also work this waym and
      	set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
      
      (4) Handler is to be of type irq_handler_t.
      
      (5) Handler != NULL already tells whether an IRQ handler is present.
      	Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
      	irq_req_t.Attributes.
      
      CC: netdev@vger.kernel.org
      CC: linux-bluetooth@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: Jaroslav Kysela <perex@perex.cz>
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: Karsten Keil <isdn@linux-pingi.de>
      for the Bluetooth parts: Acked-by: Marcel Holtmann <marcel@holtmann.org>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      5fa9167a
    • D
      pcmcia: pcmcia_request_window() doesn't need a pointer to a pointer · 6838b03f
      Dominik Brodowski 提交于
      pcmcia_request_window() only needs a pointer to struct pcmcia_device, not
      a pointer to a pointer.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Acked-by: Karsten Keil <keil@b1-systems.de> (for ISDN)
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      6838b03f
    • M
      pcmcia: Pass struct pcmcia_device to pcmcia_map_mem_page() · 868575d1
      Magnus Damm 提交于
      No logic changes, just pass struct pcmcia_device to pcmcia_map_mem_page()
      
      [linux@dominikbrodowski.net: update to 2.6.31]
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Acked-by: Karsten Keil <keil@b1-systems.de> (for ISDN)
      Signed-off-by: NMagnus Damm <damm@opensource.se>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      868575d1
  2. 20 11月, 2009 1 次提交
    • J
      drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg · 5452fee2
      Joe Perches 提交于
      Changed function pointer use from non-majority address-of style
      to majority short form without & via:
      
      grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
              perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
      done
      
      Compile tested allyesconfig x86
      Signed-off-by: NJoe Perches <joe@perches.com>
      
       drivers/isdn/gigaset/bas-gigaset.c |    4 ++--
       drivers/isdn/gigaset/common.c      |    2 +-
       drivers/isdn/gigaset/interface.c   |    2 +-
       drivers/isdn/gigaset/ser-gigaset.c |    2 +-
       drivers/isdn/gigaset/usb-gigaset.c |    2 +-
       5 files changed, 6 insertions(+), 6 deletions(-)
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      5452fee2
  3. 16 11月, 2009 2 次提交
  4. 11 11月, 2009 1 次提交
  5. 09 11月, 2009 1 次提交
  6. 07 11月, 2009 1 次提交
    • M
      hisax: remove bad udelay call to fix build error on ARM · cc05368c
      Martin Michlmayr 提交于
      The hisax ISDN driver fails to build on ARM with CONFIG_HISAX_ELSA:
      
      | drivers/built-in.o: In function `modem_set_dial':
      | drivers/isdn/hisax/elsa_ser.c:535: undefined reference to `__bad_udelay'
      | drivers/isdn/hisax/elsa_ser.c:544: undefined reference to `__bad_udelay'
      | drivers/built-in.o: In function `modem_set_init':
      | drivers/isdn/hisax/elsa_ser.c:486: undefined reference to `__bad_udelay'
      | [...]
      
      According to the comment in arch/arm/include/asm/delay.h, __bad_udelay
      is specifically designed on ARM to produce a build failure when udelay
      is called with a value > 2000.
      Signed-off-by: NMartin Michlmayr <tbm@cyrius.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      cc05368c
  7. 06 11月, 2009 1 次提交
  8. 05 11月, 2009 6 次提交
  9. 29 10月, 2009 9 次提交
  10. 23 10月, 2009 1 次提交
    • X
      isdn: fix possible circular locking dependency · 2bd9af04
      Xiaotian Feng 提交于
      There's a circular locking dependency:
      
      ---> isdn_net_get_locked_lp
          --->lock &nd->queue_lock
          --->lock &nd->queue->xmit_lock
          .....................
          ---->unlock &nd->queue_lock
      
      ---> isdn_net_writebuf_skb (called with &nd->queue->xmit_lock locked)
          ---->isdn_net_inc_frame_cnt
               ---->isdn_net_device_busy
                    ----> lock &nd->queue_lock
      
      This will trigger lockdep warnings:
      
       =======================================================
       [ INFO: possible circular locking dependency detected ]
       2.6.32-rc4-testing #7
       -------------------------------------------------------
       ipppd/28379 is trying to acquire lock:
       (&netdev->queue_lock){......}, at: [<e62ad0fd>] isdn_net_device_busy+0x2c/0x74 [isdn]
      
       but task is already holding lock:
       (&netdev->local->xmit_lock){+.....}, at: [<e62aefc2>] isdn_net_write_super+0x3f/0x6e [isdn]
      
       which lock already depends on the new lock.
       .......
      
       We don't need to lock nd->queue->xmit_lock to protect single
      isdn_net_lp_busy(). This can fix above lockdep warnings.
      Reported-and-tested-by: NTilman Schmidt <tilman@imap.cc>
      Signed-off-by: NXiaotian Feng <xtfeng@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2bd9af04
  11. 12 10月, 2009 1 次提交
  12. 07 10月, 2009 13 次提交