提交 a8676066 编写于 作者: R Romain Bezut 提交者: Bjorn Helgaas

PCI/MSI: Export all remapped MSIs to sysfs attributes

irqbalance uses sysfs attributes to populate its internal database, which
is then used to bind the IRQ to the appropriate NUMA node.

On a device accepting multiple MSIs and with interrupt remapping enabled,
only the first IRQ entry is exported in the "msi_irqs" directory.  This
results in irqbalance having no clue of the NUMA affinity for the extra
IRQs, so it can't bind them to the correct node.

Export all MSI interrupts as sysfs attributes when relevant.

[bhelgaas: changelog]
Signed-off-by: NRomain Bezut <rbezut@gmail.com>
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NThomas Gleixner <tglx@linutronix.de>
上级 10b4ad1a
...@@ -475,10 +475,11 @@ static int populate_msi_sysfs(struct pci_dev *pdev) ...@@ -475,10 +475,11 @@ static int populate_msi_sysfs(struct pci_dev *pdev)
int ret = -ENOMEM; int ret = -ENOMEM;
int num_msi = 0; int num_msi = 0;
int count = 0; int count = 0;
int i;
/* Determine how many msi entries we have */ /* Determine how many msi entries we have */
for_each_pci_msi_entry(entry, pdev) for_each_pci_msi_entry(entry, pdev)
++num_msi; num_msi += entry->nvec_used;
if (!num_msi) if (!num_msi)
return 0; return 0;
...@@ -487,19 +488,21 @@ static int populate_msi_sysfs(struct pci_dev *pdev) ...@@ -487,19 +488,21 @@ static int populate_msi_sysfs(struct pci_dev *pdev)
if (!msi_attrs) if (!msi_attrs)
return -ENOMEM; return -ENOMEM;
for_each_pci_msi_entry(entry, pdev) { for_each_pci_msi_entry(entry, pdev) {
msi_dev_attr = kzalloc(sizeof(*msi_dev_attr), GFP_KERNEL); for (i = 0; i < entry->nvec_used; i++) {
if (!msi_dev_attr) msi_dev_attr = kzalloc(sizeof(*msi_dev_attr), GFP_KERNEL);
goto error_attrs; if (!msi_dev_attr)
msi_attrs[count] = &msi_dev_attr->attr; goto error_attrs;
msi_attrs[count] = &msi_dev_attr->attr;
sysfs_attr_init(&msi_dev_attr->attr);
msi_dev_attr->attr.name = kasprintf(GFP_KERNEL, "%d", sysfs_attr_init(&msi_dev_attr->attr);
entry->irq); msi_dev_attr->attr.name = kasprintf(GFP_KERNEL, "%d",
if (!msi_dev_attr->attr.name) entry->irq + i);
goto error_attrs; if (!msi_dev_attr->attr.name)
msi_dev_attr->attr.mode = S_IRUGO; goto error_attrs;
msi_dev_attr->show = msi_mode_show; msi_dev_attr->attr.mode = S_IRUGO;
++count; msi_dev_attr->show = msi_mode_show;
++count;
}
} }
msi_irq_group = kzalloc(sizeof(*msi_irq_group), GFP_KERNEL); msi_irq_group = kzalloc(sizeof(*msi_irq_group), GFP_KERNEL);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册