提交 a3b2c8c7 编写于 作者: M Mathias Krause 提交者: Greg Kroah-Hartman

debugfs: write_file_bool() - ensure strtobool() operates on valid data

In case, userland writes an empty string to a bool debugfs file, buf[]
will still be uninitialized when being passed to strtobool() making the
outcome of that function purely random.

Fix this by always zero-terminating the buffer.
Signed-off-by: NMathias Krause <minipli@googlemail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 3a76e5e0
...@@ -473,6 +473,7 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf, ...@@ -473,6 +473,7 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf,
if (copy_from_user(buf, user_buf, buf_size)) if (copy_from_user(buf, user_buf, buf_size))
return -EFAULT; return -EFAULT;
buf[buf_size] = '\0';
if (strtobool(buf, &bv) == 0) if (strtobool(buf, &bv) == 0)
*val = bv; *val = bv;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册