提交 531bc938 编写于 作者: B Ben Dooks 提交者: Felipe Balbi

usb: gadget: r8a66597-udc: use devm_kzalloc() to allocate driver state

Update driver to use devm_kzalloc() to make tracking of resources
easier. Also remove the exit point via cleanup as there's no
cleanup necessary from this point now.

As a note, also removes the error print as the allocation calls
produce errors if they do not return memory.
Signed-off-by: NBen Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: NFelipe Balbi <balbi@ti.com>
上级 f390f57c
......@@ -1836,7 +1836,6 @@ static int __exit r8a66597_remove(struct platform_device *pdev)
clk_put(r8a66597->clk);
}
kfree(r8a66597);
return 0;
}
......@@ -1892,11 +1891,9 @@ static int __init r8a66597_probe(struct platform_device *pdev)
}
/* initialize ucd */
r8a66597 = kzalloc(sizeof(struct r8a66597), GFP_KERNEL);
if (r8a66597 == NULL) {
ret = -ENOMEM;
goto clean_up;
}
r8a66597 = devm_kzalloc(dev, sizeof(struct r8a66597), GFP_KERNEL);
if (r8a66597 == NULL)
return -ENOMEM;
spin_lock_init(&r8a66597->lock);
platform_set_drvdata(pdev, r8a66597);
......@@ -1995,7 +1992,6 @@ static int __init r8a66597_probe(struct platform_device *pdev)
if (r8a66597->ep0_req)
r8a66597_free_request(&r8a66597->ep[0].ep,
r8a66597->ep0_req);
kfree(r8a66597);
}
return ret;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册