• J
    perf annotate: Align source and offset lines · f48e7c40
    Jiri Olsa 提交于
    Align source with offset lines, which are more advanced, because of the
    address column.
    
      Before:
             :      static void *worker_thread(void *__tdata)
             :      {
        0.00 :        48a971:       push   %rbp
        0.00 :        48a972:       mov    %rsp,%rbp
        0.00 :        48a975:       sub    $0x30,%rsp
        0.00 :        48a979:       mov    %rdi,-0x28(%rbp)
        0.00 :        48a97d:       mov    %fs:0x28,%rax
        0.00 :        48a986:       mov    %rax,-0x8(%rbp)
        0.00 :        48a98a:       xor    %eax,%eax
             :              struct thread_data *td = __tdata;
        0.00 :        48a98c:       mov    -0x28(%rbp),%rax
        0.00 :        48a990:       mov    %rax,-0x10(%rbp)
             :              int m = 0, i;
        0.00 :        48a994:       movl   $0x0,-0x1c(%rbp)
             :              int ret;
             :
             :              for (i = 0; i < loops; i++) {
        0.00 :        48a99b:       movl   $0x0,-0x18(%rbp)
    
      After:
             :              static void *worker_thread(void *__tdata)
             :              {
        0.00 :       48a971:       push   %rbp
        0.00 :       48a972:       mov    %rsp,%rbp
        0.00 :       48a975:       sub    $0x30,%rsp
        0.00 :       48a979:       mov    %rdi,-0x28(%rbp)
        0.00 :       48a97d:       mov    %fs:0x28,%rax
        0.00 :       48a986:       mov    %rax,-0x8(%rbp)
        0.00 :       48a98a:       xor    %eax,%eax
             :                      struct thread_data *td = __tdata;
        0.00 :       48a98c:       mov    -0x28(%rbp),%rax
        0.00 :       48a990:       mov    %rax,-0x10(%rbp)
             :                      int m = 0, i;
        0.00 :       48a994:       movl   $0x0,-0x1c(%rbp)
             :                      int ret;
             :
             :                      for (i = 0; i < loops; i++) {
        0.00 :       48a99b:       movl   $0x0,-0x18(%rbp)
    
    It makes bigger different when displaying script sources, where the
    comment lines looks oddly shifted from the lines which actually hold
    code. I'll send script support separately.
    
    Committer note:
    
    Do not use a fixed column width for the addresses, as kernel ones se
    more than 10 columns, look at the last offset and get the right width.
    Signed-off-by: NJiri Olsa <jolsa@kernel.org>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20171011150158.11895-36-jolsa@kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
    f48e7c40
annotate.c 47.0 KB