• D
    afs: Improve FS server rotation error handling · e7f680f4
    David Howells 提交于
    Improve the error handling in FS server rotation by:
    
     (1) Cache the latest useful error value for the fs operation as a whole in
         struct afs_fs_cursor separately from the error cached in the
         afs_addr_cursor struct.  The one in the address cursor gets clobbered
         occasionally.  Copy over the error to the fs operation only when it's
         something we'd be interested in passing to userspace.
    
     (2) Make it so that EDESTADDRREQ is the default that is seen only if no
         addresses are available to be accessed.
    
     (3) When calling utility functions, such as checking a volume status or
         probing a fileserver, don't let a successful result clobber the cached
         error in the cursor; instead, stash the result in a temporary variable
         until it has been assessed.
    
     (4) Don't return ETIMEDOUT or ETIME if a better error, such as
         ENETUNREACH, is already cached.
    
     (5) On leaving the rotation loop, turn any remote abort code into a more
         useful error than ECONNABORTED.
    
    Fixes: d2ddc776 ("afs: Overhaul volume and server record caching and fileserver rotation")
    Signed-off-by: NDavid Howells <dhowells@redhat.com>
    e7f680f4
internal.h 43.0 KB