• E
    tipc: simplify print buffer handling in tipc_printf · e2dbd601
    Erik Hugne 提交于
    tipc_printf was previously used both to construct debug traces
    and to append data to buffers that should be sent over netlink
    to the tipc-config application.  A global print_buffer was
    used to format the string before it was copied to the actual
    output buffer.  This could lead to concurrent access of the
    global print_buffer, which then had to be lock protected.
    This is simplified by changing tipc_printf to append data
    directly to the output buffer using vscnprintf.
    
    With the new implementation of tipc_printf, there is no longer
    any risk of concurrent access to the internal log buffer, so
    the lock (and the comments describing it) are no longer
    strictly necessary.  However, there are still a few functions
    that do grab this lock before resizing/dumping the log
    buffer.  We leave the lock, and these functions untouched since
    they will be removed with a subsequent commit that drops the
    deprecated log buffer handling code
    Signed-off-by: NErik Hugne <erik.hugne@ericsson.com>
    Signed-off-by: NJon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: NPaul Gortmaker <paul.gortmaker@windriver.com>
    e2dbd601
log.c 8.8 KB