• C
    NFS: Clean up address comparison in __nfs_find_client() · d45273ed
    Chuck Lever 提交于
    The address comparison in the __nfs_find_client() function is deceptive.
    It uses a memcmp() to check a pair of u32 fields for equality.  Not only is
    this inefficient, but usually memcmp() is used for comparing two *whole*
    sockaddr_in's (which includes comparisons of the address family and port
    number), so it's easy to mistake the comparison here for a whole sockaddr
    comparison, which it isn't.
    
    So for clarity and efficiency, we replace the memcmp() with a simple test
    for equality between the two s_addr fields.  This should have no
    behavioral effect.
    Signed-off-by: NChuck Lever <chuck.lever@oracle.com>
    Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
    d45273ed
client.c 34.2 KB