• L
    staging: r8188eu: Fix Smatch off-by-one warning in hal/rtl8188e_hal_init.c · df80fb63
    Larry Finger 提交于
    Smatch reports the following warning:
    "drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2008
    Hal_ReadPowerValueFromPROM_8188E()
    	 error: buffer overflow 'pwrInfo24G->IndexBW40_Base[rfPath]' 5 <= 5"
    
    drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
      2005                          /* 2.4G default value */
      2006                          for (group = 0; group < MAX_CHNL_GROUP_24G; group++) {
      2007                                  pwrInfo24G->IndexCCK_Base[rfPath][group] =      EEPROM_DEFAULT_24G_INDEX;
      2008                                  pwrInfo24G->IndexBW40_Base[rfPath][group] =     EEPROM_DEFAULT_24G_INDEX;
    
    The reason is that IndexCCK_Base[] has MAX_CHNL_GROUP_24G elements, but
    IndexBW40_Base is smaller by 1. Make them both have MAX_CHNL_GROUP_24G
    elements.
    
    Reported by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    df80fb63
rtl8188e_hal.h 14.7 KB