• F
    perf tools: callchain: Fix sum of percentages to be 100% by displaying amount... · 25446036
    Frederic Weisbecker 提交于
    perf tools: callchain: Fix sum of percentages to be 100% by displaying amount of ignored chains in fractal mode
    
    When we filter the callchains below a given percentage, we
    ignore them and the end result only shows entries that have an
    upper percentage than the filter threshold.
    
    It seems to users then that we have an imbalance in the
    percentage, as if the sum inside a profiled branch doesn't
    reach 100%.
    
    Since in the past there have been real perf report bugs that
    showed the same sypmtom, it would be nice to assure the user
    that the data is perfect and trustable and it all sums up to
    100.00%.
    
    So fix this by displaying the remaining hits that have been
    filtered but without more detail than their amount in each
    branches. Example while filtering below 50%:
    
    7.73%  [k] delay_tsc
                    |
                    |--98.22%-- __const_udelay
                    |          |
                    |          |--86.37%-- ath5k_hw_register_timeout
                    |          |          ath5k_hw_noise_floor_calibration
                    |          |          ath5k_hw_reset
                    |          |          ath5k_reset
                    |          |          ath5k_config
                    |          |          ieee80211_hw_config
                    |          |          |
                    |          |          |--88.53%-- ieee80211_scan_work
                    |          |          |          worker_thread
                    |          |          |          kthread
                    |          |          |          child_rip
                    |          |           --11.47%-- [...]
                    |           --13.63%-- [...]
                     --1.78%-- [...]
    Reported-by: NIngo Molnar <mingo@elte.hu>
    Signed-off-by: NFrederic Weisbecker <fweisbec@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    LKML-Reference: <1249690585-9145-4-git-send-email-fweisbec@gmail.com>
    Signed-off-by: NIngo Molnar <mingo@elte.hu>
    25446036
builtin-report.c 44.4 KB