• E
    KVM/x86: remove WARN_ON() for when vm_munmap() fails · 103c763c
    Eric Biggers 提交于
    On x86, special KVM memslots such as the TSS region have anonymous
    memory mappings created on behalf of userspace, and these mappings are
    removed when the VM is destroyed.
    
    It is however possible for removing these mappings via vm_munmap() to
    fail.  This can most easily happen if the thread receives SIGKILL while
    it's waiting to acquire ->mmap_sem.   This triggers the 'WARN_ON(r < 0)'
    in __x86_set_memory_region().  syzkaller was able to hit this, using
    'exit()' to send the SIGKILL.  Note that while the vm_munmap() failure
    results in the mapping not being removed immediately, it is not leaked
    forever but rather will be freed when the process exits.
    
    It's not really possible to handle this failure properly, so almost
    every other caller of vm_munmap() doesn't check the return value.  It's
    a limitation of having the kernel manage these mappings rather than
    userspace.
    
    So just remove the WARN_ON() so that users can't spam the kernel log
    with this warning.
    
    Fixes: f0d648bd ("KVM: x86: map/unmap private slots in __x86_set_memory_region")
    Reported-by: Nsyzbot <syzkaller@googlegroups.com>
    Signed-off-by: NEric Biggers <ebiggers@google.com>
    Signed-off-by: NRadim Krčmář <rkrcmar@redhat.com>
    103c763c
x86.c 232.5 KB